clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land.
Just fix the one issue where we use the FileSpec operator== and this is good to go! ================ Comment at: lldb/source/Core/AddressRange.cpp:59 + // the file addresses in this case only. + return ContainsFileAddress(addr); +} ---------------- It might be worth scanning the code to see if anyone is using AddressRange::ContainsFileAddress() incorrectly. It is fine to use this within a module to check if an address is in the range, but not ok if the address can come from a different module. ================ Comment at: lldb/source/Target/Trace.cpp:114 + + return FileSpec::Compare(a.file, b.file, true) == 0; +} ---------------- No need to compare, just use == operator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100740/new/ https://reviews.llvm.org/D100740 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
