[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

jankratochvil added a comment. Ping, it would be nice to know if there is some plan/schedule for patch review of this series. I understand it is all voluntary, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96236/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D91963: [lldb] [test/Register] Initial tests for regsets in core dumps [WIP]

mgorny updated this revision to Diff 338527. mgorny edited the summary of this revision. mgorny added a comment. Now includes a small-ish Python scripts to strip unnecessary data from coredumps. For now, it just strips everything but the PT_NOTE segment. Headers aren't modified, so holes are ins

[Lldb-commits] [PATCH] D91963: [lldb] [test/Register] Initial tests for regsets in core dumps [WIP]

mgorny added a comment. New sizes: $ ls -lh *.core -rw--- 1 mgorny mgorny 13K 04-19 17:11 x86-32-freebsd.core -rw--- 1 mgorny mgorny 5,1K 04-19 17:11 x86-32-linux.core -rw--- 1 mgorny mgorny 2,7K 04-19 17:11 x86-32-netbsd.core -rw--- 1 mgorny mgorny 15K 04-19 17:11 x86

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

teemperor added a comment. I think this might have broken the Windows build as it seems the LLDBSwigLuaBreakpointCallbackFunction return type is an error for MSVC (and not a warning which we seem to ignore locally). To quote someone from the Discord server: I'm getting the following build er

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

JDevlieghere added a subscriber: kastiglione. JDevlieghere added a comment. In D91508#2698704 , @teemperor wrote: > I think this might have broken the Windows build as it seems the > LLDBSwigLuaBreakpointCallbackFunction return type is an error for MSVC (

[Lldb-commits] [lldb] 2cbd3b0 - [lldb] Support "absolute memory address" images in crashlog.py

Author: Jonas Devlieghere Date: 2021-04-19T10:27:11-07:00 New Revision: 2cbd3b04feaaaff7fab4c6500476839a23180886 URL: https://github.com/llvm/llvm-project/commit/2cbd3b04feaaaff7fab4c6500476839a23180886 DIFF: https://github.com/llvm/llvm-project/commit/2cbd3b04feaaaff7fab4c6500476839a23180886.d

[Lldb-commits] [PATCH] D100340: [lldb-vscode] Add postRunCommands

clayborg added a comment. "postRunCommands" might be clearer as "firstStopCommands"? Not sure, but I wanted to mention it. Comment at: lldb/tools/lldb-vscode/package.json:166 + "type": "array", +

[Lldb-commits] [lldb] f741475 - [lldb] Print the fixed address if symbolication fails in DumpDataExtractor

Author: Jonas Devlieghere Date: 2021-04-19T12:23:23-07:00 New Revision: f7414759d739fc102f72432562e9aeb0a7424e66 URL: https://github.com/llvm/llvm-project/commit/f7414759d739fc102f72432562e9aeb0a7424e66 DIFF: https://github.com/llvm/llvm-project/commit/f7414759d739fc102f72432562e9aeb0a7424e66.d

[Lldb-commits] [lldb] a771209 - [lldb] Update breakpoint_function_callback.test for different error message

Author: Jonas Devlieghere Date: 2021-04-19T12:23:23-07:00 New Revision: a7712091ea7a2b4a7b5c4764af7545a7574b651b URL: https://github.com/llvm/llvm-project/commit/a7712091ea7a2b4a7b5c4764af7545a7574b651b DIFF: https://github.com/llvm/llvm-project/commit/a7712091ea7a2b4a7b5c4764af7545a7574b651b.d

[Lldb-commits] [lldb] cc68799 - [lldb] Stop unsetting LLDB_DEBUGSERVER_PATH from TestLaunchProcessPosixSpawn

Author: Jonas Devlieghere Date: 2021-04-19T12:28:22-07:00 New Revision: cc68799056da5c2159fa51425f998588ac650171 URL: https://github.com/llvm/llvm-project/commit/cc68799056da5c2159fa51425f998588ac650171 DIFF: https://github.com/llvm/llvm-project/commit/cc68799056da5c2159fa51425f998588ac650171.d

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

rupprecht created this revision. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `RichManglingContext::FromCxxMethodName` allocates a m_cxx_method_parser, but never deletes it. This fixes a `-DLLVM_USE_SANITIZER=Leaks` failure.

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

MaskRay created this revision. MaskRay added reviewers: labath, rupprecht. Herald added a reviewer: shafik. MaskRay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes 6 check-lldb-shell failures in a `-DLLVM_USE_SANITIZER=Leaks` bui

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

clayborg added a comment. I have been meaning to get to this for a while, thanks for taking this on! It would be great if we can actually select the selected stack frame as well when this the process view is initialized. Same kind of code as with the selected thread. See inline comments. ===

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

clayborg added a comment. Including the inlined comments for showing and selecting the selected frame. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2211-2213 + if (selected_thread->GetID() == thread->GetID()) { +item[i].Expand(); + } ---

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

teemperor added a comment. Thanks for fixing this, I guess we really need a leak sanitizer/valgrind bot for LLDB... I just have some minor comments but otherwise this LGTM. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1229 if (!function_decl

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

shafik added inline comments. Comment at: lldb/source/Core/RichManglingContext.cpp:24 + std::free(m_ipd_buf); + if (m_cxx_method_parser.hasValue()) { +assert(m_provider == PluginCxxLanguage); This code is duplicated from `ResetProvider(...)` we should facto

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

MaskRay updated this revision to Diff 338664. MaskRay marked an inline comment as done. MaskRay added a comment. buf -> name_buf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100800/new/ https://reviews.llvm.org/D100800 Files: lldb/source/Plugin

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

MaskRay added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1229 if (!function_decl) { +char *buf = nullptr; llvm::StringRef name = attrs.name.GetStringRef(); teemperor wrote: > `name_buf` ? From

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

MaskRay added a comment. In D100800#2699940 , @teemperor wrote: > Thanks for fixing this, I guess we really need a leak sanitizer/valgrind bot > for LLDB... > > I just have some minor comments but otherwise this LGTM. Agree.. The 45+ `check-lldb` failur

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

rupprecht updated this revision to Diff 338665. rupprecht added a comment. - Refactor cleanup of m_cxx_method_parser Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100795/new/ https://reviews.llvm.org/D100795 Files: lldb/include/lldb/Core/RichMan

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. I still kinda like the unique_ptr deleter but let's not block bot-fixes with refactoring requests. I'll open a review for the unique_ptr as a follow up. In D100800#2699984

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1249 attrs.is_inline); +free(buf); MaskRay wrote: > teemperor wrote: > > `std::free` ? > `std::` for C library functions is uncommon. >

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

JDevlieghere added a comment. In D100800#271 , @teemperor wrote: > LGTM. I still kinda like the unique_ptr deleter but let's not block bot-fixes > with refactoring requests. I'll open a review for the unique_ptr as a follow > up. > > In D100800#2699

[Lldb-commits] [lldb] a2cd6d0 - [lldb] Fix demangler leaks in the DWARF AST parser

Author: Fangrui Song Date: 2021-04-19T16:36:54-07:00 New Revision: a2cd6d07691a645bfb8fb5eeeba2eb5970312c7f URL: https://github.com/llvm/llvm-project/commit/a2cd6d07691a645bfb8fb5eeeba2eb5970312c7f DIFF: https://github.com/llvm/llvm-project/commit/a2cd6d07691a645bfb8fb5eeeba2eb5970312c7f.diff

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2cd6d07691a: [lldb] Fix demangler leaks in the DWARF AST parser (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D100800: [lldb] Fix demangler leaks in the DWARF AST parser

MaskRay added a comment. The remaining failures are on Linux x86-64 in a `-DLLVM_USE_SANITIZER=Leaks` build (`Address` should achieve the same effect because on many targets asan enables LeakSanitizer) Failed Tests (45): lldb-shell :: Reproducer/Functionalities/TestDataFormatter.test

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

MaskRay created this revision. MaskRay added reviewers: JDevlieghere, rupprecht, shafik, teemperor. MaskRay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use a variable of static storage duration to reference an intentionally leaked varia

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

MaskRay added a comment. @JDevlieghere The Reproducer library seems to have several other leaks. Maybe you'd like to look at them? :) I am unfamiliar with the code... ==2013285==ERROR: LeakSanitizer: detected memory leaks Direct leak of 32 byte(s) in 2 object(s) allocated from: #0 0

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

rupprecht added inline comments. Comment at: lldb/tools/driver/Driver.cpp:856 if (const char *reproducer_path = SBReproducer::GetPath()) { // Leaking the string on purpose. +static std::string *finalize_cmd = new std::string(argv0); This i

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. This LGTM In D100806#2700111 , @MaskRay wrote: > @JDevlieghere The Reproducer library seems to have several other leaks. Maybe > you'd li

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

MaskRay updated this revision to Diff 338688. MaskRay marked an inline comment as done. MaskRay added a comment. remove a stale comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100806/new/ https://reviews.llvm.org/D100806 Files: lldb/tools/

[Lldb-commits] [lldb] cdae6d7 - [lldb] Fix one leak in reproducer

Author: Fangrui Song Date: 2021-04-19T19:39:10-07:00 New Revision: cdae6d7711d621c19623ae4fbfdde9e0301260c7 URL: https://github.com/llvm/llvm-project/commit/cdae6d7711d621c19623ae4fbfdde9e0301260c7 DIFF: https://github.com/llvm/llvm-project/commit/cdae6d7711d621c19623ae4fbfdde9e0301260c7.diff

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdae6d7711d6: [lldb] Fix one leak in reproducer (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

dblaikie added inline comments. Comment at: lldb/tools/driver/Driver.cpp:856 if (const char *reproducer_path = SBReproducer::GetPath()) { -// Leaking the string on purpose. -std::string *finalize_cmd = new std::string(argv0); +static std::string *fi

[Lldb-commits] [PATCH] D100806: [lldb] Fix one leak in reproducer

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: lldb/tools/driver/Driver.cpp:856 if (const char *reproducer_path = SBReproducer::GetPath()) { -// Leaking the string on purpose. -std::string *finalize_cmd = new std::strin