shafik added inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1249
attrs.is_inline);
+ free(buf);
----------------
MaskRay wrote:
> teemperor wrote:
> > `std::free` ?
> `std::` for C library functions is uncommon.
>
> For some common functions (free,strcpy,memset,memcpy,...), the unqualified
> version is more common. I can find some `::foo` as well but `std::foo` is
> really rare.
In C++ we should be using `std::`. It seems we are not consistent in when we
include the `.h` files instead of `cname` versions.
So if we use the `cname` version e.g. `cstdlib` then it is unspecified if the
functions are defined in the global namespace or not see
[headers](http://eel.is/c++draft/headers#5.sentence-3).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100800/new/
https://reviews.llvm.org/D100800
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
