[Lldb-commits] [PATCH] D99847: [LLDB] Fix building for aarch64 windows after d6d3d21cd1cb1567eaf7ff8c0867b07227a19d99

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM (we should have caught this on our WoA bots but they've been failing earlier in the builds) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D99847: [LLDB] Fix building for aarch64 windows after d6d3d21cd1cb1567eaf7ff8c0867b07227a19d99

mstorsjo added a comment. In D99847#2670586 , @DavidSpickett wrote: > LGTM > > (we should have caught this on our WoA bots but they've been failing earlier > in the builds) Thanks, and it's good to hear that you've got a bot for testing this too (I tes

[Lldb-commits] [lldb] f8f4d8f - [lldb] Improve CPUInfo test predicate

Author: David Spickett Date: 2021-04-06T10:46:47+01:00 New Revision: f8f4d8f87ba4c1fbb18a4e7f4a5ea03a8b8ec061 URL: https://github.com/llvm/llvm-project/commit/f8f4d8f87ba4c1fbb18a4e7f4a5ea03a8b8ec061 DIFF: https://github.com/llvm/llvm-project/commit/f8f4d8f87ba4c1fbb18a4e7f4a5ea03a8b8ec061.diff

[Lldb-commits] [PATCH] D99729: [lldb] Improve CPUInfo test predicate

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8f4d8f87ba4: [lldb] Improve CPUInfo test predicate (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99729/new/ https://reviews.ll

[Lldb-commits] [PATCH] D99941: [LLDB] Support AArch64 PAC elf-core register read

omjavaid created this revision. omjavaid added reviewers: labath, DavidSpickett. Herald added subscribers: danielkiss, kristof.beyls. omjavaid requested review of this revision. This adds support for reading AArch64 Pointer Authentication regset from elf-core file. Also includes a test-case for th

[Lldb-commits] [lldb] 476e087 - [LLDB] Fix building for aarch64 windows after d6d3d21cd1cb1567eaf7ff8c0867b07227a19d99

Author: Martin Storsjö Date: 2021-04-06T14:03:42+03:00 New Revision: 476e087939e4c7cda4de9fa3bc998aea62da4096 URL: https://github.com/llvm/llvm-project/commit/476e087939e4c7cda4de9fa3bc998aea62da4096 DIFF: https://github.com/llvm/llvm-project/commit/476e087939e4c7cda4de9fa3bc998aea62da4096.diff

[Lldb-commits] [PATCH] D99847: [LLDB] Fix building for aarch64 windows after d6d3d21cd1cb1567eaf7ff8c0867b07227a19d99

This revision was automatically updated to reflect the committed changes. Closed by commit rG476e087939e4: [LLDB] Fix building for aarch64 windows after… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99847/new/ https://review

[Lldb-commits] [PATCH] D99941: [LLDB] Support AArch64 PAC elf-core register read

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:32 + if (pac_data.GetByteSize() > sizeof(uint64_t)) +opt_regsets.Set(RegisterInfoPOSIX_arm64::eRegsetMaskPAuth); + How is the `sizeof()`

[Lldb-commits] [lldb] 82b3e28 - [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

Author: Abhina Sreeskantharajan Date: 2021-04-06T07:23:31-04:00 New Revision: 82b3e28e836d2f5c8cfd6e1047b93c088522365a URL: https://github.com/llvm/llvm-project/commit/82b3e28e836d2f5c8cfd6e1047b93c088522365a DIFF: https://github.com/llvm/llvm-project/commit/82b3e28e836d2f5c8cfd6e1047b93c088522

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 PAC elf-core stack unwinder support

omjavaid created this revision. omjavaid added reviewers: labath, justincohen, jasonmolenda, DavidSpickett. Herald added subscribers: danielkiss, kristof.beyls. omjavaid requested review of this revision. This patch adds a new field to Process class which represents no of bits used for addresses b

[Lldb-commits] [PATCH] D99947: [LLDB] AArch64 Linux PAC unwinder support

omjavaid created this revision. omjavaid added reviewers: labath, DavidSpickett. Herald added subscribers: danielkiss, kristof.beyls. omjavaid requested review of this revision. This patch adds support to detect and set address bits in use by the current AArch64 process. We are going to utilize AA

[Lldb-commits] [lldb] bdfee7d - [lldb][NFC] Fix misleading indentation in Cocoa.cpp

Author: Raphael Isemann Date: 2021-04-06T14:30:47+02:00 New Revision: bdfee7d5e1924eb5ca7333b1da339cf21a481409 URL: https://github.com/llvm/llvm-project/commit/bdfee7d5e1924eb5ca7333b1da339cf21a481409 DIFF: https://github.com/llvm/llvm-project/commit/bdfee7d5e1924eb5ca7333b1da339cf21a481409.dif

[Lldb-commits] [PATCH] D99827: Clarifying the documentation for variable formatting wrt to qualifiers and adding a test that demonstrates this

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! FWIW, there are actually a lot more 'qualifiers' supported in Clang that are ignored by the formatters (`restrict`, Obj-C garbage collector descriptions, custom address spa

[Lldb-commits] [PATCH] D99890: [lldb] Fix bug where memory read --outfile is not truncating the file

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for the patch! I'll be extra nit-picky about the test to make up for the great meme steal of 2021. Comment at: lldb/test/API/functionalities/memory/re

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 335157. Ericson2314 added a comment. Don't use CMAKE_INTALL_LIBDIR or convert compiler-rt for now These steps were suggested by @compnerd, IIUC. The compiler-rt stuff is in flux because I am now skeptical whether `COMPILER_RT_INSTALL_PATH` can now be so e

[Lldb-commits] [PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2666341 , @aganea wrote: > In D99426#2666141 , > @abhina.sreeskantharajan wrote: > >> In D99426#2665361 , @aganea wrote: >

[Lldb-commits] [PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. Is there any more feedback on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/ https://reviews.llvm.org/D99426 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Meinersbur added a comment. In D99484#2668225 , @Ericson2314 wrote: > Additionally, I have cleaned up the `polly` code so that I need not change it > so much, and it should still work with absolute or relative paths quite > flexibly. Looks fine to me. R

[Lldb-commits] [PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

yroux added a comment. Hi, Sorry I'm bit lost in the various patches proposed to fix the issue introduced by https://reviews.llvm.org/D97785 My understanding is that this is missing one to fix our Windows on ARM bots (broken for more than 2 weeks now) So it'd be great to have it applied Repo

[Lldb-commits] [PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82b3e28e836d: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead… (authored by abhina.sreeskantharajan). Repository:

[Lldb-commits] [PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

yroux added a comment. > I've committed this and it looks like the bot is back to green :) > https://lab.llvm.org/buildbot/#/builders/65/builds/1400. Sorry for the > delayed fix Great, thanks a lot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2670552 , @yroux wrote: > Hi, > > Sorry I'm bit lost in the various patches proposed to fix the issue > introduced by https://reviews.llvm.org/D97785 > My understanding is that this is missing one to fix

[Lldb-commits] [PATCH] D99890: [lldb] Fix bug where memory read --outfile is not truncating the file

JDevlieghere marked 5 inline comments as done. JDevlieghere added a comment. In D99890#2671042 , @teemperor wrote: > Thanks for the patch! I'll be extra nit-picky about the test to make up for > the great meme steal of 2021. Credit was given, so I do not

[Lldb-commits] [PATCH] D99890: [lldb] Fix bug where memory read --outfile is not truncating the file

JDevlieghere updated this revision to Diff 335525. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99890/new/ https://reviews.llvm.org/D99890 Files: lldb/source/Commands/CommandObjectMemory.cpp lldb/test/API/functionalities/memory/read/TestMemoryRead.py Index: lldb/test/API/functional

[Lldb-commits] [PATCH] D99890: [lldb] Fix bug where memory read --outfile is not truncating the file

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM now beside the now redundant import Comment at: lldb/test/API/functionalities/memory/read/TestMemoryRead.py:7 import lldbsuite.test.lldbutil as lldbutil +import t

[Lldb-commits] [lldb] 710651c - [lldb] Fix bug where memory read --outfile is not truncating the file

Author: Jonas Devlieghere Date: 2021-04-06T09:16:28-07:00 New Revision: 710651c61dcdb2f969811b9a8c7efb425b5e2918 URL: https://github.com/llvm/llvm-project/commit/710651c61dcdb2f969811b9a8c7efb425b5e2918 DIFF: https://github.com/llvm/llvm-project/commit/710651c61dcdb2f969811b9a8c7efb425b5e2918.d

[Lldb-commits] [PATCH] D99890: [lldb] Fix bug where memory read --outfile is not truncating the file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG710651c61dcd: [lldb] Fix bug where memory read --outfile is not truncating the file (authored by JDevlieghere). Herald added a project: LLDB. Change

[Lldb-commits] [PATCH] D99694: Add support for getting signed ObjC tagged pointer values

stella.stamenova added a comment. The latest change (commit be0ced03 ) issues the following warning: /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D

[Lldb-commits] [PATCH] D99694: Add support for getting signed ObjC tagged pointer values

stella.stamenova added a subscriber: teemperor. stella.stamenova added a comment. It looks like @teemperor fixed it already! In D99694#2671640 , @stella.stamenova wrote: > The latest change (commit be0ced03 >

[Lldb-commits] [lldb] dc8d63d - [lldb] Format Plugins/Language/ObjC/Cocoa.cpp (NFC)

Author: Jonas Devlieghere Date: 2021-04-06T09:47:46-07:00 New Revision: dc8d63de5d5ec987b89256564a038cb580cae607 URL: https://github.com/llvm/llvm-project/commit/dc8d63de5d5ec987b89256564a038cb580cae607 DIFF: https://github.com/llvm/llvm-project/commit/dc8d63de5d5ec987b89256564a038cb580cae607.d

[Lldb-commits] [lldb] 801cea2 - [lldb] Fix else-after-return in AppleObjCRuntimeV2 (NFC)

Author: Jonas Devlieghere Date: 2021-04-06T10:07:22-07:00 New Revision: 801cea2ce9515cc6b6c9b59dfac6e48074737da1 URL: https://github.com/llvm/llvm-project/commit/801cea2ce9515cc6b6c9b59dfac6e48074737da1 DIFF: https://github.com/llvm/llvm-project/commit/801cea2ce9515cc6b6c9b59dfac6e48074737da1.d

[Lldb-commits] [PATCH] D96715: [lldb] Decouple IsMasterPlan and OkayToDiscard (NFC)

kastiglione added a comment. friendly ping @jingham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96715/new/ https://reviews.llvm.org/D96715 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D96715: [lldb] Decouple IsMasterPlan and OkayToDiscard (NFC)

jingham added a comment. I don't understand how DiscardPlansConsultingMasterPlan in this patch works. With your changes, every plan but the ObjC trampoline finder returns false from OkayToDiscard. So if you are trying to discard plans up to the innermost master plan, you start from the younges