teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
LGTM, thanks! FWIW, there are actually a lot more 'qualifiers' supported in Clang that are ignored by the formatters (`restrict`, Obj-C garbage collector descriptions, custom address spaces, etc.). Most of them are not even modelled in DWARF and users rarely encounter them, so I think const/volatile should cover all reasonable workflows. ================ Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-advanced/TestDataFormatterAdv.py:247 + self.expect("frame variable constInt", matching=True, + substrs=['constInt = 0x0000002a']) ---------------- There are test methods for `frame var`: `self.expect_var_path("constVolatileInt", value="0x0000002c")` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99827/new/ https://reviews.llvm.org/D99827 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits