[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add MTE memory tag reading to lldb-server

2021-01-28 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls, krytarowski, mgorny. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This enables memory tag reading for lldb-server when on AArch64 Lin

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading for lldb

2021-01-28 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls, mgorny. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This commit adds a new command "memory tag read". It looks much like "memory rea

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add MTE memory tag reading to lldb-server

2021-01-28 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added reviewers: labath, omjavaid, emaste. DavidSpickett added a subscriber: emaste. DavidSpickett added a comment. This goes together with https://reviews.llvm.org/D95602, I've split them to make review more manageable. @emaste I saw you were doing something in BSD land around MTE

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading for lldb

2021-01-28 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added reviewers: omjavaid, palebedev, emaste. DavidSpickett added a comment. Couple of things I wanted to highlight for review. I've put the tag handler on the architecture plugin, but it could also go on process directly like trace does. I figured tagging extensions are a per arch

[Lldb-commits] [PATCH] D77043: Use remote regnums in expedited list, value regs and invalidate regs

2021-01-28 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added a comment. In D77043#2515233 , @labath wrote: > There's still one "opportunistic" snippet in `GDBRemoteRegisterContext.cpp`, > around line 404. Did you forget about that, or is there something special > about that case? (if so, then what?)

[Lldb-commits] [lldb] 0bca9a7 - Fix lldb-vscode builds on Windows targeting POSIX

2021-01-28 Thread Walter Erquinigo via lldb-commits
Author: Walter Erquinigo Date: 2021-01-28T09:36:13-08:00 New Revision: 0bca9a7ce2eeaa9f1d732ffbc17769560a2b236e URL: https://github.com/llvm/llvm-project/commit/0bca9a7ce2eeaa9f1d732ffbc17769560a2b236e DIFF: https://github.com/llvm/llvm-project/commit/0bca9a7ce2eeaa9f1d732ffbc17769560a2b236e.di

[Lldb-commits] [lldb] 0bca9a7 - Fix lldb-vscode builds on Windows targeting POSIX

2021-01-28 Thread Walter Erquinigo via lldb-commits
Author: Walter Erquinigo Date: 2021-01-28T09:36:13-08:00 New Revision: 0bca9a7ce2eeaa9f1d732ffbc17769560a2b236e URL: https://github.com/llvm/llvm-project/commit/0bca9a7ce2eeaa9f1d732ffbc17769560a2b236e DIFF: https://github.com/llvm/llvm-project/commit/0bca9a7ce2eeaa9f1d732ffbc17769560a2b236e.di

[Lldb-commits] [PATCH] D94857: [VFS] Combine VFSFromYamlDirIterImpl and OverlayFSDirIterImpl into a single implementation (NFC)

2021-01-28 Thread Nathan Hawes via Phabricator via lldb-commits
nathawes updated this revision to Diff 320031. nathawes added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Rename `error_code` to `EC` in `shouldFallBackToExternalFS()` to match existing conventions in the file. - Update a missed `RedirectingFileEntry` refer

[Lldb-commits] [lldb] b2545b7 - [lldb] Use `foo is None` instead of `not foo` in darwin.py

2021-01-28 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-01-28T20:03:44-08:00 New Revision: b2545b71d121ac913e56faff3b704f3957f941b7 URL: https://github.com/llvm/llvm-project/commit/b2545b71d121ac913e56faff3b704f3957f941b7 DIFF: https://github.com/llvm/llvm-project/commit/b2545b71d121ac913e56faff3b704f3957f941b7.d