DavidSpickett added reviewers: omjavaid, palebedev, emaste. DavidSpickett added a comment.
Couple of things I wanted to highlight for review. I've put the tag handler on the architecture plugin, but it could also go on process directly like trace does. I figured tagging extensions are a per arch thing so it made logical sense, but code wise it does add some complexity. The command's output is very simple and verbose, it could definitely do some things like not showing repeated tags: (lldb) memory tag read new_buf_ptr new_buf_ptr+<n> Logical tag: 0x9 Allocation tags: [0x900fffff7ffa000, 0x900fffff7ffa010): 0x9 <... 9 repeats...> [<>, <>): 0x0 Or combine runs into the same row, (lldb) memory tag read new_buf_ptr new_buf_ptr+<n> Logical tag: 0x9 Allocation tags: [0x900fffff7ffa000, 0x900fffff7ffa000+<n>): 0x9 So each row is not always 1 granule. That could be added later as a flag --compact or make that the default and have a flag to be verbose. The command as is does the job well enough for small reads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
