[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

werat updated this revision to Diff 315319. werat added a comment. Herald added a reviewer: shafik. Handle enum constants similar to global variables, support scoped lookup in the expression evaluator. Add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

werat added a comment. In D94077#2479984 , @shafik wrote: > We can have unscoped enums in namespace and class scope and the enumerators > won't leak out from those scopes. Thus we can have shadowing going on e.g.: > > ... > > How does this change deal wit

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

werat added a comment. In D94077#2481942 , @labath wrote: > This suffers from the same problem as the other patch, where the other index > classes (apple_names and debug_names) will essentially never be able to > implement this feature. (Unless they re-i

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

werat updated this revision to Diff 315343. werat added a comment. Generate fully qualified names for enum constants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94077/new/ https://reviews.llvm.org/D94077 Files: lldb/source/Plugins/ExpressionP

[Lldb-commits] [PATCH] D93421: Fix how ValueObject deals with getting unsigned values

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93421/new/ https://reviews.llvm.org/D93421 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D94244: [lldb] Bump the required SWIG version to 3

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM modulo the warning messages still referencing 2 instead of 3. Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:20 else() message(STATUS "SWIG 2 or later

[Lldb-commits] [lldb] b0dc54e - [lldb][NFC] Refactor setup code for Clang diagnostics

Author: Raphael Isemann Date: 2021-01-08T14:26:04+01:00 New Revision: b0dc54e08a9b5bee8ba1e874e9c12f4c4859f4a3 URL: https://github.com/llvm/llvm-project/commit/b0dc54e08a9b5bee8ba1e874e9c12f4c4859f4a3 DIFF: https://github.com/llvm/llvm-project/commit/b0dc54e08a9b5bee8ba1e874e9c12f4c4859f4a3.dif

[Lldb-commits] [lldb] cb6d53c - [lldb] Bump the required SWIG version to 3

Author: Jonas Devlieghere Date: 2021-01-08T08:47:21-08:00 New Revision: cb6d53ccdc7288f1bb62b0d50055545acfb59f77 URL: https://github.com/llvm/llvm-project/commit/cb6d53ccdc7288f1bb62b0d50055545acfb59f77 DIFF: https://github.com/llvm/llvm-project/commit/cb6d53ccdc7288f1bb62b0d50055545acfb59f77.d

[Lldb-commits] [PATCH] D94244: [lldb] Bump the required SWIG version to 3

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb6d53ccdc72: [lldb] Bump the required SWIG version to 3 (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D94244?vs=315175&id=315418#toc Repos

[Lldb-commits] [PATCH] D94320: [debugserver] Various plist changes

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. - Remove unused plists that were referenced (but unused) by Xcode. - Move all debugserver plists unders `tools/debugserver/resources`.

[Lldb-commits] [lldb] 311b247 - [lldb] Remove stale LLDB-Info.plist

Author: Jonas Devlieghere Date: 2021-01-08T10:12:16-08:00 New Revision: 311b247c9fb58ee476184a7eb8044b8f54f95035 URL: https://github.com/llvm/llvm-project/commit/311b247c9fb58ee476184a7eb8044b8f54f95035 DIFF: https://github.com/llvm/llvm-project/commit/311b247c9fb58ee476184a7eb8044b8f54f95035.d

[Lldb-commits] [PATCH] D70277: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

vsk added a comment. The issue is that InitLLVM initializes its private PrettyStackPrinter before installing the one-shot default SIGPIPE handler: the PrettyStackPrinter itself eventually calls RegisterHandlers(), which runs before the SIGPIPE handler is installed and therefore doesn't register

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

jingham added a comment. In D94077#2486225 , @werat wrote: > In D94077#2479984 , @shafik wrote: > >> We can have unscoped enums in namespace and class scope and the enumerators >> won't leak out from those scopes.

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

labath added a comment. In D94077#2486232 , @werat wrote: > In D94077#2481942 , @labath wrote: > >> This suffers from the same problem as the other patch, where the other index >> classes (apple_names and debug_nam

[Lldb-commits] [PATCH] D94320: [debugserver] Various plist changes

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thanks Jonas, LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94320/new/ https://reviews.llvm.org/D94320 ___

[Lldb-commits] [lldb] aa1943a - Don't take the address of a temporary

Author: Adrian Prantl Date: 2021-01-08T13:24:07-08:00 New Revision: aa1943a2d167823e6d506895292477f79874dd20 URL: https://github.com/llvm/llvm-project/commit/aa1943a2d167823e6d506895292477f79874dd20 DIFF: https://github.com/llvm/llvm-project/commit/aa1943a2d167823e6d506895292477f79874dd20.diff

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace updated this revision to Diff 315527. wallace added a comment. Followed all the suggestions: - This is POSIX-only, but making it work for windows should only require deleting a few #ifdef blocks and using the CreateNamedPipe API instead of mkfifo. I'll do it later in another diff. - Add

[Lldb-commits] [PATCH] D78978: [LLDB] Add support for WebAssembly debugging

aprantl added a comment. What's the testing story for WASM going to be? Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h:300 + // WebAssembly-specific commands + bool GetWasmGlobal(int frame_index, int index, void *buf, size_t buffer_size,

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

jingham added a comment. looks good to me too. When you get around to the wait times & intervals I'd argue for not doing that as a GDBRemote specific addition, as Greg was suggesting above. There's nothing gdb-remote specific about how long you want the debug agent to wait around for some pro

[Lldb-commits] [lldb] 2723551 - [debugserver] Various plist changes

Author: Jonas Devlieghere Date: 2021-01-08T18:53:08-08:00 New Revision: 272355128f48089a959215472b645628a48659f2 URL: https://github.com/llvm/llvm-project/commit/272355128f48089a959215472b645628a48659f2 DIFF: https://github.com/llvm/llvm-project/commit/272355128f48089a959215472b645628a48659f2.d

[Lldb-commits] [PATCH] D94320: [debugserver] Various plist changes

This revision was automatically updated to reflect the committed changes. Closed by commit rG272355128f48: [debugserver] Various plist changes (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D94320?vs=315435&id=315565#toc Repository:

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

clayborg added a comment. In D93895#2488249 , @jingham wrote: > looks good to me too. When you get around to the wait times & intervals I'd > argue for not doing that as a GDBRemote specific addition, as Greg was > suggesting above. There's nothing gdb

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

clayborg added a comment. Can we still try to use just one file? Isn't this file both read and write? The flow would be: - create 1 file using mkfifo(...) and pass it down as argument - launcher lldb-vscode will write pid or error JSON back into the stream, and will start to wait for some data

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

jingham added a comment. In D93895#2488372 , @clayborg wrote: > In D93895#2488249 , @jingham wrote: > >> looks good to me too. When you get around to the wait times & intervals I'd >> argue for not doing that as a