teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
LGTM modulo the warning messages still referencing 2 instead of 3. ================ Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:20 else() message(STATUS "SWIG 2 or later is required for Lua support in LLDB but could not be found") endif() ---------------- SWIG 3 ================ Comment at: lldb/cmake/modules/FindPythonAndSwig.cmake:45 else() message(STATUS "SWIG 2 or later is required for Python support in LLDB but could not be found") endif() ---------------- "SWIG 3 or later ..." as pointed out in the bug report. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94244/new/ https://reviews.llvm.org/D94244 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits