labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
Comment at:
lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:41
+
+namespace {
+// x86 64-bit general purpose registers.
I don'
Author: Pavel Labath
Date: 2020-12-20T10:37:48+01:00
New Revision: 37974b493a48cf97ac3d486512d6cd70c176924a
URL:
https://github.com/llvm/llvm-project/commit/37974b493a48cf97ac3d486512d6cd70c176924a
DIFF:
https://github.com/llvm/llvm-project/commit/37974b493a48cf97ac3d486512d6cd70c176924a.diff
Author: Michał Górny
Date: 2020-12-20T11:32:43+01:00
New Revision: 99562332e3de19da9da1714a58b5cc2d24724ef5
URL:
https://github.com/llvm/llvm-project/commit/99562332e3de19da9da1714a58b5cc2d24724ef5
DIFF:
https://github.com/llvm/llvm-project/commit/99562332e3de19da9da1714a58b5cc2d24724ef5.diff
labath added a comment.
I've included two logs, showing failing and successful runs (the successful run
was captured without this patch). Interesting things happen around line 1057,
where the "step out" plan decides we should not stop after stepping out. I'm
not sure what's the relation to this
mgorny added inline comments.
Comment at:
lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:41
+
+namespace {
+// x86 64-bit general purpose registers.
labath wrote:
> I don't know if this namespace snuck into the FreeBSD file, but genera
DaanDeMeyer created this revision.
DaanDeMeyer added a reviewer: LLDB.
DaanDeMeyer added a project: LLDB.
Herald added subscribers: JDevlieghere, mgorny.
DaanDeMeyer requested review of this revision.
Herald added a subscriber: lldb-commits.
This makes it easier to install the extension since th
