labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
================
Comment at:
lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:41
+
+namespace {
+// x86 64-bit general purpose registers.
----------------
I don't know if this namespace snuck into the FreeBSD file, but generally, this
is not the proper use of anonymous namespaces in llvm. See [[
http://llvm.org/docs/CodingStandards.html#anonymous-namespaces | the coding
standards ]] for more details.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93541/new/
https://reviews.llvm.org/D93541
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
