[Lldb-commits] [lldb] b6e04ac - [lldb/test] Avoid the socket "pump" thread

Author: Pavel Labath Date: 2020-11-30T09:07:45+01:00 New Revision: b6e04ac5aa881c1fbb66da884b04e48dfb102474 URL: https://github.com/llvm/llvm-project/commit/b6e04ac5aa881c1fbb66da884b04e48dfb102474 DIFF: https://github.com/llvm/llvm-project/commit/b6e04ac5aa881c1fbb66da884b04e48dfb102474.diff

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

labath added a comment. What's the state of TestBreakpointInGlobalConstructor.py after this change? Does it continue to fail? If so, then this is probably a bug in FreeBSD that is worth reporting, as it means that it is not possible to debug the initialization code (global constructors, `__at

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

mgorny added a comment. In D92187#2422085 , @labath wrote: > What's the state of TestBreakpointInGlobalConstructor.py after this change? > Does it continue to fail? Yes, it does. > If so, then this is probably a bug in FreeBSD that is worth reporting,

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

labath added a comment. Looks great. One question about the member variable... Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.h:90 dynamic_reg_size_map m_dynamic_reg_size_map; + reg_to_reg_map m_remote_to_local_regnum_map; size_t m_reg_data_byte_size

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

labath added inline comments. Comment at: lldb/bindings/lua/lua-wrapper.swig:21-22 +{ + lldb::SBFrame sb_frame(stop_frame_sp); + lldb::SBBreakpointLocation sb_bp_loc(bp_loc_sp); + tammela wrote: > labath wrote: > > What's up with the copying? Is it to ensure

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

labath added a comment. I am not sure if this is the right way to implement this feature. Changing ManualDWARFIndex to provide this additional information is easy enough, but it means that the other index classes will never be able to support this functionality (without, essentially, reimplemen

[Lldb-commits] [PATCH] D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach

labath added a comment. Seems reasonable(ish), but needs a test case. Do you need to launch a separate server instance, or would just a plain attach work? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92264/new/ https://reviews.llvm.org/D92264 _

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

labath added a comment. In D92249#2421639 , @JDevlieghere wrote: > It appears there are many similar calls in this file, can you update those as > well? If there are many of these calls, adding a static helper function for this purpose might be a good

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D92063#2417989 , @mgorny wrote: > I was referring to: > >> Ideally offset calculation should look something like this: >> reg[index].byte_offset = r

[Lldb-commits] [PATCH] D91634: [lldb] Error when there are no ports to launch a gdbserver on

DavidSpickett updated this revision to Diff 308289. DavidSpickett added a comment. - Document default constructor behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91634/new/ https://reviews.llvm.org/D91634 Files: lldb/source/Plugins/Proc

[Lldb-commits] [PATCH] D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach

mgorny added a comment. In D92264#2422199 , @labath wrote: > Seems reasonable(ish), but needs a test case. Do you need to launch a > separate server instance, or would just a plain attach work? It failed only when connecting to remote lldb-server. CHAN

[Lldb-commits] [PATCH] D91634: [lldb] Error when there are no ports to launch a gdbserver on

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98e87f76d0f4: [lldb] Error when there are no ports to launch a gdbserver on (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [lldb] 98e87f7 - [lldb] Error when there are no ports to launch a gdbserver on

Author: David Spickett Date: 2020-11-30T10:19:14Z New Revision: 98e87f76d0f486122d76b334232102e0d7a9254d URL: https://github.com/llvm/llvm-project/commit/98e87f76d0f486122d76b334232102e0d7a9254d DIFF: https://github.com/llvm/llvm-project/commit/98e87f76d0f486122d76b334232102e0d7a9254d.diff LOG

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

mgorny added a comment. GDB indeed handles it somehow. I'm going to investigate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92187/new/ https://reviews.llvm.org/D92187 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid added a comment. In D91241#2422100 , @labath wrote: > Looks great. One question about the member variable... m_remote_to_local_regnum_map is used by AddRegister where we add a (key,value) pair for each of registers. We are doing this to maintain

[Lldb-commits] [lldb] a7f8d96 - [lldb] Use llvm::Optional for port in LaunchGDBServer

Author: David Spickett Date: 2020-11-30T11:20:39Z New Revision: a7f8d96b16a394a87230d592c727906f67a4ba07 URL: https://github.com/llvm/llvm-project/commit/a7f8d96b16a394a87230d592c727906f67a4ba07 DIFF: https://github.com/llvm/llvm-project/commit/a7f8d96b16a394a87230d592c727906f67a4ba07.diff LOG

[Lldb-commits] [PATCH] D92035: [lldb] Use llvm::Optional for port in LaunchGDBServer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7f8d96b16a3: [lldb] Use llvm::Optional for port in LaunchGDBServer (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat added a comment. Pavel, thanks for review! In D92223#2422184 , @labath wrote: > I am not sure if this is the right way to implement this feature. Changing > ManualDWARFIndex to provide this additional information is easy enough, but > it means tha

[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

tammela added a comment. In D92249#2422205 , @labath wrote: > In D92249#2421639 , @JDevlieghere > wrote: > >> It appears there are many similar calls in this file, can you update those >> as well? > > If there are

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

labath added a comment. In D91241#2422403 , @omjavaid wrote: > In D91241#2422100 , @labath wrote: > >> Looks great. One question about the member variable... > > m_remote_to_local_regnum_map is used by AddRegister w

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

tammela updated this revision to Diff 308319. tammela added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91508/new/ https://reviews.llvm.org/D91508 Files: lldb/bindings/lua/lua-swigsafecast.swig lldb/bindings/lu

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is ok now. Thanks for your patience. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91508/new/ https://reviews.llvm.org/D91508

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

jankratochvil added a comment. In D92223#2422184 , @labath wrote: > I am not sure if this is the right way to implement this feature. Changing > ManualDWARFIndex to provide this additional information is easy enough, but > it means that the other index c

[Lldb-commits] [lldb] b69c09b - Support custom expedited register set in gdb-remote

Author: Muhammad Omair Javaid Date: 2020-11-30T17:34:19+05:00 New Revision: b69c09bf43527e79a770efd9886b79e611f8fd59 URL: https://github.com/llvm/llvm-project/commit/b69c09bf43527e79a770efd9886b79e611f8fd59 DIFF: https://github.com/llvm/llvm-project/commit/b69c09bf43527e79a770efd9886b79e611f8fd

[Lldb-commits] [lldb] 4e8aeb9 - Send SVE vg register in custom expedited registerset

Author: Muhammad Omair Javaid Date: 2020-11-30T17:34:19+05:00 New Revision: 4e8aeb97ca41eb202c9c90a9c640a630903c769b URL: https://github.com/llvm/llvm-project/commit/4e8aeb97ca41eb202c9c90a9c640a630903c769b DIFF: https://github.com/llvm/llvm-project/commit/4e8aeb97ca41eb202c9c90a9c640a630903c76

[Lldb-commits] [PATCH] D82853: [LLDB] Support custom expedited register set in gdb-remote

This revision was automatically updated to reflect the committed changes. Closed by commit rGb69c09bf4352: Support custom expedited register set in gdb-remote (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D82855: [LLDB] Send SVE vg register in custom expedited registerset

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e8aeb97ca41: Send SVE vg register in custom expedited registerset (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid added a comment. In D91241#2422517 , @labath wrote: > In D91241#2422403 , @omjavaid wrote: > >> In D91241#2422100 , @labath wrote: >> >>> Looks great. One question a

[Lldb-commits] [PATCH] D92164: Make SBDebugger internal variable getter and setter not use CommandInterpreter's context

tatyana-krasnukha updated this revision to Diff 308325. tatyana-krasnukha added a comment. Removed refactoring to make the changes clearer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92164/new/ https://reviews.llvm.org/D92164 Files: lldb/packages/Python/lldbsuite/test/python_api/d

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

omjavaid updated this revision to Diff 308338. omjavaid added a comment. Updated incorporating suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92063/new/ https://reviews.llvm.org/D92063 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp l

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid updated this revision to Diff 308339. omjavaid added a comment. Updated after incorporating suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91241/new/ https://reviews.llvm.org/D91241 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h lldb/package

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 308340. omjavaid added a comment. Updated after re-base over D91241 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/DynamicReg

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 308341. omjavaid added a comment. Updated after re-base over D91241 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 Files: lldb/source/Plugins/Process/Linux/NativeRegiste

[Lldb-commits] [PATCH] D92314: [lldb] [Process/FreeBSDRemote] Implement GetLoadedModuleFileSpec() and GetFileLoadAddress()

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Copy the Linux implementation of GetLoadedModuleFileSpec() and GetFileLoadAddress() into NativeProcessFreeBSD. This does not seem to

[Lldb-commits] [PATCH] D82866: [LLDB] Test SVE dynamic resize with multiple threads

omjavaid updated this revision to Diff 308343. omjavaid added a comment. Updated after rebase over D91241 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82866/new/ https://reviews.llvm.org/D82866 Files: lldb/test/API/commands/register/register/aarch6

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D91241#2422571 , @omjavaid wrote: > In D91241#2422517 , @labath wrote: > >> Yes, but there's no reason that

[Lldb-commits] [lldb] a0d7406 - [LLDB/Lua] add support for one-liner breakpoint callback

Author: Pedro Tammela Date: 2020-11-30T14:12:26Z New Revision: a0d7406ae800c45dd9cb438c7ae1f55329d198e2 URL: https://github.com/llvm/llvm-project/commit/a0d7406ae800c45dd9cb438c7ae1f55329d198e2 DIFF: https://github.com/llvm/llvm-project/commit/a0d7406ae800c45dd9cb438c7ae1f55329d198e2.diff LOG:

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0d7406ae800: [LLDB/Lua] add support for one-liner breakpoint callback (authored by tammela). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

jankratochvil added a comment. FYI it would not work with GNU C++ 4.4 (2008, RHEL-5) as it used `DW_TAG_variable` instead of `DW_TAG_member`. But that is probably not a problem, Red Hat's last supported RHEL for new toolchains is since RHEL-6 and for LLVM even just since RHEL-7: <0>: Abbrev

[Lldb-commits] [PATCH] D92314: [lldb] [Process/FreeBSDRemote] Implement GetLoadedModuleFileSpec() and GetFileLoadAddress()

emaste added a comment. No objection, but maybe add a comment explaining the status of this implementation? Does/will NetBSD do the same? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92314/new/ https://reviews.llvm.org/D92314 ___ lldb-commi

[Lldb-commits] [lldb] e0e7bbe - [lldb] Always include template arguments that have their default value in the internal type name

Author: Raphael Isemann Date: 2020-11-30T16:40:50+01:00 New Revision: e0e7bbeb545516c50a0354efc34d329453558c9c URL: https://github.com/llvm/llvm-project/commit/e0e7bbeb545516c50a0354efc34d329453558c9c DIFF: https://github.com/llvm/llvm-project/commit/e0e7bbeb545516c50a0354efc34d329453558c9c.dif

[Lldb-commits] [PATCH] D92311: [lldb] Always include template arguments that have their default value in the internal type name

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0e7bbeb5455: [lldb] Always include template arguments that have their default value in the… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: r

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

emaste added a subscriber: bsdjhb. emaste added a comment. I'm curious how gdb handles this, and asked @bsdjhb if he knows off hand. Is there a brief description of how this works on Linux and/or NetBSD? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92187/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

krytarowski added a comment. In D92187#2423018 , @emaste wrote: > I'm curious how gdb handles this, and asked @bsdjhb if he knows off hand. > > Is there a brief description of how this works on Linux and/or NetBSD? We are working on researching this, NetB

[Lldb-commits] [PATCH] D92164: Make SBDebugger internal variable getter and setter not use CommandInterpreter's context

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/python_api/debugger/main.cpp:1 +//===-- main.cpp *- C++ -*-===// +// Test source files shouldn't have the header. ==

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

emaste added a comment. Link to Linux info: https://sourceware.org/gdb/wiki/LinkerInterface CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92187/new/ https://reviews.llvm.org/D92187 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3181 + if (tag == DW_TAG_member && !const_value_form.IsValid()) { +// Allows only members with DW_AT_const_value attribute, i.e. static const This is a nitpi

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

emaste added a comment. > One thing that FreeBSD should do, is to upgrade to the protocol version 1 > (stored in r_version), like Linux, NetBSD and OpenBSD. It looks like Linux has always used r_version=1 (since 1995). AFAICT we can just add r_ldbase and set version to 1. CHANGES SINCE LAST A

[Lldb-commits] [lldb] 1b9f214 - [lldb] Give TestDefaultTemplateArgs a unique class name

Author: Jonas Devlieghere Date: 2020-11-30T14:41:35-08:00 New Revision: 1b9f214efca7d5855f4e3dd1969c4cbe77078f97 URL: https://github.com/llvm/llvm-project/commit/1b9f214efca7d5855f4e3dd1969c4cbe77078f97 DIFF: https://github.com/llvm/llvm-project/commit/1b9f214efca7d5855f4e3dd1969c4cbe77078f97.d

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

emaste added a comment. > One thing that FreeBSD should do, is to upgrade to the protocol version 1 > (stored in r_version), like Linux, NetBSD and OpenBSD. It looks like Linux has always used r_version=1 (since 1995). AFAICT we can just add r_ldbase and set version to 1. See https://reviews.fr

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

shafik added inline comments. Comment at: lldb/test/API/commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py:25 -deque_type = "std::deque >" size_type = deque_type + "::size_type" Why do the default arguments not show up

[Lldb-commits] [PATCH] D92164: Make SBDebugger internal variable getter and setter not use CommandInterpreter's context

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I don't see any reason for, and lots of reasons against having more than one source of truth for a Debugger's "Currently Selected ExecutionContext". In particular, I can't see any

[Lldb-commits] [lldb] 173bb3c - [lldb] Refactor GetDeviceSupportDirectoryNames and GetPlatformName (NFC)

Author: Jonas Devlieghere Date: 2020-11-30T19:37:12-08:00 New Revision: 173bb3c2eb094920708ab8f61dae2fe22d331773 URL: https://github.com/llvm/llvm-project/commit/173bb3c2eb094920708ab8f61dae2fe22d331773 DIFF: https://github.com/llvm/llvm-project/commit/173bb3c2eb094920708ab8f61dae2fe22d331773.d