[Lldb-commits] [PATCH] D92164: Make SBDebugger internal variable getter and setter not use CommandInterpreter's context

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/python_api/debugger/main.cpp:1
+//===-- main.cpp ------------------------------------------------*- C++ 
-*-===//
+//
----------------
Test source files shouldn't have the header.


================
Comment at: lldb/source/API/SBDebugger.cpp:1315
+    Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API));
+    error.SetErrorStringWithFormatv("invalid debugger instance name {0}",
+                                    debugger_instance_name);
----------------
Does this append or override the error message? If it overrides you might as 
well us `LLDB_LOG` directly which supports formatv. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92164/new/

https://reviews.llvm.org/D92164

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits