[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

omjavaid updated this revision to Diff 293136. omjavaid added a comment. Herald added a subscriber: arphaman. This adds a rst page qemu-testing.rst that describes content which was previously written in README.txt. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82064/new/ https://review

[Lldb-commits] [lldb] 3b3b9ba - [lldb/Commands] Fix outdated `breakpoint command add` help string

Author: Dave Lee Date: 2020-09-21T10:15:34-07:00 New Revision: 3b3b9ba1c7d89afe4909a42e2a795354bb79e062 URL: https://github.com/llvm/llvm-project/commit/3b3b9ba1c7d89afe4909a42e2a795354bb79e062 DIFF: https://github.com/llvm/llvm-project/commit/3b3b9ba1c7d89afe4909a42e2a795354bb79e062.diff LOG:

[Lldb-commits] [PATCH] D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b3b9ba1c7d8: [lldb/Commands] Fix outdated `breakpoint command add

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

jingham added a comment. Calling every symbol called mmap you find around till one returns some value makes me a bit nervous. For instance, on macOS dyld has a symbol called "mmap" that isn't meant to be called by anybody but dyld. We probably don't want to accidentally call that. You can ge

[Lldb-commits] [lldb] 6807f24 - [ASTImporter] Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

Author: shafik Date: 2020-09-21T14:57:00-07:00 New Revision: 6807f244fa67bb75ef09fb3db54743b5b358a7fa URL: https://github.com/llvm/llvm-project/commit/6807f244fa67bb75ef09fb3db54743b5b358a7fa DIFF: https://github.com/llvm/llvm-project/commit/6807f244fa67bb75ef09fb3db54743b5b358a7fa.diff LOG: [

[Lldb-commits] [PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG6807f244fa67: [ASTImporter] Modifying ImportDeclContext(...) to ensure that we also handle… (authored by shafik). Herald added projects: clang, LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

vsk added a comment. It seems like calling any 'mmap' definition should work. Is the interposed mmap implementation failing and correctly returning -1, or is it succeeding and incorrectly returning -1? In either case, it seems like it's worth digging into why it's failing / returning the wrong

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

kastiglione added a comment. Should lldb avoid calling asan (or any other sanitizer's) `mmap`? If so, maybe this function can be sanitizer aware and ignore those symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87868/new/ https://reviews.llv

[Lldb-commits] [PATCH] D88051: [lldb/test] Clean up version checking.

rupprecht created this revision. rupprecht added reviewers: JDevlieghere, arsenm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: wdng. A few fixes while trying to figure out why tests are being skipped

[Lldb-commits] [PATCH] D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX

JDevlieghere added a comment. The change to use the configuration looks good, but I think Pavel raised a good point. Which tests are affected by this? How much work would it be to convert them as suggested? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86416/n

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

jingham added a comment. In D87868#2286313 , @kastiglione wrote: > Should lldb avoid calling asan (or any other sanitizer's) `mmap`? If so, > maybe this function can be sanitizer aware and ignore those symbols. At present, this is a function that gets us

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

clayborg added a comment. So sounds like first we should verify if the "mmap" for asan is exported or not. If it isn't then this is an easy fix, iterate through all possible matches and avoid any internal versions of mmap and only call externally visible symbols. Antonio, can you verify the vis

[Lldb-commits] [lldb] 307b7a1 - [lldb/test] Clean up version checking.

Author: Jordan Rupprecht Date: 2020-09-21T16:19:28-07:00 New Revision: 307b7a1d665898d0e980461919996b6a670a4847 URL: https://github.com/llvm/llvm-project/commit/307b7a1d665898d0e980461919996b6a670a4847 DIFF: https://github.com/llvm/llvm-project/commit/307b7a1d665898d0e980461919996b6a670a4847.di

[Lldb-commits] [PATCH] D88051: [lldb/test] Clean up version checking.

This revision was automatically updated to reflect the committed changes. Closed by commit rG307b7a1d6658: [lldb/test] Clean up version checking. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88051/new/ https://reviews.llvm.

[Lldb-commits] [lldb] 74c9395 - Add a "Trace" plug-in to LLDB to add process trace support in stages.

Author: Walter Erquinigo Date: 2020-09-21T17:13:18-07:00 New Revision: 74c93956e1c1f1054dfb040ce26830016e0f3095 URL: https://github.com/llvm/llvm-project/commit/74c93956e1c1f1054dfb040ce26830016e0f3095 DIFF: https://github.com/llvm/llvm-project/commit/74c93956e1c1f1054dfb040ce26830016e0f3095.di

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74c93956e1c1: Add a "Trace" plug-in to LLDB to add process trace s

[Lldb-commits] [lldb] 94b0d83 - Fix reporting the lack of global variables in "target var".

Author: Jim Ingham Date: 2020-09-21T17:29:40-07:00 New Revision: 94b0d836a105116220052313df5a58473f706cdf URL: https://github.com/llvm/llvm-project/commit/94b0d836a105116220052313df5a58473f706cdf DIFF: https://github.com/llvm/llvm-project/commit/94b0d836a105116220052313df5a58473f706cdf.diff LO

[Lldb-commits] [lldb] 0b9f9ec - Include sstream after D85705

Author: Fangrui Song Date: 2020-09-21T17:41:59-07:00 New Revision: 0b9f9eced9c532ee9bbf320216a2e85b314eb5f0 URL: https://github.com/llvm/llvm-project/commit/0b9f9eced9c532ee9bbf320216a2e85b314eb5f0 DIFF: https://github.com/llvm/llvm-project/commit/0b9f9eced9c532ee9bbf320216a2e85b314eb5f0.diff

[Lldb-commits] [lldb] 95bfeb5 - [lldb] Delete two unneeded

Author: Fangrui Song Date: 2020-09-21T18:11:26-07:00 New Revision: 95bfeb5903c7b75a0a9ddf5c4b53e4308bb05486 URL: https://github.com/llvm/llvm-project/commit/95bfeb5903c7b75a0a9ddf5c4b53e4308bb05486 DIFF: https://github.com/llvm/llvm-project/commit/95bfeb5903c7b75a0a9ddf5c4b53e4308bb05486.diff

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

MaskRay added inline comments. Comment at: lldb/source/Target/TraceSettingsParser.cpp:123 + if (schema.empty()) { +std::ostringstream schema_builder; +schema_builder << "{\n \"trace\": "; This requires `sstream`. Fixed. Comment at: lld

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/source/Target/TraceSettingsParser.cpp:128 +std::string plugin_schema(GetPluginSchema()); +plugin_schema = std::regex_replace(plugin_schema, std::regex("\n"), "\n "); +schema_bu

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

aadsm added a comment. > It seems like calling any 'mmap' definition should work. Is the interposed > mmap implementation failing and correctly returning -1, or is it succeeding > and incorrectly returning -1? In either case, it seems like it's worth > digging into why it's failing / returnin