[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

labath added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py:55 + +self.process = subprocess.Popen([program, "--attach"], +universal_newlines=True, Writing an attach

[Lldb-commits] [lldb] 846909e - [lldb] Fix UBSan regression in GetSLEB128

Author: Jan Kratochvil Date: 2020-06-05T12:00:44+02:00 New Revision: 846909e2ab0bd279ae2a8ec86074521f59c49eb3 URL: https://github.com/llvm/llvm-project/commit/846909e2ab0bd279ae2a8ec86074521f59c49eb3 DIFF: https://github.com/llvm/llvm-project/commit/846909e2ab0bd279ae2a8ec86074521f59c49eb3.diff

[Lldb-commits] [lldb] 2af2140 - [lldb] Handle new BFloat16 type

Author: Kadir Cetinkaya Date: 2020-06-05T12:25:26+02:00 New Revision: 2af2140983a8de838a93b375121515a6b48524d4 URL: https://github.com/llvm/llvm-project/commit/2af2140983a8de838a93b375121515a6b48524d4 DIFF: https://github.com/llvm/llvm-project/commit/2af2140983a8de838a93b375121515a6b48524d4.dif

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

jankratochvil added a comment. In D81119#2074954 , @jasonmolenda wrote: > lldb-unit :: Utility/./UtilityTests/DataExtractorTest.GetSLEB128_bit63 > lldb-shell :: SymbolFile/DWARF/DW_TAG_variable-DW_AT_const_value.s That should be fixed by rG846909e2a

[Lldb-commits] [PATCH] D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB

friss added a comment. This LGTM, with the caveat that it doesn't handle command line tools. But we didn't handle it correctly before, so not something we need to fix here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81210/new/ https://reviews.llvm.org/D81210 _

[Lldb-commits] [PATCH] D81209: Move GetXcode*Directory into HostInfo (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81209/new/ https://reviews.llvm.org/D81209 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB

JDevlieghere added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:372 +if (!developer_dir.empty()) + xcrun_cmd = "/usr/bin/env DEVELOPER_DIR=" + developer_dir + " "; +xcrun_cmd += "xcrun --show-sdk-path --sdk " + sdk_name; -

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

JDevlieghere updated this revision to Diff 268851. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81058/new/ https://reviews.llvm.org/D81058 Files: lldb/include/lldb/Interpreter/CommandReturnObject.h lldb/include/lldb/Utility/Stream.h lldb/source/Interpreter/CommandInterpreter.cpp

[Lldb-commits] [PATCH] D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:364 +Environment env = Host::GetEnvironment(); +std::string developer_dir = env

[Lldb-commits] [PATCH] D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB

aprantl updated this revision to Diff 268870. aprantl added a comment. Address feedback from Jonas! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81210/new/ https://reviews.llvm.org/D81210 Files: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm Index: lldb/source/Host/macosx/objcxx

[Lldb-commits] [PATCH] D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB

JDevlieghere added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:365 +if (developer_dir.empty()) + if (FileSpec fspec = HostInfo::GetShlibDir()) +if (FileSystem::Instance().Exists(fspec)) { Any reason you choose to

[Lldb-commits] [PATCH] D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB

aprantl marked 2 inline comments as done. aprantl added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:364 +Environment env = Host::GetEnvironment(); +std::string developer_dir = env.lookup("DEVELOPER_DIR"); +if (developer_dir.empty()) {

[Lldb-commits] [PATCH] D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:365 +if (developer_dir.empty()) + if (FileSpec fspec = HostInfo::GetShlibDir()) +

[Lldb-commits] [PATCH] D81289: Factor out GetEnvDeveloperDir() (NFC)

aprantl created this revision. aprantl added a reviewer: JDevlieghere. https://reviews.llvm.org/D81289 Files: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm Index: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm === --- lldb/s

[Lldb-commits] [PATCH] D81290: Fix an oversight in GetXcodeContentsDirectory()

aprantl created this revision. aprantl added a reviewer: JDevlieghere. Since FindXcodeContentsDirectoryInPath expects the *.app/Contents and DEVELOPER_DIR is supposed to point to Xcode.app, we need to append the Contents path first. https://reviews.llvm.org/D81290 Files: lldb/source/Host/ma

[Lldb-commits] [lldb] 79daa3d - Teach GetXcodeSDK to look in the Xcode that contains LLDB

Author: Adrian Prantl Date: 2020-06-05T11:59:22-07:00 New Revision: 79daa3d896495e2755e530ce0658be3e80dfe4c9 URL: https://github.com/llvm/llvm-project/commit/79daa3d896495e2755e530ce0658be3e80dfe4c9 DIFF: https://github.com/llvm/llvm-project/commit/79daa3d896495e2755e530ce0658be3e80dfe4c9.diff

[Lldb-commits] [lldb] 3d7b926 - Move GetXcode*Directory into HostInfo (NFC)

Author: Adrian Prantl Date: 2020-06-05T11:59:22-07:00 New Revision: 3d7b926dd16ff9ff264337793b76080681636f15 URL: https://github.com/llvm/llvm-project/commit/3d7b926dd16ff9ff264337793b76080681636f15 DIFF: https://github.com/llvm/llvm-project/commit/3d7b926dd16ff9ff264337793b76080681636f15.diff

[Lldb-commits] [PATCH] D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rG79daa3d89649: Teach GetXcodeSDK to look in the Xcode that contains LLDB (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D81300: Enable -DLLDB_ENERGY when compiling against an internal SDK

aprantl created this revision. aprantl added reviewers: jasonmolenda, friss, JDevlieghere. Herald added a subscriber: mgorny. This brings over functionality from the xcodeproject that went missing during the CMake transition. rdar://problem/63840635 https://reviews.llvm.org/D81300 Files: ll

[Lldb-commits] [lldb] f28177d - Factor out GetEnvDeveloperDir() (NFC)

Author: Adrian Prantl Date: 2020-06-05T13:50:37-07:00 New Revision: f28177dbe8d2e2955f7ca0a0ffdb1a44fefe092d URL: https://github.com/llvm/llvm-project/commit/f28177dbe8d2e2955f7ca0a0ffdb1a44fefe092d DIFF: https://github.com/llvm/llvm-project/commit/f28177dbe8d2e2955f7ca0a0ffdb1a44fefe092d.diff

[Lldb-commits] [lldb] ad4e7b9 - Fix an oversight in GetXcodeContentsDirectory()

Author: Adrian Prantl Date: 2020-06-05T13:50:37-07:00 New Revision: ad4e7b9dc82b13d124071f0add09cb541b495a0e URL: https://github.com/llvm/llvm-project/commit/ad4e7b9dc82b13d124071f0add09cb541b495a0e DIFF: https://github.com/llvm/llvm-project/commit/ad4e7b9dc82b13d124071f0add09cb541b495a0e.diff

[Lldb-commits] [PATCH] D81209: Move GetXcode*Directory into HostInfo (NFC)

aprantl closed this revision. aprantl added a comment. 3d7b926dd16ff9ff264337793b76080681636f15 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81209/new/ https://reviews.llvm.org/D81209

[Lldb-commits] [PATCH] D81290: Fix an oversight in GetXcodeContentsDirectory()

This revision was automatically updated to reflect the committed changes. Closed by commit rGad4e7b9dc82b: Fix an oversight in GetXcodeContentsDirectory() (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D81289: Factor out GetEnvDeveloperDir() (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGf28177dbe8d2: Factor out GetEnvDeveloperDir() (NFC) (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81289/

[Lldb-commits] [lldb] c3f0d9f - [IRExecutionUnit] Early returns for clarity. NFCI.

Author: Davide Italiano Date: 2020-06-05T14:52:36-07:00 New Revision: c3f0d9f3d22d7a3770f2886df9c554e1c277e45a URL: https://github.com/llvm/llvm-project/commit/c3f0d9f3d22d7a3770f2886df9c554e1c277e45a DIFF: https://github.com/llvm/llvm-project/commit/c3f0d9f3d22d7a3770f2886df9c554e1c277e45a.dif

Re: [Lldb-commits] [clang] c13dd74 - Set the captures on a CXXRecordDecl representing a lambda closure type

On Thu, 4 Jun 2020 at 23:45, Jonas Devlieghere via cfe-commits < cfe-comm...@lists.llvm.org> wrote: > Hey Richard, > > It appears this broke the lldb bots: > > http://lab.llvm.org:8011/builders/lldb-x86_64-debian > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/20549/ > That's not cause

[Lldb-commits] [lldb] 825e3bb - PR46209: properly determine whether a copy assignment operator is

Author: Richard Smith Date: 2020-06-05T16:05:32-07:00 New Revision: 825e3bb58082eafa8db87a9034379b88f892ce9d URL: https://github.com/llvm/llvm-project/commit/825e3bb58082eafa8db87a9034379b88f892ce9d DIFF: https://github.com/llvm/llvm-project/commit/825e3bb58082eafa8db87a9034379b88f892ce9d.diff