labath added inline comments.
================ Comment at: lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py:55 + + self.process = subprocess.Popen([program, "--attach"], + universal_newlines=True, ---------------- Writing an attach test is tricky because of the yama restrictions on linux. The way that we handle that right now is to have the inferior call `lldb_enable_attach()` and then create a token file. The test then waits for the token file `lldbutil.wait_for_file_on_target` and only then attaches. This ensures the attack takes place only when yama is disabled. ================ Comment at: lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py:68 + + self.disconnect_and_check_no_output() ---------------- I'm confused as to why we're not expecting any output here. I was under the impression that we want to let the inferior continue in the "attach" case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81200/new/ https://reviews.llvm.org/D81200 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
