[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. Anybody there? Do you see me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D79586: Do not list adb devices when a device id is given

emrekultursay added a comment. I don't have commit access. Can someone submit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79586/new/ https://reviews.llvm.org/D79586 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

jingham added a comment. In D80165#2048458 , @labath wrote: > In D80165#2047241 , @jingham wrote: > > > In D80165#2045882 , @labath wrote: > > > > > In D80165#2044509

[Lldb-commits] [lldb] 2af2bc3 - Disable ptr_ref tests under ASAN

Author: Adrian Prantl Date: 2020-05-21T10:38:26-07:00 New Revision: 2af2bc33d36f97b43bbad33286d6ec81e6d7afad URL: https://github.com/llvm/llvm-project/commit/2af2bc33d36f97b43bbad33286d6ec81e6d7afad DIFF: https://github.com/llvm/llvm-project/commit/2af2bc33d36f97b43bbad33286d6ec81e6d7afad.diff

[Lldb-commits] [lldb] a62a520 - Disable malloc stepping test under ASAN. The output is different and I'm not sure how stable it is.

Author: Adrian Prantl Date: 2020-05-21T10:41:27-07:00 New Revision: a62a5200445abddd5a559a4dee2db0cc545eab5b URL: https://github.com/llvm/llvm-project/commit/a62a5200445abddd5a559a4dee2db0cc545eab5b DIFF: https://github.com/llvm/llvm-project/commit/a62a5200445abddd5a559a4dee2db0cc545eab5b.diff

[Lldb-commits] [lldb] 60dff35 - Move decorator to the correct function.

Author: Adrian Prantl Date: 2020-05-21T10:42:26-07:00 New Revision: 60dff35fd435e5c5b434091019a78183260552be URL: https://github.com/llvm/llvm-project/commit/60dff35fd435e5c5b434091019a78183260552be DIFF: https://github.com/llvm/llvm-project/commit/60dff35fd435e5c5b434091019a78183260552be.diff

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

JDevlieghere added a comment. In D80112#2048805 , @fallkrum wrote: > Anybody there? Do you see me? Unless this change is somehow urgent, the common courtesy ‘ping’ rate is once a week [1][2]. I'm sure Jim or Greg will take a look when they can. Would i

[Lldb-commits] [PATCH] D80350: Handle the case where a thread exits while we were running a function on it

jingham updated this revision to Diff 265608. jingham added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80350/new/ https://reviews.llvm.org/D80350 Files: lldb/include/lldb/lldb-enumerations.h lldb/source/Expression/Fu

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. In D80112#2049657 , @JDevlieghere wrote: > In D80112#2048805 , @fallkrum wrote: > > > Anybody there? Do you see me? > > > Unless this change is somehow urgent, the common courtesy ‘ping’ r

[Lldb-commits] [PATCH] D80408: [lldb/Test] Remove issue_verification subdirectory

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, LLDB. Seems like these files haven't been touched since 2015. Repository: rLLDB LLDB https://reviews.llvm.org/D80408 Files: lldb/test/API/issue_verification/README.txt lldb/test/API/issue_verification/Tes

[Lldb-commits] [PATCH] D80350: Handle the case where a thread exits while we were running a function on it

jasonmolenda added a comment. I skimmed it, I guess the one question that comes to mind is how this will behave if we an operating system thread provider plugin active, where it may not actually list all of the threads that exist -- where we try to be tolerant of threads disappearing and then r

[Lldb-commits] [PATCH] D80350: Handle the case where a thread exits while we were running a function on it

aprantl added a comment. This looks reasonable based on my limited knowledge. Comment at: lldb/source/Target/Process.cpp:4671 + "the expression was running.", + thread_id); +return eExpressionThreadVanished; Is it useful to both log

[Lldb-commits] [PATCH] D80350: Handle the case where a thread exits while we were running a function on it

jingham marked an inline comment as done. jingham added inline comments. Comment at: lldb/source/Target/Process.cpp:4671 + "the expression was running.", + thread_id); +return eExpressionThreadVanished; aprantl wrote: > Is it useful to

[Lldb-commits] [PATCH] D80350: Handle the case where a thread exits while we were running a function on it

jingham updated this revision to Diff 265632. jingham added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80350/new/ https://reviews.llvm.org/D80350 Files: lldb/include/lldb/lldb-enumerations.h lldb/source/Ex

[Lldb-commits] [lldb] e6b6132 - Rename FunctionOptimizationWarning to the more generic FrameSelectedCallback (NFC)

Author: Adrian Prantl Date: 2020-05-21T16:22:01-07:00 New Revision: e6b613254d8b62cdd64ee9d8376f2bdda1bcc359 URL: https://github.com/llvm/llvm-project/commit/e6b613254d8b62cdd64ee9d8376f2bdda1bcc359 DIFF: https://github.com/llvm/llvm-project/commit/e6b613254d8b62cdd64ee9d8376f2bdda1bcc359.diff

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

JDevlieghere added a comment. In D80112#2050127 , @fallkrum wrote: > In D80112#2049657 , @JDevlieghere > wrote: > > > In D80112#2048805 , @fallkrum > > wrote: > > > > > Any

[Lldb-commits] [lldb] 1d64d69 - [lldb/Reproducers] Skip lldb-vscode category when lldb-run-with-repro is set.

Author: Jonas Devlieghere Date: 2020-05-21T17:02:04-07:00 New Revision: 1d64d69ab701d9524ee6871e93a2a2f8195fa798 URL: https://github.com/llvm/llvm-project/commit/1d64d69ab701d9524ee6871e93a2a2f8195fa798 DIFF: https://github.com/llvm/llvm-project/commit/1d64d69ab701d9524ee6871e93a2a2f8195fa798.d

[Lldb-commits] [lldb] 9e391d4 - [lldb/Test] Cleanup TestSymbolContext.py

Author: Jonas Devlieghere Date: 2020-05-21T17:32:05-07:00 New Revision: 9e391d4faa839c6aedf8729bb027adf5e2cd7735 URL: https://github.com/llvm/llvm-project/commit/9e391d4faa839c6aedf8729bb027adf5e2cd7735 DIFF: https://github.com/llvm/llvm-project/commit/9e391d4faa839c6aedf8729bb027adf5e2cd7735.d

[Lldb-commits] [PATCH] D80418: Print a warning when stopped in a frame LLDB has no plugin for.

aprantl created this revision. aprantl added reviewers: jingham, JDevlieghere. This patchs adds an optional warning that is printed when stopped at a frame that was compiled in a source language that LLDB has no plugin for. The motivational use-case is debugging Swift code on Linux. When the user

[Lldb-commits] [lldb] dbbed97 - Handle the case where a thread exits while we are running a function on it.

Author: Jim Ingham Date: 2020-05-21T17:55:53-07:00 New Revision: dbbed971e3a282f44242297b75a527256eb862dc URL: https://github.com/llvm/llvm-project/commit/dbbed971e3a282f44242297b75a527256eb862dc DIFF: https://github.com/llvm/llvm-project/commit/dbbed971e3a282f44242297b75a527256eb862dc.diff LO

[Lldb-commits] [lldb] 1583766 - This very simple .c file is failing on the Debian bot wit the error

Author: Jim Ingham Date: 2020-05-21T18:26:01-07:00 New Revision: 1583766ed23b707898e872728783f054ede47ca8 URL: https://github.com/llvm/llvm-project/commit/1583766ed23b707898e872728783f054ede47ca8 DIFF: https://github.com/llvm/llvm-project/commit/1583766ed23b707898e872728783f054ede47ca8.diff LO

[Lldb-commits] [lldb] 54c2c2a - Maybe I need ENABLE_THREADS in the Makefile.

Author: Jim Ingham Date: 2020-05-21T18:38:49-07:00 New Revision: 54c2c2add7ad42ce1910a276cd1cd2912af4cddd URL: https://github.com/llvm/llvm-project/commit/54c2c2add7ad42ce1910a276cd1cd2912af4cddd DIFF: https://github.com/llvm/llvm-project/commit/54c2c2add7ad42ce1910a276cd1cd2912af4cddd.diff LO

[Lldb-commits] [lldb] e3a0283 - [lldb/Test] Fix replay with TestSetWatchpoint.py

Author: Jonas Devlieghere Date: 2020-05-21T20:35:32-07:00 New Revision: e3a0283e5a3f7eccd82c7e090188926723e8d8c9 URL: https://github.com/llvm/llvm-project/commit/e3a0283e5a3f7eccd82c7e090188926723e8d8c9 DIFF: https://github.com/llvm/llvm-project/commit/e3a0283e5a3f7eccd82c7e090188926723e8d8c9.d

[Lldb-commits] [lldb] 329abed - [lldb/Reproducers] Skip test that changes the source file while debugging

Author: Jonas Devlieghere Date: 2020-05-21T20:36:39-07:00 New Revision: 329abed10b84ce502a86dfb077710db22f4ddd01 URL: https://github.com/llvm/llvm-project/commit/329abed10b84ce502a86dfb077710db22f4ddd01 DIFF: https://github.com/llvm/llvm-project/commit/329abed10b84ce502a86dfb077710db22f4ddd01.d

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

paolosev added a comment. Hello @clayborg , @labath, Any thoughts on this latest patch? :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78801/new/ https://reviews.llvm.org/D78801 ___ lldb-commits mai

[Lldb-commits] [lldb] 8a6333e - [lldb/REPL] Fix unhandled switch case

Author: Jonas Devlieghere Date: 2020-05-21T23:22:17-07:00 New Revision: 8a6333ef38088b65224bc021a14f0a123a29 URL: https://github.com/llvm/llvm-project/commit/8a6333ef38088b65224bc021a14f0a123a29 DIFF: https://github.com/llvm/llvm-project/commit/8a6333ef38088b65224bc021a14f0a123a29.d

Re: [Lldb-commits] [lldb] 8a6333e - [lldb/REPL] Fix unhandled switch case

Jim, does this look correct to you? On Thu, May 21, 2020 at 11:22 PM Jonas Devlieghere via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Jonas Devlieghere > Date: 2020-05-21T23:22:17-07:00 > New Revision: 8a6333ef38088b65224bc021a14f0a123a29 > > URL: > https://github.com/llvm