jingham marked an inline comment as done.
jingham added inline comments.
================
Comment at: lldb/source/Target/Process.cpp:4671
+ "the expression was running.",
+ thread_id);
+ return eExpressionThreadVanished;
----------------
aprantl wrote:
> Is it useful to both log the message and have an almost similarly-worded
> diagnostic produced in LLVMUserExpression.cpp?
>
> ("Yes" is an acceptable answer)
The diagnostic will go the the user, and end up in the Error in the expression
result ValueObject. So that part we have to do. Putting it in the log will
make the message show up where it happens in the flow of events we're logging,
which is very handy. So IMO it is worthwhile doing the latter as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80350/new/
https://reviews.llvm.org/D80350
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
