[Lldb-commits] [PATCH] D75680: [lldb] Delete UnwindMacOSXFrameBackchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG71c1c184744c: [lldb] Delete UnwindMacOSXFrameBackchain (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75680/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

labath added a comment. I am somewhat worried about the direction this is taking. Maybe vanishing threads are fine for os-level debugging (because there the "real" threads are the cpu cores, and the os threads are somewhat imaginary), but I definitely wouldn't want to do it for regular debuggin

[Lldb-commits] [lldb] eaddbc2 - LLDB AArch64 skip single_step_only_steps_one_instruction* tests

Author: Muhammad Omair Javaid Date: 2020-03-06T14:26:11+05:00 New Revision: eaddbc238d5fcca19432939223c87e4011b66546 URL: https://github.com/llvm/llvm-project/commit/eaddbc238d5fcca19432939223c87e4011b66546 DIFF: https://github.com/llvm/llvm-project/commit/eaddbc238d5fcca19432939223c87e4011b665

[Lldb-commits] [PATCH] D75555: [GlobalISel][Localizer] Enable intra-block localization of already-local uses.

omjavaid added a comment. In D7#1908351 , @aemerson wrote: > @omjavaid can you look over the lldb changes? I don't have the hardware to be > able to actually run this test but I've tried to relax the checks. @aemerson I have moved these test to skip

[Lldb-commits] [lldb] aa73ee0 - [lldb/test] Use inline assembly for instruction counting tests

Author: Pavel Labath Date: 2020-03-06T11:05:07+01:00 New Revision: aa73ee052fffb0d06c6b7d8caf0271652c07a80d URL: https://github.com/llvm/llvm-project/commit/aa73ee052fffb0d06c6b7d8caf0271652c07a80d DIFF: https://github.com/llvm/llvm-project/commit/aa73ee052fffb0d06c6b7d8caf0271652c07a80d.diff

[Lldb-commits] [PATCH] D75555: [GlobalISel][Localizer] Enable intra-block localization of already-local uses.

labath added a comment. Yep, that test really shouldn't be doing that. Historically, lldb has been avoiding architecture specific artifacts (like assembly) in its tests, but that didn't really work out here. That test has become a nightmare of architecture-specific assertions. If we're going t

[Lldb-commits] [lldb] 92c0cda - [lldb/Disassembler] Move address resolution into the ParseInstructions function

Author: Pavel Labath Date: 2020-03-06T11:23:41+01:00 New Revision: 92c0cda92847053297ad1f083f13469ff7b43871 URL: https://github.com/llvm/llvm-project/commit/92c0cda92847053297ad1f083f13469ff7b43871 DIFF: https://github.com/llvm/llvm-project/commit/92c0cda92847053297ad1f083f13469ff7b43871.diff

[Lldb-commits] [PATCH] D75730: [lldb] Reduce duplication in the Disassembler class

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Commands/CommandObjectDisassemble.cpp:462-469 +Disassembler::Limit limit; +if (m_options.num_instructions == 0) { + limit = {Disassembler::Limit::Bytes, cur_range.GetByteSi

[Lldb-commits] [PATCH] D75730: [lldb] Reduce duplication in the Disassembler class

labath created this revision. labath added a reviewer: JDevlieghere. Herald added subscribers: atanasyan, jrtc27, sdardis. Herald added a project: LLDB. labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Commands/CommandObjectDisassembl

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. kwk planned changes to this revision. This first patch does the heavy lifting of bootstrapping debuginfod with CMake and integrating it to find a source file using debuginfod when using `(lldb)

[Lldb-commits] [PATCH] D75418: tab completion for process signal

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I would like to have a test for this without a running process but otherwise this LGTM. Thanks a lot! Comment at: lldb/test/API/functionalities/completion/Te

[Lldb-commits] [PATCH] D75753: Simplified return type of getBuildIDFromModule

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk added a child revision: D75754: Fix typo. kwk abandoned this revision. kwk added a comment. I didn't intend to create a new revision. Depends on D75750 . Repos

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 248746. kwk added a comment. - Simplified return type of getBuildIDFromModule - fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files: lldb/cmake/modules/FindD

[Lldb-commits] [PATCH] D75754: Fix typo

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk abandoned this revision. kwk added a comment. I didn't intend to create a new revision. Depends on D75753 . Repository: rG LLVM Github Monorepo https://revi

[Lldb-commits] [PATCH] D75753: Simplified return type of getBuildIDFromModule

kwk abandoned this revision. kwk added a comment. I didn't intend to create a new revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75753/new/ https://reviews.llvm.org/D75753 ___ lldb-commits mai

[Lldb-commits] [PATCH] D75754: Fix typo

kwk abandoned this revision. kwk added a comment. I didn't intend to create a new revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75754/new/ https://reviews.llvm.org/D75754 ___ lldb-commits mai

[Lldb-commits] [lldb] 59d816d - Correctly identify iOS simulator processes in debugserver.

Author: Adrian Prantl Date: 2020-03-06T09:42:05-08:00 New Revision: 59d816d88464e93a89e0d9c80c8855ab1f453541 URL: https://github.com/llvm/llvm-project/commit/59d816d88464e93a89e0d9c80c8855ab1f453541 DIFF: https://github.com/llvm/llvm-project/commit/59d816d88464e93a89e0d9c80c8855ab1f453541.diff

[Lldb-commits] [lldb] 66a6fa6 - Revert "Correctly identify iOS simulator processes in debugserver."

Author: Adrian Prantl Date: 2020-03-06T09:52:20-08:00 New Revision: 66a6fa631eb33673a29059fee64d3eef26fc5c28 URL: https://github.com/llvm/llvm-project/commit/66a6fa631eb33673a29059fee64d3eef26fc5c28 DIFF: https://github.com/llvm/llvm-project/commit/66a6fa631eb33673a29059fee64d3eef26fc5c28.diff

[Lldb-commits] [PATCH] D75696: Correctly detect iOS simulator processes.

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/test/API/functionalities/gdb_remote_client/TestWasm.py:35 -if packet == "qProcessInfo": -return self.qProcessInfo() if packet[0:13] == "qRegisterInfo": -

[Lldb-commits] [PATCH] D75730: [lldb] Reduce duplication in the Disassembler class

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Neat! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75730/new/ https://reviews.llvm.org/D75730 __

[Lldb-commits] [PATCH] D75696: Correctly detect iOS simulator processes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG59d816d88464: Correctly identify iOS simulator processes in debugserver. (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D75696?vs=248634&id=248776

[Lldb-commits] [lldb] 58c506d - Correctly identify iOS simulator processes in debugserver.

Author: Adrian Prantl Date: 2020-03-06T09:59:30-08:00 New Revision: 58c506d8e8d9d55d3fb1f4ae508eb53231557f8c URL: https://github.com/llvm/llvm-project/commit/58c506d8e8d9d55d3fb1f4ae508eb53231557f8c DIFF: https://github.com/llvm/llvm-project/commit/58c506d8e8d9d55d3fb1f4ae508eb53231557f8c.diff

[Lldb-commits] [lldb] 3ed0234 - Increase default timeout in lldbutil.expect_state_changes()

Author: Adrian Prantl Date: 2020-03-06T10:00:47-08:00 New Revision: 3ed02340eaaf48cc0fe14b0e40e6cd3d9815de78 URL: https://github.com/llvm/llvm-project/commit/3ed02340eaaf48cc0fe14b0e40e6cd3d9815de78 DIFF: https://github.com/llvm/llvm-project/commit/3ed02340eaaf48cc0fe14b0e40e6cd3d9815de78.diff

[Lldb-commits] [lldb] 000847f - Correctly identify iOS simulator processes in debugserver.

Author: Adrian Prantl Date: 2020-03-06T10:16:47-08:00 New Revision: 000847f8bed4a8624de3e39ff90af721cf8a1e2b URL: https://github.com/llvm/llvm-project/commit/000847f8bed4a8624de3e39ff90af721cf8a1e2b DIFF: https://github.com/llvm/llvm-project/commit/000847f8bed4a8624de3e39ff90af721cf8a1e2b.diff

[Lldb-commits] [lldb] 4ebe9b4 - Revert "Correctly identify iOS simulator processes in debugserver."

Author: Adrian Prantl Date: 2020-03-06T10:16:47-08:00 New Revision: 4ebe9b498da5cfec48a91f50241c686153ab6122 URL: https://github.com/llvm/llvm-project/commit/4ebe9b498da5cfec48a91f50241c686153ab6122 DIFF: https://github.com/llvm/llvm-project/commit/4ebe9b498da5cfec48a91f50241c686153ab6122.diff

[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate updated this revision to Diff 248784. MrHate added a comment. Added a test case where test "process signal" without a running process. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 Files: lldb/source/Commands/CommandObjectProcess.cpp

[Lldb-commits] [lldb] ec31255 - [lldb] Update the current execution context at the beginning of tab completions

Author: Gongyu Deng Date: 2020-03-06T10:44:00-08:00 New Revision: ec31255c00808dac40710173162f22e4ee89a2fe URL: https://github.com/llvm/llvm-project/commit/ec31255c00808dac40710173162f22e4ee89a2fe DIFF: https://github.com/llvm/llvm-project/commit/ec31255c00808dac40710173162f22e4ee89a2fe.diff L

[Lldb-commits] [PATCH] D75597: Update the current execution context at the beginning of tab completions

This revision was automatically updated to reflect the committed changes. Closed by commit rGec31255c0080: [lldb] Update the current execution context at the beginning of tab completions (authored by Gongyu Deng , committed by teemperor). Herald added a subscriber: lldb-commit

[Lldb-commits] [lldb] 3b2c4e7 - [lldb] Remove some #ifdef LLDB_CONFIGURATION_DEBUG around asserts

Author: Raphael Isemann Date: 2020-03-06T11:21:00-08:00 New Revision: 3b2c4e7178c3ca868589c11ceaabe65c7454115d URL: https://github.com/llvm/llvm-project/commit/3b2c4e7178c3ca868589c11ceaabe65c7454115d DIFF: https://github.com/llvm/llvm-project/commit/3b2c4e7178c3ca868589c11ceaabe65c7454115d.dif

[Lldb-commits] [lldb] 33b696b - Fix test broken by simulator triple changes.

Author: Adrian Prantl Date: 2020-03-06T11:28:31-08:00 New Revision: 33b696b57acb6f944cbf22bf81274713c803329e URL: https://github.com/llvm/llvm-project/commit/33b696b57acb6f944cbf22bf81274713c803329e DIFF: https://github.com/llvm/llvm-project/commit/33b696b57acb6f944cbf22bf81274713c803329e.diff

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

jingham added a comment. In D75711#1909055 , @labath wrote: > I am somewhat worried about the direction this is taking. Maybe vanishing > threads are fine for os-level debugging (because there the "real" threads are > the cpu cores, and the os threads ar

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

clayborg added a comment. As long as the keeping thread plans around for threads that aren't there is only enabled when OS plug-in is around, I am fine with this direction. One questions: do we currently only allow stepping on real threads or OS threads that are backed by real threads right now

[Lldb-commits] [PATCH] D75761: Fix to get the AST we generate for function templates to be closer to what clang generates and expects

shafik created this revision. shafik added reviewers: teemperor, aprantl. Fix to get the AST we generate for function templates closer to what clang generates and expects. We fix which `FuntionDecl` we are passing to `CreateFunctionTemplateSpecializationInfo` and we strip template parameters fr

[Lldb-commits] [PATCH] D75493: [lldb] Remove some #ifdef LLDB_CONFIGURATION_DEBUG around asserts

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b2c4e7178c3: [lldb] Remove some #ifdef LLDB_CONFIGURATION_DEBUG around asserts (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D75493?vs=247761&id=248800#toc Repository: r

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

jingham added a comment. In D75711#1910156 , @clayborg wrote: > As long as the keeping thread plans around for threads that aren't there is > only enabled when OS plug-in is around, I am fine with this direction. One > questions: do we currently only all

[Lldb-commits] [PATCH] D75761: Fix to get the AST we generate for function templates to be closer to what clang generates and expects

aprantl added a comment. The general mechanics look good, I have a few comments about the implementation. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:821 +static clang::Optional +StripTemplateParameters(llvm::StringRef Name) { Nit

[Lldb-commits] [lldb] 53b135e - [lldb][NFC] Refactor TestSafeFuncCalls.py

Author: Raphael Isemann Date: 2020-03-06T15:46:36-08:00 New Revision: 53b135eeb491802e1fab5edc5435874acb4770da URL: https://github.com/llvm/llvm-project/commit/53b135eeb491802e1fab5edc5435874acb4770da DIFF: https://github.com/llvm/llvm-project/commit/53b135eeb491802e1fab5edc5435874acb4770da.dif

[Lldb-commits] [PATCH] D75497: [lldb][NFC] Refactor TestSafeFuncCalls.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG53b135eeb491: [lldb][NFC] Refactor TestSafeFuncCalls.py (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75497/new/ https://reviews.ll

[Lldb-commits] [PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

rnk created this revision. rnk added reviewers: aaron.ballman, hans. Herald added projects: clang, LLDB. Herald added a subscriber: lldb-commits. Module.h takes 86ms to parse, mostly parsing the class itself. Avoid it if possible. ASTContext.h depends on ExternalASTSource.h. A few NFC changes wer

[Lldb-commits] [PATCH] D75418: tab completion for process signal

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 ___ lldb-commits mailing li

[Lldb-commits] [lldb] 2bba1c2 - tab completion for process signal

Author: Raphael Isemann Date: 2020-03-06T17:05:25-08:00 New Revision: 2bba1c22e77a67bc6c245fbd4fa74160d33be564 URL: https://github.com/llvm/llvm-project/commit/2bba1c22e77a67bc6c245fbd4fa74160d33be564 DIFF: https://github.com/llvm/llvm-project/commit/2bba1c22e77a67bc6c245fbd4fa74160d33be564.dif

[Lldb-commits] [PATCH] D75418: tab completion for process signal

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bba1c22e77a: tab completion for process signal (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D

[Lldb-commits] [lldb] ce1bc00 - [lldb][cmake] Move remove_module_flags macro to AddLLDB.cmake

Author: Raphael Isemann Date: 2020-03-06T17:21:24-08:00 New Revision: ce1bc00f37d7f85004aef97f68eb8289a0454562 URL: https://github.com/llvm/llvm-project/commit/ce1bc00f37d7f85004aef97f68eb8289a0454562 DIFF: https://github.com/llvm/llvm-project/commit/ce1bc00f37d7f85004aef97f68eb8289a0454562.dif

[Lldb-commits] [lldb] 4e7c686 - [lldb] Never compile the debugserver with Clang module flags

Author: Raphael Isemann Date: 2020-03-06T17:26:39-08:00 New Revision: 4e7c686e46c394b339919df9f716614675d81613 URL: https://github.com/llvm/llvm-project/commit/4e7c686e46c394b339919df9f716614675d81613 DIFF: https://github.com/llvm/llvm-project/commit/4e7c686e46c394b339919df9f716614675d81613.dif

[Lldb-commits] [PATCH] D75164: [lldb][cmake] Move remove_module_flags macro to AddLLDB.cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rGce1bc00f37d7: [lldb][cmake] Move remove_module_flags macro to AddLLDB.cmake (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75164/new/

[Lldb-commits] [PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

aprantl added a comment. This will no doubt also need some patches to the Swift compiler, but given the NFC-ness this hopefully should be fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75784/new/ https://reviews.llvm.org/D75784 ___

[Lldb-commits] [PATCH] D74891: [lldb] Never compile the debugserver with Clang module flags

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e7c686e46c3: [lldb] Never compile the debugserver with Clang module flags (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74891/new/

[Lldb-commits] [PATCH] D75711: [NFC] Have ThreadPlans hold onto the Process & TID, rather than the Thread

jingham updated this revision to Diff 248868. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75711/new/ https://reviews.llvm.org/D75711 Files: lldb/include/lldb/Target/ThreadPlan.h lldb/include/lldb/Target/ThreadPlanPython.h lldb/source/Plugin

[Lldb-commits] [PATCH] D75720: Make ThreadPlanTracer use {Process, TID} rather than Thread to find it's underlying thread...

jingham updated this revision to Diff 248869. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75720/new/ https://reviews.llvm.org/D75720 Files: lldb/include/lldb/Target/ThreadPlanTracer.h lldb/source/Target/ThreadPlanTracer.cpp Index: lldb/source

[Lldb-commits] [lldb] 8f7c911 - [lldb][NFC] Refactor our option generation out of EvaluateExpression

Author: Raphael Isemann Date: 2020-03-06T18:32:16-08:00 New Revision: 8f7c911b58813908da7fa99c7c1a8e7ca1a58213 URL: https://github.com/llvm/llvm-project/commit/8f7c911b58813908da7fa99c7c1a8e7ca1a58213 DIFF: https://github.com/llvm/llvm-project/commit/8f7c911b58813908da7fa99c7c1a8e7ca1a58213.dif

[Lldb-commits] [lldb] 6bbdecc - [lldb][NFC] Make TestStats.py not an inline test

Author: Raphael Isemann Date: 2020-03-06T18:47:59-08:00 New Revision: 6bbdecc5cf8096148df4726245f3bc60e464c76b URL: https://github.com/llvm/llvm-project/commit/6bbdecc5cf8096148df4726245f3bc60e464c76b DIFF: https://github.com/llvm/llvm-project/commit/6bbdecc5cf8096148df4726245f3bc60e464c76b.dif

[Lldb-commits] [PATCH] D75555: [GlobalISel][Localizer] Enable intra-block localization of already-local uses.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1a97e992da6: Revert "Revert "[GlobalISel][Localizer] Enable intra-block localization of… (authored by aemerson). Changed prior to commit: https://reviews.llvm.org/D7?vs=248567&id=248898#toc Repos