teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed.
I would like to have a test for this without a running process but otherwise this LGTM. Thanks a lot! ================ Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:97 + ['SIGABRT', + 'SIGALRM']) + ---------------- Could you make another test case that is trying tab completion without a running process? That should just provide no completions and not crash or something like that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
