[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Actually I think this is fine. We would want to squeeze as much information as possible from these kinds of line tables. I don't think fully preserving the existing behavior would be that easy

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

labath added a comment. In D70840#1845176 , @clayborg wrote: > Speaking to having the LLVM layer strip things out, this should be an option > if it does get added there. If we have a stripped binary and we have no > symbols or any other CPU map, and DWAR

[Lldb-commits] [lldb] a5fb2e3 - [lldb] Complete return types of CXXMethodDecls to prevent crashing due to covariant return types

Author: Raphael Isemann Date: 2020-01-29T09:08:35+01:00 New Revision: a5fb2e371ec2b585ca56cbc1a116912aabe347d3 URL: https://github.com/llvm/llvm-project/commit/a5fb2e371ec2b585ca56cbc1a116912aabe347d3 DIFF: https://github.com/llvm/llvm-project/commit/a5fb2e371ec2b585ca56cbc1a116912aabe347d3.dif

[Lldb-commits] [PATCH] D73517: [lldb] Delete ValueObject::GetBaseClassPath

labath added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2041 void ValueObject::GetExpressionPath(Stream &s, bool qualify_cxx_base_classes, GetExpressionPathFormat epformat) { Should we remove the `qualify

[Lldb-commits] [PATCH] D73024: [lldb] Complete return types of CXXMethodDecls to prevent crashing due to covariant return types

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5fb2e371ec2: [lldb] Complete return types of CXXMethodDecls to prevent crashing due to… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] ab8b22d - [lldb] Don't create duplicate declarations when completing a forward declaration with a definition from another source

Author: Raphael Isemann Date: 2020-01-29T09:20:47+01:00 New Revision: ab8b22d1c2d97b1e50c73b8640c3acb192652059 URL: https://github.com/llvm/llvm-project/commit/ab8b22d1c2d97b1e50c73b8640c3acb192652059 DIFF: https://github.com/llvm/llvm-project/commit/ab8b22d1c2d97b1e50c73b8640c3acb192652059.dif

[Lldb-commits] [PATCH] D73345: [lldb] Don't create duplicate declarations when completing a forward declaration with a definition from another source

This revision was automatically updated to reflect the committed changes. Closed by commit rGab8b22d1c2d9: [lldb] Don't create duplicate declarations when completing a forward… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

labath added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4103 +// this point. +// TODO: Is this part worthwhile? `foo.exe` will never match `foo.pdb` +if (matching_modules.IsEmpty()) This is not unreasonable in the non-

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

jhenderson added a comment. Thanks for the review comments! I'll go ahead and land it like this, assuming my local test run passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72158/new/ https://reviews.llvm.org/D72158 ___

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

labath added a comment. Since the failure reason was not very obvious from the bot message, I took a quick look, and to save you the trouble of reproducing this, here's what I found: The reason the new test failed was because the symbols you are searching for (`__GI_raise`, `__GI___assert_fail

[Lldb-commits] [lldb] e06444d - [lldb] Fix windows build for the StringRef conversion operator change

Author: Pavel Labath Date: 2020-01-29T10:08:40+01:00 New Revision: e06444d982f031ed2de20b8d5d3de2dfadb09e96 URL: https://github.com/llvm/llvm-project/commit/e06444d982f031ed2de20b8d5d3de2dfadb09e96 DIFF: https://github.com/llvm/llvm-project/commit/e06444d982f031ed2de20b8d5d3de2dfadb09e96.diff

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks. This looks fine but could you also change the title of the patch please? This patch doesn't really have anything to do with remote debugging (though it's fine to mention that this is e

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added a reviewer: jingham. labath added a subscriber: jingham. labath added a comment. Thanks. My hopefully final question is not really for you but more like for other lldb developers (@jingham, @clayborg, etc.). Given that this plugin is now consisting of boiler plate only, I am wonderi

[Lldb-commits] [lldb] 7a6ebb5 - [lldb] More windows StringRef fixes

Author: Pavel Labath Date: 2020-01-29T11:15:20+01:00 New Revision: 7a6ebb5ba3cefef1865a2e0c5f9196101cbd2733 URL: https://github.com/llvm/llvm-project/commit/7a6ebb5ba3cefef1865a2e0c5f9196101cbd2733 DIFF: https://github.com/llvm/llvm-project/commit/7a6ebb5ba3cefef1865a2e0c5f9196101cbd2733.diff

[Lldb-commits] [lldb] 7116e43 - [DebugInfo] Make most debug line prologue errors non-fatal to parsing

Author: James Henderson Date: 2020-01-29T10:23:41Z New Revision: 7116e431c0ab4194907bbaf73482ac05d923787f URL: https://github.com/llvm/llvm-project/commit/7116e431c0ab4194907bbaf73482ac05d923787f DIFF: https://github.com/llvm/llvm-project/commit/7116e431c0ab4194907bbaf73482ac05d923787f.diff LO

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rG7116e431c0ab: [DebugInfo] Make most debug line prologue errors non-fatal to parsing (authored by jhenderson). Changed prior to commit: https://reviews.llvm.org/D72158?vs=240852&id=241076#toc Repository

[Lldb-commits] [PATCH] D73539: [AVR] Recognize the AVR architecture in lldb

aykevl added a comment. Ok, I've updated the title and the commit message (text until the separator). Does that look good? I have commit access so I can merge this myself. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73539/new/ https://reviews.llvm.org/D73539 _

[Lldb-commits] [lldb] 33fa672 - [lldb/Reproducers] Add logging to the string template specialization

Author: Jonas Devlieghere Date: 2020-01-29T09:16:43-08:00 New Revision: 33fa6727b7ce1c3aad6ef4bb24dff2ce3e3b2c7a URL: https://github.com/llvm/llvm-project/commit/33fa6727b7ce1c3aad6ef4bb24dff2ce3e3b2c7a DIFF: https://github.com/llvm/llvm-project/commit/33fa6727b7ce1c3aad6ef4bb24dff2ce3e3b2c7a.d

[Lldb-commits] [lldb] ce07cde - [lldb/Host] Fix implicit StringRef to std::string conversion

Author: Jonas Devlieghere Date: 2020-01-29T10:36:04-08:00 New Revision: ce07cdea336619c308c3130e936944c67774549d URL: https://github.com/llvm/llvm-project/commit/ce07cdea336619c308c3130e936944c67774549d DIFF: https://github.com/llvm/llvm-project/commit/ce07cdea336619c308c3130e936944c67774549d.d

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

clayborg added a comment. In D72751#1846385 , @labath wrote: > Thanks. My hopefully final question is not really for you but more like for > other lldb developers (@jingham, @clayborg, etc.). > > Given that this plugin is now consisting of boiler plate on

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

clayborg added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4149 + +lldbassert(matching_modules.GetSize() == 1); +ModuleSP module_sp(matching_modules.GetModuleAtIndex(0)); labath wrote: > This should be a regular assert ac

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

amccarth marked 3 inline comments as done. amccarth added a comment. Thanks for the feedback. Obviously I'm confused about how LLDB handles split debug info, so I need more clarification about how to proceed. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4103 +

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

amccarth marked an inline comment as done. amccarth added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4149 + +lldbassert(matching_modules.GetSize() == 1); +ModuleSP module_sp(matching_modules.GetModuleAtIndex(0)); claybor

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

clayborg added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4149 + +lldbassert(matching_modules.GetSize() == 1); +ModuleSP module_sp(matching_modules.GetModuleAtIndex(0)); amccarth wrote: > clayborg wrote: > > labath wrote

[Lldb-commits] [lldb] a111ffb - [lldb] Fix build break in ProcessDebugger due to StringRef usage changes

Author: Stella Stamenova Date: 2020-01-29T13:19:04-08:00 New Revision: a111ffbb03f7a9e61bfb2dc29689234887e30014 URL: https://github.com/llvm/llvm-project/commit/a111ffbb03f7a9e61bfb2dc29689234887e30014 DIFF: https://github.com/llvm/llvm-project/commit/a111ffbb03f7a9e61bfb2dc29689234887e30014.di

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

amccarth marked 2 inline comments as done. amccarth added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4175 + +if (object_file->GetFileSpec() != symbol_fspec) { + result.AppendWarning("there is a discrepancy between the module file "

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

clayborg added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4175 + +if (object_file->GetFileSpec() != symbol_fspec) { + result.AppendWarning("there is a discrepancy between the module file " amccarth wrote: > amccarth wro

[Lldb-commits] [lldb] 91aa67b - [lldb/Reproducers] Add (de)serialization overload for char**

Author: Jonas Devlieghere Date: 2020-01-29T14:08:21-08:00 New Revision: 91aa67bf290bc7f877b1b90128284863bc31aa43 URL: https://github.com/llvm/llvm-project/commit/91aa67bf290bc7f877b1b90128284863bc31aa43 DIFF: https://github.com/llvm/llvm-project/commit/91aa67bf290bc7f877b1b90128284863bc31aa43.d

[Lldb-commits] [PATCH] D73665: Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

clayborg created this revision. clayborg added a reviewer: labath. Herald added a project: LLDB. The VS Code DAP expects on response for each breakpoint that was requested. If we responsd with multiple entries for one breakpoint the VS Code UI gets out of date. Currently the VS code DAP doesn't

[Lldb-commits] [PATCH] D73594: Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

amccarth marked an inline comment as done. amccarth added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4175 + +if (object_file->GetFileSpec() != symbol_fspec) { + result.AppendWarning("there is a discrepancy between the module file "

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev added a comment. Regarding: >> - make the base DynamicLoader class instantiatable, and use it whenever we >> fail to find a specialized plugin >> - same as above, but only do that for ProcessGDBRemote instances >> - make ProcessGDBRemote call LoadModules() itself if no dynamic loader >

[Lldb-commits] [lldb] 446e4e4 - [lldb/Reproducers] Account for char** being a nullptr

Author: Jonas Devlieghere Date: 2020-01-29T16:32:48-08:00 New Revision: 446e4e4cf6d1126b4dc2fe816d4bb01b184b2e64 URL: https://github.com/llvm/llvm-project/commit/446e4e4cf6d1126b4dc2fe816d4bb01b184b2e64 DIFF: https://github.com/llvm/llvm-project/commit/446e4e4cf6d1126b4dc2fe816d4bb01b184b2e64.d

[Lldb-commits] [lldb] 91f863b - [lldb/Reproducers] Add unittest for char** (de)serializer

Author: Jonas Devlieghere Date: 2020-01-29T17:16:31-08:00 New Revision: 91f863be4f04337da19c26c4fbda4ce10bfc0668 URL: https://github.com/llvm/llvm-project/commit/91f863be4f04337da19c26c4fbda4ce10bfc0668 DIFF: https://github.com/llvm/llvm-project/commit/91f863be4f04337da19c26c4fbda4ce10bfc0668.d

[Lldb-commits] [lldb] e28d8f9 - [lldb] Replace SmallStr.str().str() with std::string conversion operator.

Author: Jonas Devlieghere Date: 2020-01-29T21:34:19-08:00 New Revision: e28d8f9069b92f5c20416c575f49727daf5adb1a URL: https://github.com/llvm/llvm-project/commit/e28d8f9069b92f5c20416c575f49727daf5adb1a DIFF: https://github.com/llvm/llvm-project/commit/e28d8f9069b92f5c20416c575f49727daf5adb1a.d

[Lldb-commits] [lldb] 12c185a - [lldb/Reproducers] Fix reproducer instrumentation formatting (NFC)

Author: Jonas Devlieghere Date: 2020-01-29T21:38:30-08:00 New Revision: 12c185ac5e5c396018c60565eff50187bace7011 URL: https://github.com/llvm/llvm-project/commit/12c185ac5e5c396018c60565eff50187bace7011 DIFF: https://github.com/llvm/llvm-project/commit/12c185ac5e5c396018c60565eff50187bace7011.d

[Lldb-commits] [lldb] 056f01f - [lldb/Reproducers] Assert when trying to get object for invalid index.

Author: Jonas Devlieghere Date: 2020-01-29T21:34:54-08:00 New Revision: 056f01f895615686e63b9729096f7eb98b47223f URL: https://github.com/llvm/llvm-project/commit/056f01f895615686e63b9729096f7eb98b47223f DIFF: https://github.com/llvm/llvm-project/commit/056f01f895615686e63b9729096f7eb98b47223f.d

[Lldb-commits] [lldb] 0e67212 - Revert "[lldb/Reproducers] Assert when trying to get object for invalid index."

Author: Jonas Devlieghere Date: 2020-01-29T22:02:00-08:00 New Revision: 0e67212416f6f27b9a6270a73cf95e71cabef524 URL: https://github.com/llvm/llvm-project/commit/0e67212416f6f27b9a6270a73cf95e71cabef524 DIFF: https://github.com/llvm/llvm-project/commit/0e67212416f6f27b9a6270a73cf95e71cabef524.d

[Lldb-commits] [PATCH] D73539: [AVR] Recognize the AVR architecture in lldb

labath added a comment. That's fine. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73539/new/ https://reviews.llvm.org/D73539 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/