[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

labath added a comment. I am still waiting for the `g_private_reg_interface` thingy to be removed, or for an explanation of why it cannot be done... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63165/new/ https://reviews.llvm.org/D63165 _

[Lldb-commits] [PATCH] D65952: SymbolVendor: Have plugins return symbol files directly

labath added a comment. In D65952#1623297 , @clayborg wrote: > So I am confused. Are we keeping SymbolVendor around for locating symbols > files or are we getting rid of it entirely? Well... right now my idea was to keep it around as an class with just

[Lldb-commits] [lldb] r368567 - [lldb][NFC] Add unit test for lldb_private::DiagnosticManager

Author: teemperor Date: Mon Aug 12 06:31:45 2019 New Revision: 368567 URL: http://llvm.org/viewvc/llvm-project?rev=368567&view=rev Log: [lldb][NFC] Add unit test for lldb_private::DiagnosticManager Added: lldb/trunk/unittests/Expression/DiagnosticManagerTest.cpp Modified: lldb/trunk/unitt

[Lldb-commits] [lldb] r368577 - [lldb] Remove undocumented return value from DiagnosticManager::PutString

Author: teemperor Date: Mon Aug 12 07:11:37 2019 New Revision: 368577 URL: http://llvm.org/viewvc/llvm-project?rev=368577&view=rev Log: [lldb] Remove undocumented return value from DiagnosticManager::PutString The returned value is currently unused. It also seems to imply that it somehow represen

[Lldb-commits] [lldb] r368582 - [lldb][NFC] Minor fixes for lldb_private::DiagnosticManager

Author: teemperor Date: Mon Aug 12 07:37:12 2019 New Revision: 368582 URL: http://llvm.org/viewvc/llvm-project?rev=368582&view=rev Log: [lldb][NFC] Minor fixes for lldb_private::DiagnosticManager Modified: lldb/trunk/include/lldb/Expression/DiagnosticManager.h Modified: lldb/trunk/include/ll

[Lldb-commits] [PATCH] D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.

davide created this revision. davide added reviewers: xiaobai, compnerd. Herald added a project: LLDB. davide added a reviewer: aprantl. And not `zero`. This is the last API needed to be converted to an Optional. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66093 Files: ll

[Lldb-commits] [PATCH] D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. I appreciate you adding more error handling. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66093/new/ https://reviews.llvm.org/D660

[Lldb-commits] [PATCH] D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.

davide added a comment. More than error handling, this allows us to distinguish with a type with zero alignment (if possible at all?) and an error getting the alignment from ASTContext/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66093/new/ htt

[Lldb-commits] [PATCH] D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.

aprantl accepted this revision. aprantl added inline comments. Comment at: lldb/source/Expression/Materializer.cpp:803 + + size_t byte_align = (*opt_bit_align + 7) / 8; does this also need to be 7ull? Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by no longer failing on variable without metadata

stella.stamenova added a comment. This change caused failures on the Windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/7681 compounding on the existing failures from [lldb] Refactor guard variable checks in IRForTarget Repository: rL LLVM CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Expression/Materializer.cpp:803 + + size_t byte_align = (*opt_bit_align + 7) / 8; aprantl wrote: > does this also need to be 7ull? I'm going to move this to a fu

[Lldb-commits] [PATCH] D66102: [Symbol] Decouple clang from CompilerType

xiaobai created this revision. xiaobai added reviewers: compnerd, aprantl, JDevlieghere, davide. Herald added a project: LLDB. xiaobai added a reviewer: labath. Ideally CompilerType would have no knowledge of clang or any individual TypeSystem. Decoupling clang is relatively straightforward. Rep

[Lldb-commits] [PATCH] D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.

aprantl added a comment. Check LLVM's MathExtras.h, perhaps we already got one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66093/new/ https://reviews.llvm.org/D66093 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidTypeError, a force-checked recoverable error

vsk abandoned this revision. vsk added a subscriber: shafik. vsk added a comment. I don't think this got a lot of buy-in. Let's revisit this if the need to revamp CompilerType becomes more pressing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43912/new/ https://reviews.llvm.org/D4391

[Lldb-commits] [lldb] r368614 - [Symbol] GetTypeBitAlign() should return None in case of failure.

Author: davide Date: Mon Aug 12 13:03:19 2019 New Revision: 368614 URL: http://llvm.org/viewvc/llvm-project?rev=368614&view=rev Log: [Symbol] GetTypeBitAlign() should return None in case of failure. Summary: And not `zero`. This is the last API needed to be converted to an Optional. Reviewers: x

[Lldb-commits] [PATCH] D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368614: [Symbol] GetTypeBitAlign() should return None in case of failure. (authored by davide, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[Lldb-commits] [lldb] r368616 - Revert "[lldb] Refactor guard variable checks in IRForTarget"

Author: stella.stamenova Date: Mon Aug 12 13:08:07 2019 New Revision: 368616 URL: http://llvm.org/viewvc/llvm-project?rev=368616&view=rev Log: Revert "[lldb] Refactor guard variable checks in IRForTarget" This reverts commit 94fbbf712e906464f5f3abbeabcfcbc05d5352ec. Modified: lldb/trunk/sour

[Lldb-commits] [lldb] r368615 - Revert "[lldb] Fix dynamic_cast by no longer failing on variable without metadata"

Author: stella.stamenova Date: Mon Aug 12 13:08:05 2019 New Revision: 368615 URL: http://llvm.org/viewvc/llvm-project?rev=368615&view=rev Log: Revert "[lldb] Fix dynamic_cast by no longer failing on variable without metadata" This reverts commit b448d1bf212219febbb182d00c210bad1bd25e7f. Removed

[Lldb-commits] [PATCH] D66102: [Symbol] Decouple clang from CompilerType

clayborg added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66102/new/ https://reviews.llvm.org/D66102 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D66102: [Symbol] Decouple clang from CompilerType

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66102/new/ https://reviews.llvm.org/D66102 ___

[Lldb-commits] [lldb] r368620 - [CompilerType] Pass an ExecutionContextScope to GetTypeBitAlign.

Author: davide Date: Mon Aug 12 14:49:54 2019 New Revision: 368620 URL: http://llvm.org/viewvc/llvm-project?rev=368620&view=rev Log: [CompilerType] Pass an ExecutionContextScope to GetTypeBitAlign. Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h lldb/trunk/include/lldb/Symbol/C

[Lldb-commits] [PATCH] D62570: Use LLVM's debug line parser in LLDB

JDevlieghere added a comment. I used `image dump line-table` to benchmark the performance difference. I did a RelWithDebugInfo build of clang and picked 237 files to dump. repeat 10 "time ./bin/lldb -b -o 'image dump line-table ARCMT.cpp ARCMTActions.cpp FileRemapper.cpp ObjCMT.cpp PlistRepor

[Lldb-commits] [lldb] r368638 - [Symbol] Remove redundant include

Author: xiaobai Date: Mon Aug 12 17:25:49 2019 New Revision: 368638 URL: http://llvm.org/viewvc/llvm-project?rev=368638&view=rev Log: [Symbol] Remove redundant include Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp URL: http://l