[Lldb-commits] [PATCH] D65386: [lldb][NFC] Use an enum instead of chars when handling options [WIP]

labath added a comment. In D65386#1605119 , @JDevlieghere wrote: > The current patch is fine I think and I think Pavel's suggestion sounds good, > as long as it's well documented. We could make that less magical by including the name of the "setter" me

[Lldb-commits] [PATCH] D65409: [ProcessWindows] Choose a register context file by prepocessor

labath added a comment. The change looks fine to me. I also agree with @compnerd's comments. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65409/new/ https://reviews.llvm.org/D65409 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D65432: [lldb] [test/lldb-vscode] Use realpath to match vscode behavior

mgorny created this revision. mgorny added reviewers: aadsm, krytarowski, xiaobai, jfb. Herald added a subscriber: dexonsmith. mgorny added a comment. FTR, the failure fixed by this is: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/21195/steps/run%20unit%20tests/logs/FAIL%3A%20lldb-Suite%

[Lldb-commits] [PATCH] D65432: [lldb] [test/lldb-vscode] Use realpath to match vscode behavior

mgorny added a comment. FTR, the failure fixed by this is: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/21195/steps/run%20unit%20tests/logs/FAIL%3A%20lldb-Suite%3A%3ATestVSCode_launch.py CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65432/new/ https://reviews.llvm.org/D65432

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

labath added a comment. You might want to have a look at https://reviews.llvm.org/D65409 which might fix (some of?) the issues mentioned here. I don't know if this is relevant or not, but I thought I'd say that on linux we also effectively aren't able to debug a 64-bit process with a 32-bit l

[Lldb-commits] [PATCH] D65432: [lldb] [test/lldb-vscode] Use realpath to match vscode behavior

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LG, just please replace `os.path.split(foo)[0]` by `os.path.dirname(foo)`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65432/new/ https://reviews.llvm.org/D65432

[Lldb-commits] [lldb] r367290 - [lldb] [test/lldb-vscode] Use os.path.dirname() [NFC]

Author: mgorny Date: Tue Jul 30 00:47:16 2019 New Revision: 367290 URL: http://llvm.org/viewvc/llvm-project?rev=367290&view=rev Log: [lldb] [test/lldb-vscode] Use os.path.dirname() [NFC] Replace os.path.split()[0] with os.path.dirname(). Suggested by Pavel Labath in D65432. Modified: lldb/

[Lldb-commits] [lldb] r367291 - [lldb] [test/lldb-vscode] Use realpath to match vscode behavior

Author: mgorny Date: Tue Jul 30 00:47:22 2019 New Revision: 367291 URL: http://llvm.org/viewvc/llvm-project?rev=367291&view=rev Log: [lldb] [test/lldb-vscode] Use realpath to match vscode behavior Compare the directory paths returned by lldb-vscode against realpaths rather than apparent paths. T

[Lldb-commits] [PATCH] D65432: [lldb] [test/lldb-vscode] Use realpath to match vscode behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rL367291: [lldb] [test/lldb-vscode] Use realpath to match vscode behavior (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65329: SymbolVendor: Move locking into the Symbol Files

labath added a comment. In D65329#1604847 , @clayborg wrote: > We will need to watch future submissions closely as this increases the chance > that someone will extend a SymbolFile by overriding a virtual function and > forget to lock. I've though abou

[Lldb-commits] [lldb] r367298 - SymbolVendor: Move locking into the Symbol Files

Author: labath Date: Tue Jul 30 01:20:05 2019 New Revision: 367298 URL: http://llvm.org/viewvc/llvm-project?rev=367298&view=rev Log: SymbolVendor: Move locking into the Symbol Files Summary: The last bit of functionality in SymbolVendor passthrough functions is the locking the module mutex. While

[Lldb-commits] [PATCH] D65329: SymbolVendor: Move locking into the Symbol Files

This revision was automatically updated to reflect the committed changes. Closed by commit rL367298: SymbolVendor: Move locking into the Symbol Files (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LA

[Lldb-commits] [PATCH] D65401: SymbolVendor: Remove the object file member variable

labath added a comment. In D65401#1604870 , @clayborg wrote: > So previously the SymbolVendor would only make a strong reference to the > object file if it didn't match the object file of the module. Now it always > makes one. Might be ok since the Modul

[Lldb-commits] [lldb] r367299 - PECOFF: Fix a "memset clearing an object of non-trivial type" warning

Author: labath Date: Tue Jul 30 01:42:42 2019 New Revision: 367299 URL: http://llvm.org/viewvc/llvm-project?rev=367299&view=rev Log: PECOFF: Fix a "memset clearing an object of non-trivial type" warning This time, the warning pointed to an actual problem, because the coff_opt_header structure con

[Lldb-commits] [PATCH] D65435: SymbolVendor: Introduce Module::GetSymbolFile

labath created this revision. labath added reviewers: JDevlieghere, clayborg, jingham. This is the next step in avoiding funneling all SymbolFile calls through the SymbolVendor. Right now, it is just a convenience function, but it allows us to update all calls to SymbolVendor functions to access t

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Hm... this patch spectacularly fails for me with about 100 failures. Are you sure you ran the test suite with this change? I took a brief look at `x86-64-ymm-write.test` as it was ea

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz updated this revision to Diff 212304. sgraenitz added a comment. Add lld note to Windows section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 Files: lldb/docs/resources/build.rst Index: lldb

[Lldb-commits] [lldb] r367302 - [lldb][docs] Update documentation for monorepo and CMake caches

Author: stefan.graenitz Date: Tue Jul 30 03:21:28 2019 New Revision: 367302 URL: http://llvm.org/viewvc/llvm-project?rev=367302&view=rev Log: [lldb][docs] Update documentation for monorepo and CMake caches Summary: The lldb build system made good progress in the last months, but documentation wa

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

This revision was automatically updated to reflect the committed changes. Closed by commit rL367302: [lldb][docs] Update documentation for monorepo and CMake caches (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[Lldb-commits] [PATCH] D65437: [lldb][docs] Update landing page for monorepo

sgraenitz created this revision. sgraenitz added reviewers: jryans, clayborg, amccarth, labath. Herald added a subscriber: arphaman. Herald added a project: LLDB. Following up from D65330 , here's an update for the landing page. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D65437: [lldb][docs] Update landing page for monorepo

sgraenitz added a comment. @clayborg I added a direct link to Xcode project generation here. Is that fine? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65437/new/ https://reviews.llvm.org/D65437 ___ l

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz marked 3 inline comments as done. sgraenitz added inline comments. Comment at: lldb/docs/resources/build.rst:90 + + > git clone https://github.com/llvm/llvm-project.git sgraenitz wrote: > jryans wrote: > > This could be done in a separate patch, but

[Lldb-commits] [lldb] r367307 - [lldb][NFC] Check in crashing test case

Author: teemperor Date: Tue Jul 30 05:20:03 2019 New Revision: 367307 URL: http://llvm.org/viewvc/llvm-project?rev=367307&view=rev Log: [lldb][NFC] Check in crashing test case Added: lldb/trunk/packages/Python/lldbsuite/test/expression_command/completion-crash1/ lldb/trunk/packages/Pyth

[Lldb-commits] [lldb] r367308 - [lldb] Fix crash when tab-completing in multi-line expr

Author: teemperor Date: Tue Jul 30 05:31:24 2019 New Revision: 367308 URL: http://llvm.org/viewvc/llvm-project?rev=367308&view=rev Log: [lldb] Fix crash when tab-completing in multi-line expr Summary: Tab completing inside the multiline expression command can cause LLDB to crash. The easiest way

[Lldb-commits] [PATCH] D64995: [lldb] Fix crash when tab-completing in multi-line expr

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367308: [lldb] Fix crash when tab-completing in multi-line expr (authored by teemperor, committed by ). Herald added a pro

Re: [Lldb-commits] [lldb] r367308 - [lldb] Fix crash when tab-completing in multi-line expr

Hi Raphael, Since this just landed, let's have it bake in trunk a little bit, and then I'll merge it. Thanks, Hans On Tue, Jul 30, 2019 at 2:36 PM Raphael “Teemperor” Isemann wrote: > > Hi Hans, > > Can you cherry-pick this to the 9.0 release? The issue is really easy to hit > when using LLDB

[Lldb-commits] [lldb] r367309 - [lldb][NFC] Fix import-std-module tests that relied on fix-its to pass

Author: teemperor Date: Tue Jul 30 06:11:59 2019 New Revision: 367309 URL: http://llvm.org/viewvc/llvm-project?rev=367309&view=rev Log: [lldb][NFC] Fix import-std-module tests that relied on fix-its to pass These tests currently pass, but they rely on fix-its in our expression parser to pass beca

[Lldb-commits] [PATCH] D65437: [lldb][docs] Update landing page for monorepo

jryans accepted this revision. jryans added a comment. Thanks for working on this! 😁 Comment at: lldb/docs/index.rst:104 `__ mailing list , and this is also the preferred mailing list for patch submissions. --

[Lldb-commits] [PATCH] D65436: [docs] Add git to list of Software requirements

sgraenitz updated this revision to Diff 212336. sgraenitz added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Move git version comment into a footnote in git-llvm section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D65436: [docs] Add git to list of Software requirements

sgraenitz updated this revision to Diff 212338. sgraenitz added a comment. Remove lldb documentation updates I just added accidentally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65436/new/ https://reviews.llvm.org/D65436 Files: llvm/docs/Gett

[Lldb-commits] [PATCH] D65436: [docs] Add git to list of Software requirements

sgraenitz updated this revision to Diff 212340. sgraenitz added a comment. Undo `Compiling -> Working with` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65436/new/ https://reviews.llvm.org/D65436 Files: llvm/docs/GettingStarted.rst Index: llv

[Lldb-commits] [PATCH] D65436: [docs] Add git to list of Software requirements

sgraenitz added a comment. > If we want to add git at all, we should probably mention it somewhere else. > I'm not sure where that would be - I suppose somewhere where it makes sense > to worry about the minimum version, e.g. where the git-llvm script is > concerned. Agree, changed that. > Se

[Lldb-commits] [PATCH] D65450: Add llvm-style RTTI to ObjectFile hierarchy

labath created this revision. labath added reviewers: xiaobai, JDevlieghere. Herald added subscribers: MaskRay, arichardson, mgorny, emaste. Herald added a reviewer: espindola. On the heels of D62934 , this patch uses the same approach to introduce llvm RTTI suppo

[Lldb-commits] [PATCH] D55319: [CMake] Proposal: Prefer LLDB_VERSION over plist value in EmbedAppleVersion.cmake

sgraenitz abandoned this revision. sgraenitz added a comment. This was fixed quite some time ago. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55319/new/ https://reviews.llvm.org/D55319 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D65409: [ProcessWindows] Choose a register context file by prepocessor

tatyana-krasnukha updated this revision to Diff 212363. tatyana-krasnukha added a comment. Addressed comments Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65409/new/ https://reviews.llvm.org/D65409 Files: Common/CMakeLists.txt Common/x64/RegisterContextWi

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb closed this revision. jfb added a comment. https://reviews.llvm.org/rL367282 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65249/new/ https://reviews.llvm.org/D65249 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] r367331 - [dotest] Remove multiprocessing

Author: jdevlieghere Date: Tue Jul 30 09:42:47 2019 New Revision: 367331 URL: http://llvm.org/viewvc/llvm-project?rev=367331&view=rev Log: [dotest] Remove multiprocessing Now that the Xcode project is removed, I want to focus on dotest as a test framework, and remove its driver capabilities for w

[Lldb-commits] [PATCH] D65114: [LLDB] Add utility to streamline Xcode project generation.

JDevlieghere abandoned this revision. JDevlieghere added a comment. It's been a week and so far I haven't seen any complaints. Also I think the documentation Stefan added on lldb.llvm.org look good enough that we may not need a script. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D65311: [dotest] Remove multiprocessing

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367331: [dotest] Remove multiprocessing (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald ad

[Lldb-commits] [PATCH] D65409: [ProcessWindows] Choose a register context file by prepocessor

tatyana-krasnukha added a comment. I wonder if directories `x86` and `x64` are needed. Should I remove them to make hierarchy consistent with D63165 ? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65409/new/ https://reviews.llv

[Lldb-commits] [PATCH] D65409: [ProcessWindows] Choose a register context file by prepocessor

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D65409#1606619 , @tatyana-krasnukha wrote: > I wonder if directories `x86` and `x64` are needed. Should I remove them to > make hierarchy consisten

[Lldb-commits] [PATCH] D65450: Add llvm-style RTTI to ObjectFile hierarchy

xiaobai accepted this revision. xiaobai added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65450/new/ https://reviews.llvm.org/D65450 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] r367338 - [Reproducers] Fix incorrect help message

Author: jdevlieghere Date: Tue Jul 30 11:06:38 2019 New Revision: 367338 URL: http://llvm.org/viewvc/llvm-project?rev=367338&view=rev Log: [Reproducers] Fix incorrect help message The help message mentioned the `log` command (probably because I copied it from there originally). Modified: lld

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, jasonmolenda. JDevlieghere added a project: LLDB. Herald added a subscriber: mgorny. The bugreport command exists to create domain-specific bug reports. Currently it has one implementation for filing bugs on the unwinder.

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

davide added a comment. I wanted to remove it a while ago, but Jason told me he found this useful, so I would wait for his opinion. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65469/new/ https://reviews.llvm.org/D65469

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

davide added a comment. Other than that, I have no objections. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65469/new/ https://reviews.llvm.org/D65469 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

shafik added a comment. @stella.stamenova that is unfortunate but not surprising. I don't have a way to test a fix locally. Is there anyone who might be able to help me iterate over a fix or maybe a new maintainer of the PDB parsing? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/

[Lldb-commits] [lldb] r367358 - [SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module

Author: xiaobai Date: Tue Jul 30 14:22:17 2019 New Revision: 367358 URL: http://llvm.org/viewvc/llvm-project?rev=367358&view=rev Log: [SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module As of svn rL367298, SymbolFileDWARF locks the module in many cases where it needs to parse some

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade added a comment. Oh, sorry about that. I was relying on `ninja check`, which runs okay for me. > ninja check [0/1] Running the LLVM regression tests Testing Time: 583.96s Expected Passes: 32141 Expected Failures : 147 Unsupported Tests : 438 How can I invoke th

[Lldb-commits] [lldb] r367360 - [Symbol] Use llvm::Expected when getting TypeSystems

Author: xiaobai Date: Tue Jul 30 15:12:34 2019 New Revision: 367360 URL: http://llvm.org/viewvc/llvm-project?rev=367360&view=rev Log: [Symbol] Use llvm::Expected when getting TypeSystems Summary: This commit achieves the following: - Functions used to return a `TypeSystem *` return an `llvm::Ex

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

This revision was automatically updated to reflect the committed changes. Closed by commit rL367360: [Symbol] Use llvm::Expected when getting TypeSystems (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[Lldb-commits] [PATCH] D65482: [DAGCombiner] Add an option to control whether or not to enable store merging

wmi created this revision. wmi added a reviewer: tejohnson. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add an option to control whether or not to enable store merging in dag combiner so we can workaround some bug more easily. Repository: rLLDB LLDB https://reviews

[Lldb-commits] [PATCH] D65482: [DAGCombiner] Add an option to control whether or not to enable store merging

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65482/new/ https://reviews.llvm.org/D65482 ___ lldb-c

[Lldb-commits] [lldb] r367363 - [TableGen] Reuse typedef across emitters (NFC)

Author: jdevlieghere Date: Tue Jul 30 15:50:37 2019 New Revision: 367363 URL: http://llvm.org/viewvc/llvm-project?rev=367363&view=rev Log: [TableGen] Reuse typedef across emitters (NFC) This moves the std::map typedef into the header so it can be reused by all the emitter implementations. Modifi

[Lldb-commits] [PATCH] D65482: [DAGCombiner] Add an option to control whether or not to enable store merging

This revision was automatically updated to reflect the committed changes. Closed by commit rL367365: [DAGCombiner] Add an option to control whether or not to enable store merging. (authored by wmi, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [lldb] r367368 - [SymbolFilePDB] Fix windows bots after rL367360

Author: xiaobai Date: Tue Jul 30 16:48:03 2019 New Revision: 367368 URL: http://llvm.org/viewvc/llvm-project?rev=367368&view=rev Log: [SymbolFilePDB] Fix windows bots after rL367360 SymbolFilePDB tests were using GetTypeSystemForLanguage but weren't changed to accomodate the use of an llvm::Expec

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

JDevlieghere created this revision. JDevlieghere added a reviewer: teemperor. JDevlieghere added a project: LLDB. Herald added a subscriber: mgorny. Option enum value elements are used by both properties and options. They're another good canidate for tablegen'ing. Repository: rLLDB LLDB http

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith marked 2 inline comments as done. asmith added a comment. I don't see anything else to address in this review. Comments? Comment at: lldb/source/Plugins/Process/Utility/RegisterContextWindows_x86_64.cpp:141 +GetRegisterInfo_WoW64(const lldb_private::ArchSpec &arch) { +

[Lldb-commits] [lldb] r367375 - [TableGen] Include vector

Author: jdevlieghere Date: Tue Jul 30 17:20:55 2019 New Revision: 367375 URL: http://llvm.org/viewvc/llvm-project?rev=367375&view=rev Log: [TableGen] Include vector Fixes "no member named 'vector' in namespace 'std'" compile error. Modified: lldb/trunk/utils/TableGen/LLDBTableGenBackends.h

[Lldb-commits] [PATCH] D65492: Adjust a ValueObjectChild's offset when the child is a bitfield

aprantl created this revision. aprantl added reviewers: jingham, jasonmolenda. Herald added a project: LLDB. If a bitfield doesn't fit into the child_byte_size'd window at child_byte_offset, move the window (= child_byte_offset) forward until it fits. This was not in the big-endian-derived DWARF

[Lldb-commits] [PATCH] D65493: Modernize atomic detection and usage

jfb created this revision. jfb added reviewers: rnk, Bigcheese, __simt__. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, kadircet, arphaman, dexonsmith, jkorous, hiraditya, mgorny. Herald added projects: clang, LLDB, LLVM. Some of the cmake checks are obsolete and make bootstr

[Lldb-commits] [PATCH] D65493: Modernize atomic detection and usage

jfb updated this revision to Diff 212479. jfb added a comment. - Remove from cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65493/new/ https://reviews.llvm.org/D65493 Files: clang-tools-extra/clangd/CMakeLists.txt lldb/source/Utility/CMak

[Lldb-commits] [lldb] r367377 - [TableGen] Move helpers into LLDBTableGenUtils.

Author: jdevlieghere Date: Tue Jul 30 17:47:00 2019 New Revision: 367377 URL: http://llvm.org/viewvc/llvm-project?rev=367377&view=rev Log: [TableGen] Move helpers into LLDBTableGenUtils. Instead of polluting the LLDBTableGenBackends header with helpers used by both emitters, move them into a sepa

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai updated this revision to Diff 212482. xiaobai added a comment. Update GetScatchTypeSystems to account for changes to TypeSystem usage CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64964/new/ https://reviews.llvm.org/D64964 Files: include/lldb/Target/Target.h source/API/SBTa

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai updated this revision to Diff 212483. xiaobai added a comment. Removed argument to GetScratchTypeSystems from SBTarget CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64964/new/ https://reviews.llvm.org/D64964 Files: include/lldb/Target/Target.h source/API/SBTarget.cpp sour

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64964/new/ https://reviews.llvm.org/D64964 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

JDevlieghere updated this revision to Diff 212485. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65489/new/ https://reviews.llvm.org/D65489 Files: lldb/include/lldb/Core/OptionEnumValueElementsBase.td lldb/source/Core/CMakeLists.txt lldb/sourc

[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

JosephTremoulet added a comment. @jasonmolenda @clayborg ping. To clarify, the issue this fixes is, using test functionalities/signal/handle-abrt as an example: #include #include #include void handler(int sig) { printf("Set a breakpoint here.\n"); exit(0); } v

[Lldb-commits] [lldb] r367384 - [StringList] Change LongestCommonPrefix API

Author: jdevlieghere Date: Tue Jul 30 20:26:10 2019 New Revision: 367384 URL: http://llvm.org/viewvc/llvm-project?rev=367384&view=rev Log: [StringList] Change LongestCommonPrefix API When investigating a completion bug I got confused by the API. LongestCommonPrefix finds the longest common prefix

[Lldb-commits] [lldb] r367385 - [CompletionRequest] Remove unimplemented members.

Author: jdevlieghere Date: Tue Jul 30 20:48:29 2019 New Revision: 367385 URL: http://llvm.org/viewvc/llvm-project?rev=367385&view=rev Log: [CompletionRequest] Remove unimplemented members. Completion requests have two fields that are essentially unimplemented: `m_match_start_point` and `m_max_ret

[Lldb-commits] [PATCH] D65498: Fix completion for functions in anonymous namespaces

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, jingham. JDevlieghere added a project: LLDB. Herald added subscribers: abidh, aprantl. I was going through some of the old bugs and came across PR21069 which I was able to reproduce. The issue is that we match th

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

labath added a comment. In D62931#1607221 , @guiandrade wrote: > Oh, sorry about that. I was relying on `ninja check`, which runs okay for me. > > > ninja check >[0/1] Running the LLVM regression tests >Testing Time: 583.96s > Expected Passe

[Lldb-commits] [PATCH] D65489: Tablegen option enum value elements

labath added a comment. Why do we need a separate backend for this? Couldn't this be emitted as a part of the same `#include "XXXProperties.inc"` which defines the property definition? The two logically belong together, and the only reason they were separate variables in the first place was the

[Lldb-commits] [PATCH] D65498: Fix completion for functions in anonymous namespaces

labath added a comment. I don't immediately see a better way to fix this, but I'm not terribly familiar with this machinery either. I guess one day we may want to extend the completion machinery to be able to expand "foo" into "(anonymous namespace)::foobar", but that's likely to be a larger un