[Lldb-commits] [PATCH] D64777: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I assume we never tested this and that's how didn't found this in sanitized builds? But this patch LGTM. Thanks Shafik! Comment at: packages/Python/lldbsuite/test/ex

[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. On my system clang-format has some complaints, so I think you need to rerun clang-format. Probably caused by the rebasing. I have some minor comments about the TestAST.py (see

[Lldb-commits] [lldb] r366196 - [lldb] Rename Options.inc to CommandOptions.inc [NFC]

Author: teemperor Date: Tue Jul 16 02:27:02 2019 New Revision: 366196 URL: http://llvm.org/viewvc/llvm-project?rev=366196&view=rev Log: [lldb] Rename Options.inc to CommandOptions.inc [NFC] It seems having two Options.inc files in the same project is giving our custom Xcode project a hard time. T

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

labath added a comment. Sorry for the delay. The patch looks fine to me. As far as testing goes, there's a "gdb-client" test suite in `test/testcases/functionalities/gdb_remote_client/`, which should allow you to mock gdb-server responses and verify that the right packets are being sent. ===

[Lldb-commits] [PATCH] D62570: [WIP] Use LLVM's debug line parser in LLDB

labath added inline comments. Comment at: lldb/include/lldb/Core/FileSpecList.h:191-192 + const_iterator end() const { return m_files.end(); } + const_iterator begin() { return m_files.begin(); } + const_iterator end() { return m_files.end(); } + If both of th

[Lldb-commits] [PATCH] D64767: [lldb][test_suite] Update tests with unexpected pass on Android aarch64

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Whether a lot of these tests (e.g. all watchpoint related tests) pass or fail may depend on the exact android device you are running the tests against. However, you are the only ones running a

[Lldb-commits] [PATCH] D64769: [lldb][test_suite] change the test main.cpp to avoid expression reschedule

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The change is fine, but for my own education, could you elaborate on what this "delayed calculation" is, and how does it make the test fail? Repository: rLLDB LLDB CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D64782: [SWIG] Deprecate SWIG 1.x

labath added a comment. In D64782#1586815 , @JDevlieghere wrote: > I've updated swig on GreenDragon, and the Windows bot is running 3.0. I'm not > sure about the Debian bot, as it's incremental it doesn't print the version > number. Regardless, I'll kee

[Lldb-commits] [PATCH] D64777: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory

labath added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/function_template_specialization_temp_args/main.cpp:1 +template +struct M {}; teemperor wrote: > JDevlieghere wrote: > > Clang format? > Pretty sure that file is clang-f

[Lldb-commits] [lldb] r366213 - [SWIG] Deprecate SWIG 1.x

Author: jdevlieghere Date: Tue Jul 16 08:14:01 2019 New Revision: 366213 URL: http://llvm.org/viewvc/llvm-project?rev=366213&view=rev Log: [SWIG] Deprecate SWIG 1.x The last swig 1.x release dates from 2009, now 10 years ago. Recently, I fixed an issue that prevented us from using swig 4 (r364974

[Lldb-commits] [PATCH] D64782: [SWIG] Deprecate SWIG 1.x

This revision was automatically updated to reflect the committed changes. Closed by commit rL366213: [SWIG] Deprecate SWIG 1.x (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D647

[Lldb-commits] [PATCH] D64777: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory

JDevlieghere added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/function_template_specialization_temp_args/main.cpp:1 +template +struct M {}; labath wrote: > teemperor wrote: > > JDevlieghere wrote: > > > Clang format? > > Pret

[Lldb-commits] [lldb] r366221 - Revert "[swig] Add workaround for old swig"

Author: jdevlieghere Date: Tue Jul 16 08:54:33 2019 New Revision: 366221 URL: http://llvm.org/viewvc/llvm-project?rev=366221&view=rev Log: Revert "[swig] Add workaround for old swig" With the deprecation of swig 1.x (r366213), this workaround should no longer be necessary. Modified: lldb/tru

[Lldb-commits] [PATCH] D64777: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory

labath added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/function_template_specialization_temp_args/main.cpp:1 +template +struct M {}; JDevlieghere wrote: > labath wrote: > > teemperor wrote: > > > JDevlieghere wrote: > > > >

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, JDevlieghere, davide, compnerd, friss, labath, mgorny, jasonmolenda. Herald added a project: LLDB. We can always build debugserver, but we can't always sign it to be useable for testing. `LLDB_USE_SYSTEM_DEBUGSERVER` should onl

[Lldb-commits] [PATCH] D64777: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory

shafik marked 5 inline comments as done. shafik added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/function_template_specialization_temp_args/main.cpp:1 +template +struct M {}; labath wrote: > JDevlieghere wrote: > > labath wro

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

sgraenitz updated this revision to Diff 210124. sgraenitz added a comment. Minor fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64806/new/ https://reviews.llvm.org/D64806 Files: lldb/CMakeLists.txt lldb/cmake/modules/AddLLDB.cmake lldb/

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

sgraenitz marked 3 inline comments as done. sgraenitz added inline comments. Comment at: lldb/CMakeLists.txt:94 - endif() - if(TARGET lldb-mi) The target will always exist now. The dependency would now depend on `LLDB_USE_SYSTEM_DEBUGSERVER` and set in `lldb

[Lldb-commits] [lldb] r366226 - [CMake] Add Apple-lldb-Xcode.cmake cache that avoids install options

Author: stefan.graenitz Date: Tue Jul 16 09:57:45 2019 New Revision: 366226 URL: http://llvm.org/viewvc/llvm-project?rev=366226&view=rev Log: [CMake] Add Apple-lldb-Xcode.cmake cache that avoids install options Added: lldb/trunk/cmake/caches/Apple-lldb-Xcode.cmake Added: lldb/trunk/cmake/cac

[Lldb-commits] [PATCH] D64536: Adding inline comments to code view type records

nilanjana_basu updated this revision to Diff 210123. nilanjana_basu added a comment. Corrected comments for codeview type record from "NumAttributes" to "AccessSpecifier" Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64536/new/ https://reviews.llvm.org/D64536 Fi

[Lldb-commits] [PATCH] D63813: Adjust variable formatting table

JDevlieghere added a comment. Lukas, do you have commit access or do you need one of us to land this for you? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63813/new/ https://reviews.llvm.org/D63813 ___ lldb-commit

[Lldb-commits] [PATCH] D64777: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory

teemperor added inline comments. Comment at: packages/Python/lldbsuite/test/expression_command/function_template_specialization_temp_args/main.cpp:1 +template +struct M {}; shafik wrote: > labath wrote: > > JDevlieghere wrote: > > > labath wrote: > > > > teempe

[Lldb-commits] [PATCH] D64769: [lldb][test_suite] change the test main.cpp to avoid expression reschedule

kusmour added a comment. In D64769#1587318 , @labath wrote: > The change is fine, but for my own education, could you elaborate on what > this "delayed calculation" is, and how does it make the test fail? The test set the breakpoint to the return statem

[Lldb-commits] [PATCH] D64767: [lldb][test_suite] Update tests with unexpected pass on Android aarch64

kusmour added a comment. In D64767#1587311 , @labath wrote: > Whether a lot of these tests (e.g. all watchpoint related tests) pass or fail > may depend on the exact android device you are running the tests against. > However, you are the only ones runni

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

JDevlieghere created this revision. JDevlieghere added reviewers: sgraenitz, labath, xiaobai. JDevlieghere added a project: LLDB. Herald added a subscriber: mgorny. Because of how CMake finds the Python libraries and interpreter, it's possible to end up with a discrepancy between the two. For exa

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. This definitely caused me some pain a few months ago. Thanks for adding this! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64812/new/ https://reviews.llvm

[Lldb-commits] [lldb] r366243 - [CMake] Fail when Python interpreter doesn't match Python libraries version

Author: jdevlieghere Date: Tue Jul 16 11:27:12 2019 New Revision: 366243 URL: http://llvm.org/viewvc/llvm-project?rev=366243&view=rev Log: [CMake] Fail when Python interpreter doesn't match Python libraries version Because of how CMake finds the Python libraries and interpreter, it's possible to

[Lldb-commits] [PATCH] D64536: Adding inline comments to code view type records

nilanjana_basu updated this revision to Diff 210142. nilanjana_basu added a comment. Added record kind name in the comments for better readability Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64536/new/ https://reviews.llvm.org/D64536 Files: llvm/include/llvm/

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

mgorny added a comment. Hmm, I've just looked through CMake docs, and I think a better solution might be: find_package(Python COMPONENTS Interpreter Development) Apparently using separate modules has been deprecated in 3.12, and using a single `FindPython` call guarantees version match. Of

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

This revision was automatically updated to reflect the committed changes. Closed by commit rL366243: [CMake] Fail when Python interpreter doesn't match Python libraries version (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Change

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

JDevlieghere added a comment. In D64812#1588030 , @mgorny wrote: > Hmm, I've just looked through CMake docs, and I think a better solution might > be: > > find_package(Python COMPONENTS Interpreter Development) > > > Apparently using separate modules ha

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

rnk added a comment. You broke my build. =/ I got this output: CMake Error at C:/src/llvm-project/lldb/cmake/modules/LLDBConfig.cmake:201 (message): Found incompatible Python interpreter (3.7.3) and Python libraries () I'll mess with it a bit I guess. Repository: rL LLVM CHANGES SINC

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

mgorny added a comment. In D64812#1588040 , @JDevlieghere wrote: > If that works in `3.4` I'm happy to go that way! FWICS it's been added in 3.12, so no. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64812/new/ https://

[Lldb-commits] [lldb] r366247 - Fix LLDB Windows build Python version logic after r366243

Author: rnk Date: Tue Jul 16 11:46:51 2019 New Revision: 366247 URL: http://llvm.org/viewvc/llvm-project?rev=366247&view=rev Log: Fix LLDB Windows build Python version logic after r366243 Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

rnk added a comment. In D64812#1588055 , @rnk wrote: > You broke my build. =/ I got this output: > > CMake Error at C:/src/llvm-project/lldb/cmake/modules/LLDBConfig.cmake:201 > (message): > Found incompatible Python interpreter (3.7.3) and Python l

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

mgorny added inline comments. Comment at: lldb/trunk/cmake/modules/LLDBConfig.cmake:197 +find_package(PythonInterp REQUIRED) +find_package(PythonLibs REQUIRED) + endif() As a small optimization, I think you can prepend major+minor version into `Python_A

Re: [Lldb-commits] [lldb] r361915 - build: only search for the needed python type

Doesn't this regress building with the VS generator? Was that already broken? It seems like this should've been sent to Zach, who added this logic, for review. On Tue, May 28, 2019 at 7:23 PM Saleem Abdulrasool via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Tue

[Lldb-commits] [lldb] r366261 - [Symbol] Remove unused fields from ClangASTContext

Author: xiaobai Date: Tue Jul 16 14:05:08 2019 New Revision: 366261 URL: http://llvm.org/viewvc/llvm-project?rev=366261&view=rev Log: [Symbol] Remove unused fields from ClangASTContext Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h Modified: lldb/trunk/include/lldb/Symbol/ClangAS

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Sorry yes, I should have marked this as approved. I don't have a linux machine handy so I haven't looked into the problem Jan reports with the change -- fwiw if you turn on unwind

[Lldb-commits] [PATCH] D64821: [CMake] Remove duplicated logic to find Python when doing a standalone build

JDevlieghere created this revision. JDevlieghere added a reviewer: sgraenitz. Herald added a subscriber: mgorny. Herald added a project: LLDB. I'm pretty sure there's no need to have this logic living in LLDBStandalone. We always go through `LLDBConfig.cmake` which has the canonical way to find t

[Lldb-commits] [PATCH] D64823: [CMake] Default LLDB_PATH_TO_LLVM_BUILD to LLVM_DIR

JDevlieghere created this revision. JDevlieghere added reviewers: sgraenitz, mgorny, xiaobai. Herald added a subscriber: abidh. Herald added a project: LLDB. When doing a standalone build, without setting `LLDB_PATH_TO_LLVM_BUILD` or `LLDB_PATH_TO_CLANG_BUILD`, you get the following error. CMa

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/trunk/cmake/modules/LLDBConfig.cmake:197 +find_package(PythonInterp REQUIRED) +find_package(PythonLibs REQUIRED) + endif() mgorny wrote: > As a small opti

[Lldb-commits] [PATCH] D64824: [CMake] Move standalone check so we don't have to reconfigure LLDB

JDevlieghere created this revision. JDevlieghere added reviewers: sgraenitz, mgorny, xiaobai. Herald added subscribers: teemperor, jfb. Herald added a project: LLDB. By moving the standalone check into the main CMake file, the whole file is ignored in a regular (non-standalone) build. This means

[Lldb-commits] [PATCH] D64821: [CMake] Remove duplicated logic to find Python when doing a standalone build

amccarth added a comment. Actually, right now I'm trying to figure out where the interpreter is found because cmake is finding different, incompatible versions of the interpreter (2.7) and the libs (3.6). On Windows, it looks like LLDBConfig.cmake doesn't explicitly look for the interpreter, o

[Lldb-commits] [PATCH] D64824: [CMake] Move standalone check so we don't have to reconfigure LLDB

amccarth added inline comments. Comment at: lldb/CMakeLists.txt:14 -include(LLDBStandalone) +# If we are not building as a part of LLVM, build LLDB as an +# standalone project, using LLVM as an external library: Nit: s/an/a/ Repository: rLLDB LLDB CHANGES

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

amccarth added a comment. In D64812#1588061 , @rnk wrote: > In D64812#1588055 , @rnk wrote: > > > You broke my build. =/ I got this output: > > > > CMake Error at > > C:/src/llvm-project/lldb/cmake/modules/LLDBCo

[Lldb-commits] [PATCH] D64777: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory

shafik updated this revision to Diff 210127. shafik added a comment. Applying clang-format to test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64777/new/ https://reviews.llvm.org/D64777 Files: packages/Python/lldbsuite/test/expression_command/function_template_specialization_temp_

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

amccarth added a comment. OK, the only way I was able to make this work was to remove all traces of Python 2.x from my machine. As long as the older Python existed on my machine CMake would find that one, regardless of which one was in my PATH or indicated by PYTHON_HOME_DIR. Of course, it re

[Lldb-commits] [PATCH] D62570: Use LLVM's debug line parser in LLDB

JDevlieghere updated this revision to Diff 210222. JDevlieghere marked 3 inline comments as done. JDevlieghere retitled this revision from "[WIP] Use LLVM's debug line parser in LLDB" to "Use LLVM's debug line parser in LLDB". JDevlieghere added a comment. - Address code review feedback - Fix sup

[Lldb-commits] [PATCH] D64821: [CMake] Remove duplicated logic to find Python when doing a standalone build

JDevlieghere added a comment. In D64821#1588424 , @amccarth wrote: > Actually, right now I'm trying to figure out where the interpreter is found > because cmake is finding different, incompatible versions of the interpreter > (2.7) and the libs (3.6). >

[Lldb-commits] [PATCH] D64821: [CMake] Remove duplicated logic to find Python when doing a standalone build

JDevlieghere added a comment. Indeed, the culprit appears to be https://github.com/llvm/llvm-project/blob/master/llvm/CMakeLists.txt#L645, which prefer Python 3 over Python 2. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64821/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D62570: Use LLVM's debug line parser in LLDB

clayborg added a comment. So in the actual line table parsing code it seems like we are creating a line table in LLVM format, complete with sequences and a bunch of LLVM data structures, and then copying the results over into LLDB and then throwing away the LLVM line table. It would be nicer to

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai created this revision. xiaobai added reviewers: teemperor, shafik, jingham, JDevlieghere, aprantl. Herald added subscribers: arphaman, emaste. Target doesn't really need to know about ClangASTContext more than any other TypeSystem. We can create a method ClangASTContext::GetScratch for any

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai updated this revision to Diff 210229. xiaobai added a comment. Remove ClangASTContext header from Target.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64844/new/ https://reviews.llvm.org/D64844 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Target/Target.h

[Lldb-commits] [PATCH] D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version

mgorny added inline comments. Comment at: lldb/trunk/cmake/modules/LLDBConfig.cmake:197 +find_package(PythonInterp REQUIRED) +find_package(PythonLibs REQUIRED) + endif() JDevlieghere wrote: > mgorny wrote: > > As a small optimization, I think you can pre

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64844/new/ https://reviews.llvm.org/D64844 ___ lldb-commits mailing list lldb-c