labath added a comment. Sorry for the delay. The patch looks fine to me. As far as testing goes, there's a "gdb-client" test suite in `test/testcases/functionalities/gdb_remote_client/`, which should allow you to mock gdb-server responses and verify that the right packets are being sent.
================ Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:154 + ePropertyUseSVR4, + ePropertyUseGPacket }; ---------------- I'd add a trailing comma here to avoid changing this line next time we add a setting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/ https://reviews.llvm.org/D62931 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
