[Lldb-commits] [PATCH] D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups

labath added a comment. Thanks for the heads up. This should be fixed with r363653. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63268/new/ https://reviews.llvm.org/D63268 ___ lldb-commits mailing list lldb-commits@l

Re: [Lldb-commits] [PATCH] D63441: [zorg] Add lldb-arm-ubuntu builder

On Mon, 17 Jun 2019 at 22:30, Jan Kratochvil via Phabricator wrote: > > jankratochvil added a comment. > > > It ll run on staging master until tests become stable. > > BTW the silent master is now dead since 2019-06-13. I thought its down temporarily. Any idea if it is permanently dead? > > > CH

[Lldb-commits] [PATCH] D63441: [zorg] Add lldb-arm-ubuntu builder

This revision was automatically updated to reflect the committed changes. Closed by commit rL363659: [zorg] Add lldb-arm-ubuntu builder (authored by omjavaid, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

Re: [Lldb-commits] [PATCH] D63441: [zorg] Add lldb-arm-ubuntu builder

On Tue, 18 Jun 2019 12:17:52 +0200, Omair Javaid wrote: > On Mon, 17 Jun 2019 at 22:30, Jan Kratochvil via Phabricator > wrote: > > BTW the silent master is now dead since 2019-06-13. > > I thought its down temporarily. Any idea if it is permanently dead? sorry for the wording, I did not mean i

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

labath marked 7 inline comments as done. labath added a comment. I've been thinking about the DIERef class a lot while doing this, and the more I thought about it, the more I became convinced that forcing everything to go through DIERefs is not a good idea. It is kind of useful to have it as a s

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

labath updated this revision to Diff 205319. labath marked 2 inline comments as done. labath added a comment. - use the existing function for DWARFDIE->DIERef conversion - fix a bug where we were ignoring the dwo_num and section fields when searching for all entries in a given unit. Technically,

[Lldb-commits] [PATCH] D63491: DWARF: Use a more compact internal representation in the manual dwarf index

labath created this revision. labath added reviewers: clayborg, JDevlieghere, aprantl. Herald added a subscriber: arphaman. labath added a parent revision: D63428: DWARF: Add "dwo_num" field to the DIERef class. Reduce the size of the manual index by storing the entries in a more compact form. Th

[Lldb-commits] [PATCH] D63491: DWARF: Use a more compact internal representation in the manual dwarf index

labath added a comment. I made this depend on the DIERef patch instead of the other way around because the cleaner separation between dwo identifiers and compile unit offsets implemented in that patch makes it easier to implement this. It would still be possible to implement it the other way ar

[Lldb-commits] [PATCH] D63491: DWARF: Use a more compact internal representation in the manual dwarf index

clayborg added a comment. In D63491#1548238 , @labath wrote: > I made this depend on the DIERef patch instead of the other way around > because the cleaner separation between dwo identifiers and compile unit > offsets implemented in that patch makes it e

[Lldb-commits] [PATCH] D63491: DWARF: Use a more compact internal representation in the manual dwarf index

labath abandoned this revision. labath added a comment. Ok, sounds good. In that case, I think I can squeeze that change into the previous patch in this series. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63491/new/ https://reviews.llvm.org/D63491 _

[Lldb-commits] [PATCH] D63491: DWARF: Use a more compact internal representation in the manual dwarf index

clayborg added a comment. In D63491#1548400 , @labath wrote: > Ok, sounds good. In that case, I think I can squeeze that change into the > previous patch in this series. That will be great, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

stella.stamenova added a comment. This test is extremely flaky on Windows - it looks like it passes on the bot less than 10% of the time: http://lab.llvm.org:8011/buildslaves/win-py3-buildbot. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63110/new/ https://revi

[Lldb-commits] [PATCH] D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups

stella.stamenova added a comment. Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63268/new/ https://reviews.llvm.org/D63268 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] r363697 - [Reproducers] Make reproducer relocatable

Author: jdevlieghere Date: Tue Jun 18 09:20:17 2019 New Revision: 363697 URL: http://llvm.org/viewvc/llvm-project?rev=363697&view=rev Log: [Reproducers] Make reproducer relocatable Before this patch, reproducers weren't relocatable. The reproducer contained hard coded paths in the VFS mapping, as

[Lldb-commits] [PATCH] D63467: [Reproducers] Make reproducer relocatable

This revision was automatically updated to reflect the committed changes. Closed by commit rL363697: [Reproducers] Make reproducer relocatable (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 205390. kusmour added a comment. the OS check in SysV x64 ABI broke the test `SymbolFile/DWARF/debug_loc.s` added a restriction `lld` to `#REQUIRES` Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62213/new/ https://reviews.l

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

This revision was automatically updated to reflect the committed changes. Closed by commit rL363707: Implement xfer:libraries-svr4:read packet (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

labath added a comment. In D62213#1548788 , @kusmour wrote: > the OS check in SysV x64 ABI broke the test `SymbolFile/DWARF/debug_loc.s` Can you elaborate on that? How exactly did it break this test? > added a restriction `lld` to `#REQUIRES` That defi

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

siedentop added a comment. @sgraenitz I cannot merge the changes myself, could you please commit them for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63370/new/ https://reviews.llvm.org/D63370 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour added a comment. @labath Hi, you're right about the `lld`, it didn't make the test pass, instead it became unsupported. In D62213#1548835 , @labath wrote: > Can you elaborate on that? How exactly did it break this test? So the problem here is t

Re: [Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

> On Jun 7, 2019, at 2:47 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath planned changes to this revision. > labath added a comment. > > It looks like this problem is more widespread than we originally thought (a > bunch of other tests are affected too). I'll need to t

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

This revision was automatically updated to reflect the committed changes. Closed by commit rL363750: Add ReadCStringFromMemory for faster string reads (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[Lldb-commits] [PATCH] D63530: [swig] Define attribute(ref) instead of accessing swig internals.

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: LLDB. As of SWIG 4.0, `__swig_getmethods__` and `__swig_setmethods__` are no longer defined. The solution is to stop using these internal swig dictionaries and use `%attribute` and `%attributeref` in

[Lldb-commits] [PATCH] D63530: [swig] Define attribute(ref) instead of accessing swig internals.

JDevlieghere updated this revision to Diff 205474. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63530/new/ https://reviews.llvm.org/D63530 Files: lldb/scripts/interface/SBAddress.i lldb/scripts/interface/SBBlock.i Index: lldb/scripts/interface/SBBlock.i

[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

jingham added a comment. In D63181#1539292 , @xiaobai wrote: > In D63181#1539291 , @JDevlieghere > wrote: > > > Have you considered making just `AddExceptionPrecondition` virtual? > > Wouldn't that solve the probl

[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

jingham added a comment. This looks fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63181/new/ https://reviews.llvm.org/D63181 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D63530: [swig] Define attribute(ref) instead of accessing swig internals.

JDevlieghere updated this revision to Diff 205479. JDevlieghere added a comment. Add more classes and keep documentation on properties. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63530/new/ https://reviews.llvm.org/D63530 Files: lldb/scripts/interface/SBAddress.i lldb/scripts/in

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

jingham added a comment. In D63363#1545427 , @labath wrote: > Although this is technically correct and pretty consistent with our other > "plugins", I can't help but feel that it's incredibly wasteful. Each of the > XXXSignals.cpp files is less than a 10

[Lldb-commits] [PATCH] D63530: [swig] Define attribute(ref) instead of accessing swig internals.

JDevlieghere updated this revision to Diff 205483. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63530/new/ https://reviews.llvm.org/D63530 Files: lldb/scripts/interface/SBAddress.i lldb/scripts/interface/SBBlock.i lldb/scripts/interface/SBBreakpoint.i lldb/scripts/interface/SBCo

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

labath added a comment. In D62213#1549190 , @kusmour wrote: > > Maybe we should make the SysV abi plugin match unknown oss too... > > I'm not sure this is the right thing to do, but this should fix the problem. It would at least preserve status quo. Not

[Lldb-commits] [PATCH] D63530: [swig] Define attribute(ref) instead of accessing swig internals.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I'm not terribly familiar with this, but it definitely looks like a more idiomatic way to do these things. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63530/new/ https://reviews.ll