clayborg added a comment. In D63491#1548238 <https://reviews.llvm.org/D63491#1548238>, @labath wrote:
> I made this depend on the DIERef patch instead of the other way around > because the cleaner separation between dwo identifiers and compile unit > offsets implemented in that patch makes it easier to implement this. It would > still be possible to implement it the other way around, but the logic would > be more complex, and it would have to be redone anyway once the DIERef patch > lands. > > Another possibility would be to just remove the unit_offset field from the > DIERef class, and have the manual index keep using DIERefs. Once we introduce > the dwo identifier, the unit offset is strictly optional, as the unit is > uniquely identified by the other coordinates. Lets just fix the DIERef class and remove the unit_offset field? No need for yet another minimal DIE reference class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63491/new/ https://reviews.llvm.org/D63491 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
