[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:2122 + size_t phdr_num_entries = *maybe_phdr_num_entries; + lldb::addr_t load_base = phdr_addr - sizeof(ELF_EHDR); + aadsm wrote: > labath wrote: > > This innocen

[Lldb-commits] [lldb] r362586 - Ignore DIEs in the skeleton unit in a DWO scenario

Author: labath Date: Wed Jun 5 00:29:55 2019 New Revision: 362586 URL: http://llvm.org/viewvc/llvm-project?rev=362586&view=rev Log: Ignore DIEs in the skeleton unit in a DWO scenario Summary: r362103 exposed a bug, where we could read incorrect data if a skeleton unit contained more than the sin

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

This revision was automatically updated to reflect the committed changes. Closed by commit rL362586: Ignore DIEs in the skeleton unit in a DWO scenario (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [PATCH] D62878: [CMake] Export CMAKE_CONFIGURATION_TYPES for the LLVM build-tree

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362588: [CMake] Export CMAKE_CONFIGURATION_TYPES for the LLVM build-tree (authored by stefan.graenitz, committed by ). Ch

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rL362589: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm… (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Ch

[Lldb-commits] [lldb] r362589 - [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

Author: stefan.graenitz Date: Wed Jun 5 01:31:50 2019 New Revision: 362589 URL: http://llvm.org/viewvc/llvm-project?rev=362589&view=rev Log: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds Summary: If the provided LLVM build-tree used a mu

Re: [Lldb-commits] [PATCH] D62505: Fix multiple module loaded with the same UUID

The "overlapping sections" thread reminding me I should reply here.. It also reminded me of another possible use case for multiply-mapped sections. Thread-local sections (.tbss, .tdata in elf) contain data which is somehow (the exact mechanisms are still quite opaque to me) mapped memory for ea

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

sgraenitz updated this revision to Diff 203106. sgraenitz added a comment. Remove Xcode restriction and polish Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62859/new/ https://reviews.llvm.org/D62859 Files: lldb/lit/CMakeLists.txt lldb/utils/l

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

sgraenitz marked 2 inline comments as done. sgraenitz added inline comments. Comment at: lldb/lit/CMakeLists.txt:7 +if(LLDB_BUILT_STANDALONE) + foreach(config_type ${CMAKE_CONFIGURATION_TYPES}) +# In paths to our build-tree, replace CMAKE_CFG_INTDIR with our actual configur

[Lldb-commits] [PATCH] D62894: DWARF: Share line tables of type units

labath created this revision. labath added reviewers: clayborg, aprantl, JDevlieghere. Herald added a subscriber: jdoerfert. This patch creates a cache of file lists in line tables referenced by type units. This cache is used to avoid parsing a line table twice (since a file list will generally b

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

sgraenitz updated this revision to Diff 203118. sgraenitz added a comment. Unfortunately lit is a little more complicated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62859/new/ https://reviews.llvm.org/D62859 Files: lldb/lit/CMakeLists.txt l

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

sgraenitz updated this revision to Diff 203121. sgraenitz added a comment. Polishing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62859/new/ https://reviews.llvm.org/D62859 Files: lldb/lit/CMakeLists.txt lldb/utils/lldb-dotest/CMakeLists.txt

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

sgraenitz added a comment. `./Debug/bin/lldb-dotest` now failing with: OSError: [Errno 2] No such file or directory Config=x86_64-/path/to/lldb-dev-deps-relwithdebinfo/bin/clang-9 Investigating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D628

[Lldb-commits] [PATCH] D62168: [DynamicLoader] Make sure we always set the rendezvous breakpoint

This revision was automatically updated to reflect the committed changes. Closed by commit rL362619: [DynamicLoader] Make sure we always set the rendezvous breakpoint (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

aadsm added a comment. > Another advantage of having this in an abstract class is that you could test > this in isolation, as NativeProcessProtocol is already setup to mock memory > accesses: > https://github.com/llvm-mirror/lldb/blob/master/unittests/Host/NativeProcessProtocolTest.cpp. I migh

[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

labath added a comment. In D62501#1531202 , @aadsm wrote: > > Another advantage of having this in an abstract class is that you could > > test this in isolation, as NativeProcessProtocol is already setup to mock > > memory accesses: > > https://github.c

Re: [Lldb-commits] [lldb] r362570 - Fix -Wsign-compare by explicit cast after r362557

abs(offset) is not the same as addr_t(-offset) AFAICT offset is positive so we are casting a small negative number to an unsigned type which will result in a really large value e.g. https://godbolt.org/z/B2Z7Ok > On Jun 4, 2019, at 6:49 PM, Fangrui Song via lldb-commits > wrote: > > Author: m

[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

aadsm added a comment. > I haven't given this much thought, but it may be possible to reuse the stuff > in MockProcess by making it a template (so you'd have a > MockProcess, and a MockProcess) Ah interesting, will explore that instead. I was actually thinking if it would be possible to extrac

Re: [Lldb-commits] [lldb] r362570 - Fix -Wsign-compare by explicit cast after r362557

On 05/06/2019 21:23, Shafik Yaghmour via lldb-commits wrote: abs(offset) is not the same as addr_t(-offset) It is, if you assume that offset is negative, which is what this code is doing: if (offset < 0 && addr_t(-offset) > current_func_text_offset) So, we will only ever convert -offset i

Re: [Lldb-commits] [lldb] r362570 - Fix -Wsign-compare by explicit cast after r362557

Apologies, I somehow missed the offset < 0. > On Jun 5, 2019, at 12:38 PM, Pavel Labath wrote: > > On 05/06/2019 21:23, Shafik Yaghmour via lldb-commits wrote: >> abs(offset) is not the same as addr_t(-offset) > > It is, if you assume that offset is negative, which is what this code is > doing

[Lldb-commits] [PATCH] D62499: Create a generic handler for Xfer packets

aadsm updated this revision to Diff 203235. aadsm marked an inline comment as done. aadsm added a comment. Address final 2 comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62499/new/ https://reviews.llvm.org/D62499 Files: lldb/include/lldb

[Lldb-commits] [lldb] r362639 - [NativeProcessDarwin] Remove dead code. NFCI.

Author: davide Date: Wed Jun 5 13:23:03 2019 New Revision: 362639 URL: http://llvm.org/viewvc/llvm-project?rev=362639&view=rev Log: [NativeProcessDarwin] Remove dead code. NFCI. Modified: lldb/trunk/source/Plugins/Process/Darwin/NativeProcessDarwin.cpp Modified: lldb/trunk/source/Plugins/Pr

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade created this revision. guiandrade added a reviewer: labath. guiandrade added projects: LLDB, LLVM. Herald added a subscriber: lldb-commits. Following up on https://reviews.llvm.org/D62221 , this change introduces the setting plugin.process.gdb-remote.tr

[Lldb-commits] [PATCH] D62934: [LanguageRuntime] Introdce LLVM-style casts

xiaobai created this revision. xiaobai added reviewers: labath, JDevlieghere. Herald added a subscriber: arphaman. Using llvm-style rtti gives us stronger guarantees around casting LanguageRuntimes. As discussed in D62755 https://reviews.llvm.org/D62934 Files:

[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

aadsm added a comment. @labath while working on this I had to also move the GetAuxValue function into the NativeProcessELF, which I think it's fine. However, this means this class now depends on the AuxValue class defined in the PluginUtility. Initially I was going to put the NativeProcessELF i

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

labath added reviewers: clayborg, jasonmolenda. labath added a comment. Personally, I'm wondering whether we even need a setting for this. Running the speed test command locally (i.e. the lowest latency we can possibly get), I get results like: (lldb) process plugin packet speed-test --count

[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

labath added a comment. In D62501#1531959 , @aadsm wrote: > @labath while working on this I had to also move the GetAuxValue function > into the NativeProcessELF, which I think it's fine. However, this means this > class now depends on the AuxValue class