Apologies, I somehow missed the offset < 0. > On Jun 5, 2019, at 12:38 PM, Pavel Labath <pa...@labath.sk> wrote: > > On 05/06/2019 21:23, Shafik Yaghmour via lldb-commits wrote: >> abs(offset) is not the same as addr_t(-offset) > > It is, if you assume that offset is negative, which is what this code is > doing: > >>> if (offset < 0 && addr_t(-offset) > current_func_text_offset) > > So, we will only ever convert -offset into an addr_t if offset is negative > (i.e. -offset is positive).
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
