[Lldb-commits] [lldb] r351731 - Fix typos throughout the license files that somehow I and my reviewers

Author: chandlerc Date: Mon Jan 21 01:52:34 2019 New Revision: 351731 URL: http://llvm.org/viewvc/llvm-project?rev=351731&view=rev Log: Fix typos throughout the license files that somehow I and my reviewers all missed! Thanks to Alex Bradbury for pointing this out, and the fact that I never added

[Lldb-commits] [PATCH] D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication

teemperor created this revision. teemperor added reviewers: LLDB, jasonmolenda. Herald added subscribers: lldb-commits, mgorny. The field `m_decompression_scratch_type` is only used when `HAVE_LIBCOMPRESSION` is defined, which caused a warning which I fixed in rLLDB350675

[Lldb-commits] [PATCH] D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication

teemperor added a comment. I currently don't have access to a macOS machine and this only affects macOS, so I would appreciate if someone could check if this still compiles/works as intended. Otherwise I can also just commit it and watch the macOS bots. Repository: rLLDB LLDB CHANGES SINCE

[Lldb-commits] [PATCH] D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication

labath added subscribers: beanz, labath. labath added a reviewer: sgraenitz. labath added inline comments. Comment at: include/lldb/Host/Config.h.cmake:32-40 #ifndef HAVE_LIBCOMPRESSION #cmakedefine HAVE_LIBCOMPRESSION #endif +#ifndef HAVE_LIBCOMPRESSION +#ifdef __APPLE__ +#

[Lldb-commits] [PATCH] D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: include/lldb/Host/Config.h.cmake:32-40 #ifndef HAVE_LIBCOMPRESSION #cmakedefine HAVE_LIBCOMPRESSION #endif +#ifndef HAVE_LIBCOMPRESSION +#ifdef __APPLE__ +#define HAVE_LIBCOMPRESSION ---

[Lldb-commits] [PATCH] D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication

labath added inline comments. Comment at: include/lldb/Host/Config.h.cmake:32-40 #ifndef HAVE_LIBCOMPRESSION #cmakedefine HAVE_LIBCOMPRESSION #endif +#ifndef HAVE_LIBCOMPRESSION +#ifdef __APPLE__ +#define HAVE_LIBCOMPRESSION teemperor wrote: > labath wrote:

[Lldb-commits] [PATCH] D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication

teemperor updated this revision to Diff 182797. teemperor added a comment. - Moved define to Xcode's Config.h (Thanks Pavel!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57011/new/ https://reviews.llvm.org/D57011 Files: include/lldb/Host/Config.h source/Plugins/Process/gdb-remote

[Lldb-commits] [PATCH] D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks much better. Thanks. (I haven't tested on a mac, but it doesn't seem like a particularly dangerous change to make). Maybe, if this sticks, https://reviews.llvm.org/D48977 could be

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

labath added inline comments. Comment at: include/lldb/Utility/Args.h:121 + bool GetFlattenWindowsCommandString(std::string &command) const; + I am sorry for being such a pain, but I don't think this is grammatically correct, as `get` and `flatten` are both v

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added a comment. Why `lldb_private::Flags` is required? `std::bitset` provides the same functionality and even more. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 _

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

Hui added inline comments. Comment at: include/lldb/Utility/Args.h:121 + bool GetFlattenWindowsCommandString(std::string &command) const; + labath wrote: > I am sorry for being such a pain, but I don't think this is grammatically > correct, as `get` and `flat

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added inline comments. Comment at: source/Plugins/Architecture/Arc/ArchitectureArc.cpp:29 + PluginManager::RegisterPlugin(GetPluginNameStatic(), +"ARC-specific algorithms", +&ArchitectureArc::Creat

[Lldb-commits] [PATCH] D56844: Breakpad: Extract parsing code into a separate file

labath marked 7 inline comments as done. labath added a comment. Thanks for the review. I'll create another review with the changes stemming from this. Comment at: lldb/trunk/source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:74 + static_assert(sizeof(data) == 20, ""); +

[Lldb-commits] [PATCH] D57037: BreakpadRecords: Address post-commit feedback

labath created this revision. labath added a reviewer: lemo. This addresses the issues raised in D56844 . It removes the accessors from the breakpad record structures by making the fields public. Also, I refactor the UUID parsing code to remove hard-coded constant

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

labath added inline comments. Comment at: include/lldb/Utility/Args.h:121 + bool GetFlattenWindowsCommandString(std::string &command) const; + Hui wrote: > labath wrote: > > I am sorry for being such a pain, but I don't think this is grammatically > > correct

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

labath added inline comments. Comment at: include/lldb/Utility/Args.h:121 + bool GetFlattenWindowsCommandString(std::string &command) const; + labath wrote: > Hui wrote: > > labath wrote: > > > I am sorry for being such a pain, but I don't think this is gramma

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

Hui added inline comments. Comment at: include/lldb/Utility/Args.h:121 + bool GetFlattenWindowsCommandString(std::string &command) const; + labath wrote: > labath wrote: > > Hui wrote: > > > labath wrote: > > > > I am sorry for being such a pain, but I don't t

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

labath added inline comments. Comment at: include/lldb/Utility/Args.h:121 + bool GetFlattenWindowsCommandString(std::string &command) const; + Hui wrote: > labath wrote: > > labath wrote: > > > Hui wrote: > > > > labath wrote: > > > > > I am sorry for being su

[Lldb-commits] [lldb] r351779 - [Test] Fix up tests affected by the new LLVM header.

Author: jdevlieghere Date: Mon Jan 21 19:50:44 2019 New Revision: 351779 URL: http://llvm.org/viewvc/llvm-project?rev=351779&view=rev Log: [Test] Fix up tests affected by the new LLVM header. The new LLVM header is one line shorter than the old one, which lead to some test failures. Ideally tests

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

Hui added inline comments. Comment at: include/lldb/Utility/Args.h:121 + bool GetFlattenWindowsCommandString(std::string &command) const; + labath wrote: > Hui wrote: > > labath wrote: > > > labath wrote: > > > > Hui wrote: > > > > > labath wrote: > > > > > >

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

labath added inline comments. Comment at: include/lldb/Utility/Args.h:121 + bool GetFlattenWindowsCommandString(std::string &command) const; + Hui wrote: > labath wrote: > > Hui wrote: > > > labath wrote: > > > > labath wrote: > > > > > Hui wrote: > > > > > >

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

Hui added inline comments. Comment at: include/lldb/Utility/Args.h:121 + bool GetFlattenWindowsCommandString(std::string &command) const; + labath wrote: > Hui wrote: > > labath wrote: > > > Hui wrote: > > > > labath wrote: > > > > > labath wrote: > > > > > >

[Lldb-commits] [PATCH] D56590: breakpad: Add FUNC records to the symtab

This revision was automatically updated to reflect the committed changes. Closed by commit rL351781: breakpad: Add FUNC records to the symtab (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] r351781 - breakpad: Add FUNC records to the symtab

Author: labath Date: Mon Jan 21 20:56:31 2019 New Revision: 351781 URL: http://llvm.org/viewvc/llvm-project?rev=351781&view=rev Log: breakpad: Add FUNC records to the symtab This patch extends SymbolFileBreakpad::AddSymbols to include the symbols from the FUNC records too. These symbols come from

[Lldb-commits] [PATCH] D57037: BreakpadRecords: Address post-commit feedback

labath updated this revision to Diff 182847. labath added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57037/new/ https://reviews.llvm.org/D57037 Files: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp source/Plugins/ObjectFile/Breakpad/BreakpadRecords.h

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

Hui added a comment. In D56230#1361746 , @Hui wrote: > It could be the llvm::sys::flattenWindowsCommandLine issue to flatten the > command “dir c:\" for Windows Command Terminal. > However it is not an issue for PS or MingGW. > > It is observed the flatt

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 182848. tatyana-krasnukha added a comment. Keep trying to hide the processor's specifics from the ProcessGDBRemote Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 Files: