labath added a comment.
It's not fully clear to me from the previous comments if you are proceeding
with this or not, but in case you are, I have made comments inline. I see that
you've added some lit tests, but I also think you it would be good add some
unit tests for the name parser functiona
aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
https://reviews.llvm.org/D53951
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
Author: aleksandr.urakov
Date: Thu Nov 1 01:54:38 2018
New Revision: 345815
URL: http://llvm.org/viewvc/llvm-project?rev=345815&view=rev
Log:
[Windows] A basic implementation of memory allocations in a debuggee process
Summary:
This patch adds a basic implementation of `DoAllocateMemory` and
`Do
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345815: [Windows] A basic implementation of memory
allocations in a debuggee process (authored by aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
http
aleksandr.urakov marked 2 inline comments as done.
aleksandr.urakov added a comment.
Thank you for comments! I've updated the patch.
https://reviews.llvm.org/D52461
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
aleksandr.urakov updated this revision to Diff 172101.
https://reviews.llvm.org/D52461
Files:
lit/SymbolFile/PDB/Inputs/AstRestoreTest.cpp
lit/SymbolFile/PDB/ast-restore.test
source/Plugins/Language/CPlusPlus/CMakeLists.txt
source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
source/
aleksandr.urakov updated this revision to Diff 172102.
https://reviews.llvm.org/D52461
Files:
lit/SymbolFile/PDB/Inputs/AstRestoreTest.cpp
lit/SymbolFile/PDB/ast-restore.test
source/Plugins/Language/CPlusPlus/CMakeLists.txt
source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
source/
aleksandr.urakov added a comment.
Ping! Can you look at this, please?
https://reviews.llvm.org/D53368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
grimar updated this revision to Diff 172121.
grimar added a comment.
- Addressed review comments.
https://reviews.llvm.org/D53929
Files:
lit/Breakpoint/Inputs/debug_rnglistx_rlex.yaml
lit/Breakpoint/debug_rnglistx_rlex.test
source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
source/
grimar added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1072-1079
+ if (at_ranges_val != DW_INVALID_OFFSET) {
+if (DWARFDebugRangesBase *debug_ranges = dwarf2Data->DebugRanges()) {
+
+ dw_offset_t debug_ranges_offset;
+ if
Author: jdevlieghere
Date: Thu Nov 1 08:47:33 2018
New Revision: 345843
URL: http://llvm.org/viewvc/llvm-project?rev=345843&view=rev
Log:
[FileSystem] Remove GetPermissions() and Readable() from FileSpec
This patch removes the GetPermissions and GetReadable methods from
FileSpec and updates its
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345843: [FileSystem] Remove GetPermissions() and Readable()
from FileSpec (authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
JDevlieghere updated this revision to Diff 172142.
https://reviews.llvm.org/D53834
Files:
include/lldb/Host/FileSystem.h
include/lldb/Utility/FileSpec.h
source/API/SBFileSpec.cpp
source/Host/common/FileSystem.cpp
source/Host/common/MonitoringProcessLauncher.cpp
source/Host/macosx/objc
JDevlieghere added a comment.
In https://reviews.llvm.org/D53834#1281822, @labath wrote:
> Why did you change the function name? I think it would be nice to keep
> "executable" or something to that effect in the name (e.g. the llvm function
> has "program"), given that the underlying function c
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
https://reviews.llvm.org/D53834
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: zturner
Date: Thu Nov 1 09:37:29 2018
New Revision: 345848
URL: http://llvm.org/viewvc/llvm-project?rev=345848&view=rev
Log:
[NativePDB] Get LLDB types from PDB function types.
This adds basic support for getting function signature types
into LLDB's type system, including into clang's AS
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345848: [NativePDB] Get LLDB types from PDB function types.
(authored by zturner, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53951?vs=172
Author: jdevlieghere
Date: Thu Nov 1 09:43:34 2018
New Revision: 345849
URL: http://llvm.org/viewvc/llvm-project?rev=345849&view=rev
Log:
[FileSystem] Improve assert and add Terminate in unit test.
Speculative fix for the Xcode bots where we were seeing the assertion
being triggered because we w
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Solution is fine. As long as we don't have to duplicate the work everywhere
that needs a ranges offset.
https://reviews.llvm.org/D53929
___
Author: jdevlieghere
Date: Thu Nov 1 10:09:22 2018
New Revision: 345853
URL: http://llvm.org/viewvc/llvm-project?rev=345853&view=rev
Log:
[FileSystem] Remove ResolveExecutableLocation() from FileSpec
This patch removes the ResolveExecutableLocation method from FileSpec
and updates its uses with
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345853: [FileSystem] Remove ResolveExecutableLocation()
from FileSpec (authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53834?vs=172142&id=172157#toc
Repo
Author: jdevlieghere
Date: Thu Nov 1 10:09:25 2018
New Revision: 345854
URL: http://llvm.org/viewvc/llvm-project?rev=345854&view=rev
Log:
[FileSystem] Remove Exists() from FileSpec
This patch removes the Exists method from FileSpec and updates its uses
with calls to the FileSystem.
Differential
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345854: [FileSystem] Remove Exists() from FileSpec
(authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53845?vs=171599&id=172158#toc
Repository:
rLLDB LLD
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345854: [FileSystem] Remove Exists() from FileSpec (authored
by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53845?vs=171599&
clayborg added a comment.
The only other thing you would need to change to get the usability back in
check when doing things in GetNumChildren() would be to have the function that
gets the typename take on optional execution context for dynamic types. The
ValueObject can easily pass its executi
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks for making the changes.
https://reviews.llvm.org/D53368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
Author: jdevlieghere
Date: Thu Nov 1 10:35:31 2018
New Revision: 345857
URL: http://llvm.org/viewvc/llvm-project?rev=345857&view=rev
Log:
[FileSystem] Fix Exists call sites
There were some calls left to Exists() on non-darwin platforms (Windows,
Linux and FreeBSD) that weren't yet updated to use
aprantl added a comment.
To me a VLA fulfills all properties of a dynamic type so not modeling it as a
dynamic type feels backwards to me. But not having to deal with temporary clang
types might be worth the trade-off.
> The only other thing you would need to change to get the usability back in
Author: jdevlieghere
Date: Thu Nov 1 10:46:31 2018
New Revision: 345860
URL: http://llvm.org/viewvc/llvm-project?rev=345860&view=rev
Log:
[FileSystem] Fix typo in ProcessFreeBSD
Modified:
lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
Modified: lldb/trunk/source/Plugins/Proces
aprantl added a comment.
> I didn't realize that the string int [] is produced by ValueObject itself; I
> think this makes this option more palatable to me. I'll give it a try.
So, it turns out it isn't. The only way to get the length into the typename is
to hack ClangASTContext::GetTypeName to
zturner created this revision.
zturner added a reviewer: jingham.
char16, char32, and wchar_t were previously broken. If you had a simple
variable like `wchar_t x = L'1'` and wrote `p x` LLDB would output `(wchar_t) x
= 1\0`. This is because it was using `eFormatChar` with a size of 2. What w
jingham added a comment.
There were a bunch of other tests testing wchar_t handling, all in:
lang/cpp/wchar_t
as well as some tests in:
functionalities/data-formatter/data-formatter-stl/libcxx/string/TestDataFormatterLibcxxString.py
Those tests weren't failed (except for the latter test, and t
zturner added a comment.
No, but thanks for the pointer. Interestingly, it worked for me on my home
machine but not on my work machine, and I'm not sure what the difference
between the two is.
Clearly the test in lang/cpp/wchar_t is making it into
`lldb_private::formatters::WCharSummaryProvid
zturner added a comment.
Update: It's because There was a problem with my `PYTHONPATH` and python was
getting disabled at CMake configure time. So I was effectively running with
`LLDB_DISABLE_PYTHON`. So basically it's only broke on the
`LLDB_DISABLE_PYTHON` codepath.
https://reviews.llvm.o
Author: rnk
Date: Thu Nov 1 12:54:45 2018
New Revision: 345882
URL: http://llvm.org/viewvc/llvm-project?rev=345882&view=rev
Log:
Fix clang -Wimplicit-fallthrough warnings across llvm, NFC
This patch should not introduce any behavior changes. It consists of
mostly one of two changes:
1. Replacing
jingham added a comment.
So the deal is that we were relying on a summary formatter to print wchar_t
before, and now you have a format option that handles them as well? Do we need
both? Maybe the summary also handles wchar_t * strings?
As an aside, for reasons that are not entirely clear to me
Author: jdevlieghere
Date: Thu Nov 1 14:18:25 2018
New Revision: 345891
URL: http://llvm.org/viewvc/llvm-project?rev=345891&view=rev
Log:
[FileSystem] Change FileSpec constructor signature.
Fix breakage due to the recent FileSpec change that extracts the path
resultion logic into FileSystem for
Author: jdevlieghere
Date: Thu Nov 1 14:26:58 2018
New Revision: 345895
URL: http://llvm.org/viewvc/llvm-project?rev=345895&view=rev
Log:
[FileSystem] Change FileSpec constructor signature (2/2)
Fix breakage due to the recent FileSpec change that extracts the path
resultion logic into FileSystem
zturner added a comment.
Side question, should we just kill the `LLDB_DISABLE_PYTHON=0` codepath? It
can be a headache to get LLDB linking with Python (particularly on Windows),
but it would be nice to be able to delete all the preprocessor stuff.
https://reviews.llvm.org/D53989
__
shafik created this revision.
shafik added reviewers: jingham, davide, teemperor.
Herald added a subscriber: JDevlieghere.
Refactor ClangASTContext::AddEnumerationValueToEnumerationType() to remove
redundant parameter which can be calculated from other parameter.
Both calling sites of the sites
jingham added a comment.
It doesn't seem unreasonable to want to build lldb for smaller systems that
don't have Python available, and in fact we do that internally at Apple.
Actually, it DOES seem a little unreasonable to me because after all you can
just run the debugserver/lldb-server and con
davide added inline comments.
Comment at:
packages/Python/lldbsuite/test/expression_command/radar_43822994/TestScopedEnumType.py:42
+## integral is not implicitly convertible to a scoped enum
+value = frame.EvaluateExpression("1 == Foo::FooBar")
+self.ass
jingham added a comment.
Note also, the vast majority of the uses of LLDB_DISABLE_PYTHON are related to
the requirement that we have Python to use any of the data formatter
facilities. Those uses shouldn't be necessary. All the scripted interpreters
should go through the generic ScriptInterpr
Author: jdevlieghere
Date: Thu Nov 1 15:16:34 2018
New Revision: 345898
URL: http://llvm.org/viewvc/llvm-project?rev=345898&view=rev
Log:
[FileSystem] Update SetFile signature.
Modified:
lldb/trunk/source/Host/freebsd/HostInfoFreeBSD.cpp
Modified: lldb/trunk/source/Host/freebsd/HostInfoFree
zturner created this revision.
zturner added reviewers: stella.stamenova, labath, beanz, davide.
Herald added subscribers: jfb, delcypher, mgorny, ki.stfu.
A year or so ago, I re-wrote most of the lit infrastructure in LLVM so that it
wasn't so boilerplate-y. I added lots of common helper type s
Author: jdevlieghere
Date: Thu Nov 1 15:46:49 2018
New Revision: 345901
URL: http://llvm.org/viewvc/llvm-project?rev=345901&view=rev
Log:
[File] Remove static method to get permissions.
This patch removes the static accessor in File to get a file's
permissions. Permissions should be checked thro
Author: jmolenda
Date: Thu Nov 1 16:41:05 2018
New Revision: 345912
URL: http://llvm.org/viewvc/llvm-project?rev=345912&view=rev
Log:
When no FileCheck binary is specified, look in the llvm/clang bin
dirs relative to the source directory (Xcode build style) to find
one, use it if found.
Modif
stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.
Looks good. The formatting in lit.cfg.py is a bit messy (indentations,
especially), but as long as the tests pass, this is an improvement :). Thanks!
https://reviews.llvm.
zturner added a comment.
In https://reviews.llvm.org/D54009#1284827, @stella.stamenova wrote:
> Looks good. The formatting in lit.cfg.py is a bit messy (indentations,
> especially), but as long as the tests pass, this is an improvement :). Thanks!
Is there something like clang-format for Pytho
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, zturner, jingham, clayborg.
JDevlieghere added a project: LLDB.
This patch modifies how we open `File` instances in LLDB. Rather than passing a
path or FileSpec to the constructor, we now go through the virtual file system.
clayborg added a comment.
In https://reviews.llvm.org/D53530#1284267, @aprantl wrote:
> > I didn't realize that the string int [] is produced by ValueObject itself;
> > I think this makes this option more palatable to me. I'll give it a try.
>
> So, it turns out it isn't. The only way to get the
51 matches
Mail list logo
