[Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

JDevlieghere added a comment. Thanks for the information, Greg! In https://reviews.llvm.org/D48393#1243588, @clayborg wrote: > A little background might help here: The lldb_private::Module lock is used to > prevent multiple queries into the DWARF from stomping on each other. > > Multi-threaded

[Lldb-commits] [PATCH] D52376: [Swig] Merge typemaps with same bodies

This revision was automatically updated to reflect the committed changes. Closed by commit rL342959: [Swig] Merge typemaps with same bodies (authored by tkrasnukha, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52376?vs=166719&id=166

[Lldb-commits] [lldb] r342959 - [Swig] Merge typemaps with same bodies

Author: tkrasnukha Date: Tue Sep 25 03:30:32 2018 New Revision: 342959 URL: http://llvm.org/viewvc/llvm-project?rev=342959&view=rev Log: [Swig] Merge typemaps with same bodies Differential Revision: https://reviews.llvm.org/D52376 Modified: lldb/trunk/scripts/Python/python-typemaps.swig Mod

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar added a comment. Thanks for all the comments! In https://reviews.llvm.org/D52403#1243127, @clayborg wrote: > So the main questions is: do we need a new section enum called > eSectionTypeDWARFDebugInfoDWO? If so, then this patch changes. I think I > would prefer adding a new enum. Yeah

[Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

labath added a comment. In https://reviews.llvm.org/D48393#1243195, @JDevlieghere wrote: > In https://reviews.llvm.org/D48393#1139327, @labath wrote: > > > The only sane algorithm I can come up right now is to make the list of > > parsed dies local to each thread/parsing entity (e.g. via a "visi

[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, asmith, labath. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, mgorny. This patch introduces the simple `PDBNameParser`. It is needed for parsing names of PDB symbols cor

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

labath added a comment. In https://reviews.llvm.org/D52139#1243170, @teemperor wrote: > Anyway, the actual issue is related Python 3: Arch Linux (and probably > some other distributions that "already" upgraded to Python 3 as > default) will launch Python 3 when the test script calls `python ...

[Lldb-commits] [PATCH] D52468: [PDB] Treat `char`, `signed char` and `unsigned char` as three different types

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: asmith, zturner, labath. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor. `char`, `signed char` and `unsigned char` are three different types, and they are mangled differently: v

[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

labath added a comment. I think you should look at CPlusPlusLanguage::MethodName. It already contains a parser (in fact, two of them) of c++ names, and I think it should be easy to extend it to do what you want. Repository: rLLDB LLDB https://reviews.llvm.org/D52461 _

[Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

clayborg added a comment. In https://reviews.llvm.org/D48393#1244426, @JDevlieghere wrote: > Thanks for the information, Greg! > > In https://reviews.llvm.org/D48393#1243588, @clayborg wrote: > > > A little background might help here: The lldb_private::Module lock is used > > to prevent multiple

[Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

clayborg added a comment. In https://reviews.llvm.org/D48393#1244649, @labath wrote: > I agree with Greg that it would be best to restrict things such that there is > only one instance of parsing going on at any given time for a single module. > I think this was pretty much the state we reached

[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

clayborg added a comment. In https://reviews.llvm.org/D52461#1244813, @labath wrote: > I think you should look at CPlusPlusLanguage::MethodName. It already contains > a parser (in fact, two of them) of c++ names, and I think it should be easy > to extend it to do what you want. I agree with P

[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

aleksandr.urakov added a comment. Ok, I'll look into that, thanks! Repository: rLLDB LLDB https://reviews.llvm.org/D52461 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

apolyakov created this revision. apolyakov added reviewers: teemperor, labath, tatyana-krasnukha, aprantl. Herald added a subscriber: ki.stfu. This patch fixes hanging of the test in case of using python3, changes callback function that will be called if the timer ends; Also, the test didn't work

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov added a comment. Thanks Pavel, I fixed it here https://reviews.llvm.org/D52498. Repository: rL LLVM https://reviews.llvm.org/D52139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

apolyakov updated this revision to Diff 166919. apolyakov added a comment. Removed the shebang line since we call the script via `python ...` so that line doesn't matter. https://reviews.llvm.org/D52498 Files: lit/tools/lldb-mi/target/inputs/target-select-so-path.py Index: lit/tools/lldb-m

[Lldb-commits] [PATCH] D52501: [PDB] Restore the calling convention from PDB

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: clayborg, zturner, labath, asmith. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor. This patch implements restoring of the calling convention from PDB. It is necessary for expressio

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

tatyana-krasnukha added a comment. `pass_fds` parameter was added in Python 3.7. With version 3.6 the test fails with a `TypeError`. https://reviews.llvm.org/D52498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

teemperor added a comment. Hmmm, maybe I mixing up something here, but the docs state `pass_fds` was added in 3.2: > New in version 3.2: The pass_fds parameter was added. https://reviews.llvm.org/D52498 _

[Lldb-commits] [PATCH] D52501: [PDB] Restore the calling convention from PDB

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good as long as all the test suite bots are happy. Repository: rLLDB LLDB https://reviews.llvm.org/D52501 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

tatyana-krasnukha added a comment. It seems I ran into an unrelated issue like this . If the revision works for others, you may ignore this. https://reviews.llvm.org/D52498 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

apolyakov updated this revision to Diff 166936. apolyakov added a comment. Changed python version required to use 'pass_fds' argument to 3.2. I tested this patch with python 2.7 and 3.5. https://reviews.llvm.org/D52498 Files: lit/tools/lldb-mi/target/inputs/target-select-so-path.py Index: l

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

tatyana-krasnukha added a comment. Forget that the test calls default python, not which was passed to cmake. So, it is enough to replace (3,0) pair with (3,2) to fix. Comment at: lit/tools/lldb-mi/target/inputs/target-select-so-path.py:11 +kwargs = {} +if sys.version_info >= (

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

tatyana-krasnukha added a comment. Now works with Python 3.1 too. LGTM. https://reviews.llvm.org/D52498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51859: [NFC] Turn "load dependent files" boolean into an enum

brooks added a comment. Also broke the FreeBSD build: /usr/local/poudriere/ports/brooks/devel/llvm-devel/work/llvm-b418c2351b1fdf6faf6 a2d010d804e895ef49932/tools/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.c pp:338:50: error: cannot initialize a parameter of type 'lldb_private::L

[Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

friss added a comment. In https://reviews.llvm.org/D48393#1245049, @clayborg wrote: > In https://reviews.llvm.org/D48393#1244649, @labath wrote: > > > I agree with Greg that it would be best to restrict things such that there > > is only one instance of parsing going on at any given time for a s

[Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

clayborg added a comment. In https://reviews.llvm.org/D48393#1245342, @friss wrote: > In https://reviews.llvm.org/D48393#1245049, @clayborg wrote: > > > In https://reviews.llvm.org/D48393#1244649, @labath wrote: > > > > > I agree with Greg that it would be best to restrict things such that > > >

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

tatyana-krasnukha added inline comments. Comment at: lit/tools/lldb-mi/target/target-select-so-path.test:4 +# RUN: %cc -o %t %p/inputs/main.c -g +# RUN: python %p/inputs/target-select-so-path.py "%debugserver" "%lldbmi %t" %s + Could you run the same python that

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

apolyakov updated this revision to Diff 166953. apolyakov edited the summary of this revision. apolyakov added a comment. Changed the test to use `%python` variable instead of `python` https://reviews.llvm.org/D52498 Files: lit/tools/lldb-mi/target/inputs/target-select-so-path.py lit/tools/

[Lldb-commits] [lldb] r342998 - Replace boolean parameter with enum value according r342633

Author: tkrasnukha Date: Tue Sep 25 10:59:44 2018 New Revision: 342998 URL: http://llvm.org/viewvc/llvm-project?rev=342998&view=rev Log: Replace boolean parameter with enum value according r342633 Modified: lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp Modified: lldb/trunk/sou

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

apolyakov marked an inline comment as done. apolyakov added inline comments. Comment at: lit/tools/lldb-mi/target/target-select-so-path.test:4 +# RUN: %cc -o %t %p/inputs/main.c -g +# RUN: python %p/inputs/target-select-so-path.py "%debugserver" "%lldbmi %t" %s +

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Looks good and fixes the tests for me, so I think this is good to go. Thanks for the patch! https://reviews.llvm.org/D52498 ___ lldb-commi

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

labath accepted this revision. labath added a comment. LGTM. (BTW, python 3.1's EOL was 6 years ago) https://reviews.llvm.org/D52498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [lldb] r343016 - XFAIL some tests in TestTargetCreateDeps on linux

Author: labath Date: Tue Sep 25 12:52:04 2018 New Revision: 343016 URL: http://llvm.org/viewvc/llvm-project?rev=343016&view=rev Log: XFAIL some tests in TestTargetCreateDeps on linux On linux, we do not support automatic loading of dependent modules, so the module list will always contain just on

[Lldb-commits] [PATCH] D52516: [lldbinline] Set directory attribute on test-specific classes

vsk created this revision. vsk added reviewers: labath, jingham, JDevlieghere. Herald added subscribers: eraman, aprantl. Set the "mydir" attribute of an inline test on the test-specific class, instead of on the base InlineTest class. This makes it possible to run dotest.py on a directory contain

[Lldb-commits] [PATCH] D52516: [lldbinline] Set directory attribute on test-specific classes

davide accepted this revision. davide added a comment. LGTM. https://reviews.llvm.org/D52516 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52516: [lldbinline] Set directory attribute on test-specific classes

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ooh, nice catch. This must have been fun to debug. https://reviews.llvm.org/D52516 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [lldb] r343023 - [lldbinline] Set directory attribute on test-specific classes

Author: vedantk Date: Tue Sep 25 13:20:13 2018 New Revision: 343023 URL: http://llvm.org/viewvc/llvm-project?rev=343023&view=rev Log: [lldbinline] Set directory attribute on test-specific classes Set the "mydir" attribute of an inline test on the test-specific class, instead of on the base Inline

[Lldb-commits] [PATCH] D52516: [lldbinline] Set directory attribute on test-specific classes

This revision was automatically updated to reflect the committed changes. Closed by commit rL343023: [lldbinline] Set directory attribute on test-specific classes (authored by vedantk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz updated this revision to Diff 166985. sgraenitz added a comment. Revert check_hi_lo_pc and comment out call to AddOSOARanges() for now https://reviews.llvm.org/D52375 Files: include/lldb/Symbol/Symtab.h source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp source/Plugins/SymbolFile/DWAR

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:431 const size_t num_ranges = -die->GetAttributeAddressRanges(dwarf, this, ranges, false); +die->GetAttributeAddressRanges(dwarf, this, ranges, check_hi_lo_pc); if

[Lldb-commits] [lldb] r343029 - Change the unwinder to not use a hard-coded limit on the

Author: jmolenda Date: Tue Sep 25 14:01:54 2018 New Revision: 343029 URL: http://llvm.org/viewvc/llvm-project?rev=343029&view=rev Log: Change the unwinder to not use a hard-coded limit on the max number of stack frames to backtrace, make it a setting, target.process.thread.max-backtrace-depth. Add

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB343033: [lldb-mi] Fix bugs in target-select-so-path.test (authored by apolyakov, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D52498 Files: lit/tools/lldb-mi/target/inputs/targ

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:425 const DWARFDebugInfoEntry *die = GetUnitDIEPtrOnly(); const dw_offset_t cu_offset = GetOffset(); Following from inline comment below, you can abort if this CU is

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

vsk updated this revision to Diff 167038. vsk added a comment. The bug I thought I saw in CallEdge::GetReturnPCAddress turned out to be an issue I introduced in dsymutil. It's not correct for dsymutil to relocate the return PC value in TAG_call_site entries, because the correct section slide of