[Lldb-commits] [PATCH] D46144: Reflow paragraphs in comments.

labath added a comment. The formatting of the comments has been bugging me as well. So far, I have been trying to reflow them whenever I touch the code around them, but at that rate fixing all of them would take ages. Your heuristics seem to be working fairly well. I've found a couple of sub-o

[Lldb-commits] [PATCH] D40468: DWZ 01/07: Support reading section ".gnu_debugaltlink"

labath accepted this revision. labath added a comment. Awesome, thanks. I think we can get this one out of the way. In https://reviews.llvm.org/D40468#1080136, @jankratochvil wrote: > Added `lit/Modules/dwarf-gnu-debugaltlink.yaml`. I do not see its test > success anywhere but when I make it fa

[Lldb-commits] [PATCH] D40475: DWZ 06/07: DWZ test mode

jankratochvil planned changes to this revision. jankratochvil added a comment. With the new testsuite run it currently reports failures due to missing .debug_info sections in some testcases, I need to make it false-regression-free. https://reviews.llvm.org/D40475

[Lldb-commits] [PATCH] D40468: DWZ 01/07: Support reading section ".gnu_debugaltlink"

jankratochvil added a comment. In https://reviews.llvm.org/D40468#1080751, @labath wrote: > Awesome, thanks. I think we can get this one out of the way. Thanks, I will check it in next days. > check-lit is a lit-selftest. This test should not be run as a part of that. > Did you perhaps mean c

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

kbaladurin added a comment. Herald added a reviewer: javed.absar. Is it ready to commit? https://reviews.llvm.org/D44998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

labath added a comment. Yes, I take it you need someone to check it in? https://reviews.llvm.org/D44998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

kbaladurin added a comment. Yes, as I haven't commit access. Thank you! https://reviews.llvm.org/D44998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

davide added a comment. This is fine, I'll commit it for you today. https://reviews.llvm.org/D45628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r331043 - Mark test as @skipIfOutOfTreeDebugserver

Author: friss Date: Fri Apr 27 08:30:09 2018 New Revision: 331043 URL: http://llvm.org/viewvc/llvm-project?rev=331043&view=rev Log: Mark test as @skipIfOutOfTreeDebugserver This test will currently fail for people using the system debugserver. Modified: lldb/trunk/packages/Python/lldbsuite/

[Lldb-commits] [lldb] r331049 - Always normalize FileSpec paths.

Author: gclayton Date: Fri Apr 27 08:45:58 2018 New Revision: 331049 URL: http://llvm.org/viewvc/llvm-project?rev=331049&view=rev Log: Always normalize FileSpec paths. Always normalizing lldb_private::FileSpec paths will help us get a consistent results from comparisons when setting breakpoints

[Lldb-commits] [PATCH] D45977: Always normalize FileSpec paths.

This revision was automatically updated to reflect the committed changes. Closed by commit rL331049: Always normalize FileSpec paths. (authored by gclayton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45977?vs=144021&id=144353#toc

[Lldb-commits] [PATCH] D46128: Fix expression parser to not accept any type whose basename matches for a type that must exist at root level

clayborg added a comment. ping? https://reviews.llvm.org/D46128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D46128: Fix expression parser to not accept any type whose basename matches for a type that must exist at root level

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/lang/cpp/type_lookup/TestTypeLookup.py:41 + +# Make sure we don't accedentally accept structures that exist only +# in namespaces when evaluating expressions with top level types. -

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg updated this revision to Diff 144358. clayborg added a comment. Herald added a subscriber: mgorny. Update patch to work with changes from: https://reviews.llvm.org/D45170 https://reviews.llvm.org/D32167 Files: include/lldb/lldb-enumerations.h include/lldb/lldb-forward.h lldb.xco

Re: [Lldb-commits] [lldb] r331049 - Always normalize FileSpec paths.

Greg, Your new FileSpecTest unit tests are failing in the Xcode build of lldb, e.g.: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/6271/consoleFull#-1083450927b825e790-484f-4586-af29-73c4754ff671 Can you figure out what's up with this? Jim BTW, the "reply to" for lldb-commits mails f

Re: [Lldb-commits] [lldb] r331049 - Always normalize FileSpec paths.

> On Apr 27, 2018, at 11:17 AM, Jim Ingham via lldb-commits > wrote: > > Greg, > > Your new FileSpecTest unit tests are failing in the Xcode build of lldb, e.g.: > > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/6271/consoleFull#-1083450927b825e790-484f-4586-af29-73c4754ff671 > >

[Lldb-commits] [lldb] r331073 - [debugserver] Fix the G packet handling.

Author: friss Date: Fri Apr 27 12:59:42 2018 New Revision: 331073 URL: http://llvm.org/viewvc/llvm-project?rev=331073&view=rev Log: [debugserver] Fix the G packet handling. Of course r331004 needed a counterpart on the write side. Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/ll

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

probinson added a comment. I am looking at making the LLVM parser handle type units across v4/v5, and the trick of pretending .debug_types is pasted onto the end of .debug_info seems like a pretty convenient fiction. It unifies DIE handling, and still allows the dumper to distinguish which bit

Re: [Lldb-commits] [lldb] r331049 - Always normalize FileSpec paths.

Will do > On Apr 27, 2018, at 1:01 PM, Frédéric Riss wrote: > > > >> On Apr 27, 2018, at 11:17 AM, Jim Ingham via lldb-commits >> mailto:lldb-commits@lists.llvm.org>> wrote: >> >> Greg, >> >> Your new FileSpecTest unit tests are failing in the Xcode build of lldb, >> e.g.: >> >> http://l

Re: [Lldb-commits] [lldb] r331049 - Always normalize FileSpec paths.

I will fix this ASAP > On Apr 27, 2018, at 11:17 AM, Jim Ingham wrote: > > Greg, > > Your new FileSpecTest unit tests are failing in the Xcode build of lldb, e.g.: > > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/6271/consoleFull#-1083450927b825e790-484f-4586-af29-73c4754ff671 > >

[Lldb-commits] [lldb] r331082 - Fix build bots after r331049 broke them.

Author: gclayton Date: Fri Apr 27 14:10:07 2018 New Revision: 331082 URL: http://llvm.org/viewvc/llvm-project?rev=331082&view=rev Log: Fix build bots after r331049 broke them. Modified: lldb/trunk/source/Utility/FileSpec.cpp Modified: lldb/trunk/source/Utility/FileSpec.cpp URL: http://llvm

Re: [Lldb-commits] [lldb] r331049 - Always normalize FileSpec paths.

Buildbots should be fixed with 331082. > On Apr 27, 2018, at 1:01 PM, Frédéric Riss wrote: > > > >> On Apr 27, 2018, at 11:17 AM, Jim Ingham via lldb-commits >> mailto:lldb-commits@lists.llvm.org>> wrote: >> >> Greg, >> >> Your new FileSpecTest unit tests are failing in the Xcode build of

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur added a comment. Thank you David. This is still based on the latest revision of the file (+ the non functional change patch). F6048729: nfc.patch https://reviews.llvm.org/D45628 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D46220: Remove premature caching of the global variables list in CompileUnit.

aprantl created this revision. aprantl added reviewers: clayborg, jingham. Herald added a subscriber: JDevlieghere. Remove premature caching of the global variables list in CompileUnit. This is fixing a bug where (lldb) target var g_ptr would propulate the global variables list with exactl

[Lldb-commits] [PATCH] D46220: Remove premature caching of the global variables list in CompileUnit.

aprantl added a comment. This also adds test coverage for r224559, which is how I discovered this bug in the first place. https://reviews.llvm.org/D46220 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D46088: Refactor GetNextPersistentVariableName into a non-virtual method

aprantl added a comment. ping https://reviews.llvm.org/D46088 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D46083: Move the persistent variable counter into Target

aprantl added a comment. ping. https://reviews.llvm.org/D46083 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D46144: Reflow paragraphs in comments.

aprantl updated this revision to Diff 144420. aprantl added a comment. Updated the script based on Pavel's feedback: import textwrap import commands import os import sys import re tmp = "%s.tmp"%sys.argv[1] out = open(tmp, "w+") with open(sys.argv[1], "r") as f: header = ""

[Lldb-commits] [PATCH] D46088: Refactor GetNextPersistentVariableName into a non-virtual method

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I'm curious how you are going to implement GetPersistentVariablePrefix for a language (e.g. swift) that uses multiple prefixes. You've got a pattern here where you always call Get