Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

On Thu, 8 Mar 2018 at 18:46, Jim Ingham wrote: > > > > On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote: > > > > > > > > > > On Thu, 8 Mar 2018 at 02:46, Davide Italiano > wrote: > > On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote: > > > The hashing algorithm gives different values - at least f

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

It seems my compiler is magic as well. Running the test against /usr/bin/clang also succeeds (all variants)... On Fri, 9 Mar 2018 at 10:19, Pavel Labath wrote: > > > > On Thu, 8 Mar 2018 at 18:46, Jim Ingham wrote: > >> >> >> > On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote: >> > >> > >> > >>

[Lldb-commits] [lldb] r327110 - Move option parsing out of the Args class

Author: labath Date: Fri Mar 9 02:39:40 2018 New Revision: 327110 URL: http://llvm.org/viewvc/llvm-project?rev=327110&view=rev Log: Move option parsing out of the Args class Summary: The args class is used in plenty of places (a lot of them in the lower lldb layers) for representing a list of ar

[Lldb-commits] [PATCH] D43837: Move option parsing out of the Args class

This revision was automatically updated to reflect the committed changes. Closed by commit rL327110: Move option parsing out of the Args class (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43837?vs=136355&id=1377

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

labath added a comment. I thought the DoLoadInMemory function (which should probably be called differently then) could just return a vector and the actual writing would still happen in the LoadInMemory function. https://reviews.llvm.org/D42145 ___

[Lldb-commits] [lldb] r327123 - [elf] Remove one copy of the section merging code

Author: labath Date: Fri Mar 9 04:30:09 2018 New Revision: 327123 URL: http://llvm.org/viewvc/llvm-project?rev=327123&view=rev Log: [elf] Remove one copy of the section merging code Summary: Besides being superfluous, this double merging was actually wrong and causing some sections to be added t

[Lldb-commits] [PATCH] D44157: [elf] Remove one copy of the section merging code

This revision was automatically updated to reflect the committed changes. Closed by commit rL327123: [elf] Remove one copy of the section merging code (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44157 Files: lld

[Lldb-commits] [lldb] r327133 - Make TestCompletion work on windows

Author: labath Date: Fri Mar 9 06:32:16 2018 New Revision: 327133 URL: http://llvm.org/viewvc/llvm-project?rev=327133&view=rev Log: Make TestCompletion work on windows The test I added in r327110 is failing on windows because of "import pexpect". However, this import is no longer necessary as th

[Lldb-commits] [PATCH] D44306: Move Args::StringToAddress to Target::EvaluateAddressExpression

labath created this revision. labath added reviewers: jingham, zturner. StringToAddress could end up evaluating an expression, which is a somewhat unexpected behavior of a seemingly simple method. I rename it to EvaluateAddressExpression and move it to the Target class, next to the standard Evalua

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

owenpshaw added a comment. It can be done that way. As I mentioned, it would require moving the Process.h import from ObjectFile.cpp to ObjectFile.h (to get the declaration of Process::WriteEntry). I'm asking how you guys feel about that. Without a clear sense of project norms, I'll always g

Re: [Lldb-commits] [lldb] r327089 - [test] Skip a test which sporadically fails in its dsym variant

+ Jonas (who's going to fix this probably) On Thu, Mar 8, 2018 at 4:34 PM, Vedant Kumar via lldb-commits wrote: > Author: vedantk > Date: Thu Mar 8 16:34:43 2018 > New Revision: 327089 > > URL: http://llvm.org/viewvc/llvm-project?rev=327089&view=rev > Log: > [test] Skip a test which sporadically

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

JDevlieghere updated this revision to Diff 137762. JDevlieghere retitled this revision from "WIP: Update selected thread after loading mach core" to "Update selected thread after loading mach core". JDevlieghere edited the summary of this revision. JDevlieghere added a comment. - Added testcase.

[Lldb-commits] [PATCH] D44182: [SymbolFilePDB] Keep searching until the file name is found for the pdb compiland

asmith added a comment. Any comment on this one? :) Repository: rL LLVM https://reviews.llvm.org/D44182 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

labath added a comment. Ah, sorry. I didn't get where you were going with your previous comment. The ObjectFile->Process dependency is something that I think we shouldn't have, but whether it's in an header or implementation file makes little difference to me. So I think moving the #include is

[Lldb-commits] [PATCH] D44182: [SymbolFilePDB] Keep searching until the file name is found for the pdb compiland

This revision was automatically updated to reflect the committed changes. Closed by commit rL327162: [SymbolFilePDB] Keep searching until the file name is found for the pdb… (authored by asmith, committed by ). Changed prior to commit: https://reviews.llvm.org/D44182?vs=137298&id=137798#toc Re

[Lldb-commits] [PATCH] D44321: Support demangling for D symbols via dlopen

johanengelen added inline comments. Comment at: source/Plugins/Language/D/DLanguage.cpp:1 +//===-- DLanguage.cpp +// fix header, and also need to clang-format the file Comment at: source/Plugins/Language/D/DLanguage.cpp:20 + +char* lldbd_demang

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

owenpshaw updated this revision to Diff 137827. owenpshaw added a comment. Looking at LoadInMemory, it seems like the common code is actually more appropriate in the command handler. It's checking inputs and doing the unrelated task of setting the pc. So here's an attempt at going a little fu

[Lldb-commits] [PATCH] D44321: Support demangling for D symbols via dlopen

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. This patch has no testcase. It shouldn't be particularly hard to write one, you can take inspiration from the one in `lit/`. Thanks! Repository: rL LLVM https://reviews.llvm.org

[Lldb-commits] [lldb] r327193 - Rename clang.modules-cache-path to symbols.clang-modules-cache-path

Author: adrian Date: Fri Mar 9 17:11:25 2018 New Revision: 327193 URL: http://llvm.org/viewvc/llvm-project?rev=327193&view=rev Log: Rename clang.modules-cache-path to symbols.clang-modules-cache-path I want to extend the properties on ModuleList to also contain other more general settings and re

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

aprantl created this revision. aprantl added reviewers: jingham, vsk, labath. This is a more principled approach to disabling Spotlight .dSYM lookups while running the testsuite, most importantly it also works for the LIT-based tests, which I overlooked in my initial fix (renaming the test build