johanengelen added inline comments.
================
Comment at: source/Plugins/Language/D/DLanguage.cpp:1
+//===-- DLanguage.cpp
+//
----------------
fix header, and also need to clang-format the file
================
Comment at: source/Plugins/Language/D/DLanguage.cpp:20
+
+char* lldbd_demangle(size_t length, const char* mangled);
+void d_initialize();
----------------
add comment about the purpose of these fwd decls.
================
Comment at: source/Plugins/Language/D/DLanguage.cpp:24
+// TODO:MOVE
+struct SharedLib{
+ void* handle;
----------------
Did you look into using llvm/Support/DynamicLibrary.h ?
That would make the code crossplatform (notably: Windows).
================
Comment at: source/Plugins/Language/D/DLanguage.cpp:35
+
+ // Return true of `dlopen` succeeded
+ bool open(const char* libraryFile, int flag)
----------------
typo: "if"
================
Comment at: source/Plugins/Language/D/DLanguage.cpp:108
+
+ auto fun0=lib2->getFun<decltype(d_initialize)>("d_initialize");
+ (*fun0)();
----------------
Would it help to initialize druntime using a static module constructor in the
lldbdplugin dll?
(then you can also do de-init using a static module destructor)
================
Comment at: source/Plugins/Language/D/DLanguage.h:1
+//===-- DLanguage.h ----------------------------------*- C++ -*-===//
+//
----------------
fix header line
Repository:
rL LLVM
https://reviews.llvm.org/D44321
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
