Re: [Lldb-commits] [lldb] r324251 - Sync PlatformNetBSD.cpp with Linux

Merged to 6.0 in r324326. On Mon, Feb 5, 2018 at 6:12 PM, Kamil Rytarowski via lldb-commits wrote: > Author: kamil > Date: Mon Feb 5 09:12:23 2018 > New Revision: 324251 > > URL: http://llvm.org/viewvc/llvm-project?rev=324251&view=rev > Log: > Sync PlatformNetBSD.cpp with Linux > > Summary: > Va

Re: [Lldb-commits] [lldb] r324234 - Fix a crash in *NetBSD::Factory::Launch

Merged to 6.0 in r324327. On Mon, Feb 5, 2018 at 2:16 PM, Kamil Rytarowski via lldb-commits wrote: > Author: kamil > Date: Mon Feb 5 05:16:22 2018 > New Revision: 324234 > > URL: http://llvm.org/viewvc/llvm-project?rev=324234&view=rev > Log: > Fix a crash in *NetBSD::Factory::Launch > > Summary:

[Lldb-commits] [PATCH] D42939: More correct handling of error cases C++ name parser

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Being more resilient when handling demangler outputs seems like a good thing, but I think it is important to understand what made the demangler produce that output in the first place, to make

Re: [Lldb-commits] [PATCH] D42210: Re-enable logging on the child side of a fork() in lldb-server platform mode

Right I see. Thanks for the explanation. I feel this is a good time to bring up again my idea for implementing gdb-server connections in a port-forwarder-friendly way. It's described at , so I am not going to repeat the details h

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks much better. Thanks. https://reviews.llvm.org/D42763 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D42931: ELF GetSectionHeaderInfo: process SHT_NOTE even without .shstrtab

labath added a comment. As I mentioned in the patch above, I don't think it's worth it trying to tiptoe here, as for 99% of files (basically, anything that is not yaml2obj's output, I think), we will end up reading the whole file anyway. It just increases the number of things that can go wrong.

[Lldb-commits] [PATCH] D42931: ELF GetSectionHeaderInfo: process SHT_NOTE even without .shstrtab

jankratochvil abandoned this revision. jankratochvil added a comment. I think this patch still makes sense but whatever. https://reviews.llvm.org/D42931 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

labath added a comment. Heh, no good deed goes unpunished, right.. :) It occured to me that this could be testable using the existing `lldb-test module-sections` functionality (I don't need to use a symbol, I can easily use a section name to recognise that a debug info was loaded from the other

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath created this revision. labath added reviewers: clayborg, jingham, davide. Herald added a subscriber: emaste. The result of Module::GetSectionList depended on whether the symbol vendor has been loaded (which would augment the section list with the extra sections that have been found by the v

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath added inline comments. Comment at: tools/lldb-test/lldb-test.cpp:75 ModuleSpec Spec{FileSpec(File, false)}; -Spec.GetSymbolFileSpec().SetFile(File, false); The expliciting symbol filespec setting was short-circuiting the regular search process.

[Lldb-commits] [PATCH] D42959: Rewrite the flaky test_restart_bug test in a more deterministic way

labath created this revision. labath added a reviewer: owenpshaw. Herald added a subscriber: srhines. The test was trying to reproduce a bug in handling of two concurrent events, which was impossible to do reliably in a black-box style test. In practice, this meant the test was only ever failing o

Re: [Lldb-commits] [lldb] r322339 - When parsing the target.xml register file, if no architecture has

ping. I might consider reverting this and the other commits without tests bay the end of the week unless we have a story for testing here. It's been one month. On Mon, Feb 5, 2018 at 9:44 AM, Davide Italiano wrote: > On Mon, Jan 29, 2018 at 10:17 AM, Jason Molenda wrote: >> >> >>> On Jan 28, 201

[Lldb-commits] [lldb] r324368 - Build each testcase variant in its own subdirectory and remove the srcdir lock file

Author: adrian Date: Tue Feb 6 10:22:51 2018 New Revision: 324368 URL: http://llvm.org/viewvc/llvm-project?rev=324368&view=rev Log: Build each testcase variant in its own subdirectory and remove the srcdir lock file This patch creates a .dwarf, .dwo, etc., build directory for each testcase vari

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

This revision was automatically updated to reflect the committed changes. Closed by commit rL324368: Build each testcase variant in its own subdirectory and remove the srcdir lock… (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[Lldb-commits] [lldb] r324380 - More correct handling of error cases C++ name parser

Author: eugene Date: Tue Feb 6 11:04:12 2018 New Revision: 324380 URL: http://llvm.org/viewvc/llvm-project?rev=324380&view=rev Log: More correct handling of error cases C++ name parser Now incorrect type argument that looks like T doesn't cause an assert, but just a parsing error. Bug: 36224 Di

[Lldb-commits] [PATCH] D42939: More correct handling of error cases C++ name parser

eugene added inline comments. Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.cpp:199 case tok::greatergreater: template_counter -= 2; can_open_template = false; labath wrote: > While looking at the bug, this part here struck

[Lldb-commits] [PATCH] D42939: More correct handling of error cases C++ name parser

This revision was automatically updated to reflect the committed changes. Closed by commit rL324380: More correct handling of error cases C++ name parser (authored by eugene, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42939?vs=132

Re: [Lldb-commits] [lldb] r322339 - When parsing the target.xml register file, if no architecture has

Barring serious extenuating circumstances, an untested functional change in llvm is not complete. And as time goes on it becomes less and less likely that we'll revisit this. I think it's a good idea to revert this until there's a test. vedant > On Feb 6, 2018, at 7:42 AM, Davide Italiano via

Re: [Lldb-commits] [lldb] r322339 - When parsing the target.xml register file, if no architecture has

I will be looking at how this might be testable. If it makes people more comfortable to revert the change until then, fine. I'm the middle of a big chunk of work right now and need to complete this first. > On Feb 6, 2018, at 11:43 AM, Vedant Kumar wrote: > > Barring serious extenuating circ

[Lldb-commits] [lldb] r324396 - Pass --build-dir to dotest in the Xcode project

Author: adrian Date: Tue Feb 6 12:48:35 2018 New Revision: 324396 URL: http://llvm.org/viewvc/llvm-project?rev=324396&view=rev Log: Pass --build-dir to dotest in the Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: h

[Lldb-commits] [lldb] r324400 - Remove obsolete file

Author: adrian Date: Tue Feb 6 13:04:06 2018 New Revision: 324400 URL: http://llvm.org/viewvc/llvm-project?rev=324400&view=rev Log: Remove obsolete file Removed: lldb/trunk/packages/Python/lldbsuite/test/bench-history Modified: lldb/trunk/packages/Python/lldbsuite/test/bench.py Removed:

Re: [Lldb-commits] [lldb] r324400 - Remove obsolete file

Thanks! On Tue, Feb 6, 2018 at 1:04 PM, Adrian Prantl via lldb-commits wrote: > Author: adrian > Date: Tue Feb 6 13:04:06 2018 > New Revision: 324400 > > URL: http://llvm.org/viewvc/llvm-project?rev=324400&view=rev > Log: > Remove obsolete file > > Removed: > lldb/trunk/packages/Python/lldbs

[Lldb-commits] [PATCH] D42990: Add CMAKE_CFG_INTDIR as part of the include path for the default test compiler.

asmith created this revision. asmith added reviewers: zturner, lldb-commits. Herald added subscribers: llvm-commits, hintonda, mgorny. This is a small change towards running the LLDB unit tests on Windows (still WIP). Systems that use make do not point to specific configurations. However, on sy

[Lldb-commits] [PATCH] D42994: Stop passing -fPIC to lldb tests on Windows

asmith created this revision. asmith added reviewers: zturner, lldb-commits. Herald added a subscriber: llvm-commits. Update some unit tests that are passing -fPIC on Windows which is not a valid compiler option. This is another step in making the LLDB unit tests run on Windows. Repository:

[Lldb-commits] [PATCH] D42994: Stop passing -fPIC to lldb tests on Windows

zturner added a comment. In the future when you upload diffs can you include context? (i.e. `git diff -U99`). It's nice to be able to see the surrounding code when I'm looking at a diff. Is there ever a case where you would want to build a shared library without `-fPIC`? I'm wondering i

[Lldb-commits] [lldb] r324437 - lldb running on an ios device is using the _dyld_get_all_image_infos()

Author: jmolenda Date: Tue Feb 6 17:28:29 2018 New Revision: 324437 URL: http://llvm.org/viewvc/llvm-project?rev=324437&view=rev Log: lldb running on an ios device is using the _dyld_get_all_image_infos() SPI call to to find its own shared cache's UUID. On newer sytems we need to use the a new