ravitheja marked 5 inline comments as done.
ravitheja added inline comments.
Comment at: source/Plugins/Process/Linux/ProcessorTrace.cpp:307
+
+Status ProcessorTraceMonitor::Destroy() {
+ Status error;
labath wrote:
> I'd like this work to be done in the destruc
ravitheja added inline comments.
Comment at: source/Plugins/Process/Linux/ProcessorTrace.h:79
+ // Trace id of trace instance corresponding to the process.
+ static lldb::user_id_t m_pt_process_traceid;
+
labath wrote:
> labath wrote:
> > Instead of global vari
labath added inline comments.
Comment at: source/Plugins/Process/Linux/ProcessorTrace.cpp:307
+
+Status ProcessorTraceMonitor::Destroy() {
+ Status error;
ravitheja wrote:
> labath wrote:
> > I'd like this work to be done in the destructor. Just like nobody shou
Author: labath
Date: Thu Jun 22 10:54:21 2017
New Revision: 306013
URL: http://llvm.org/viewvc/llvm-project?rev=306013&view=rev
Log:
Simplify the gdb-remote unit tests
Instead of every test creating a client-server combo, do that in the
SetUp method of the test fixture. This also means that we ca
mehdi_amini created this revision.
Herald added a subscriber: emaste.
Reported by coverity, I don't know how to provide a test.
https://reviews.llvm.org/D34550
Files:
lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
Index: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
===
