ravitheja added inline comments.
================ Comment at: source/Plugins/Process/Linux/ProcessorTrace.h:79 + // Trace id of trace instance corresponding to the process. + static lldb::user_id_t m_pt_process_traceid; + ---------------- labath wrote: > labath wrote: > > Instead of global variables (we may want to debug more than one process > > eventually), we could have a member variable `std::pair<user_id_t, > > TraceOptions> m_process_trace;` (you can have a special class for that if > > you don't like .first and .second everywhere). > I guess I wasn't too clear about this, but I meant a member variable in the > Process class. This solves the "multiple process" issue, but creates a couple > of other ones. All the call sites are now more complicated, and you have to > worry about managing the lifetime of the entries in this map. If this was a > Process member variable, those would be handled automatically (and it makes > more sense, since it is the process class that owns these traces instances). Ok sorry now I understand what u meant. https://reviews.llvm.org/D33674 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
