[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

labath added a comment. Thanks for spelling that out. However, it still does not sound like a convincing use case to me. Why would the user start to trace just one thread, only to later change his mind and trace the whole process instead. I'm not saying that can't happen, but it seems like some

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

ravitheja added a comment. Although a bit confusing, there is more flexibility for the user.I must also point out that the trace buffer available is not unlimited and there can be situations where a user might simultaneously want to trace newly spawned threads with a smaller buffer and trace an

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

ravitheja added a comment. > Start tracing the whole process > Ok. Traceid = 1 > Start tracing thread 47 > Error. Thread 47 is already traced. (???) The error is because its already being traced, so if someone wants the trace log, its already available and the user need not do anything extra.

[Lldb-commits] [PATCH] D34236: Delete ProcessLauncherPosix

labath added a comment. In https://reviews.llvm.org/D34236#783186, @emaste wrote: > LGTM from the FreeBSD side. The launch code for FreeBSD came from the > original (in-process) implementation that Linux and FreeBSD shared. Thanks Ed. If anyone's interested in archaeology, that launch code wa

[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

abhishek.aggarwal added a subscriber: ravitheja. abhishek.aggarwal added inline comments. Comment at: tools/intel-pt/CMakeLists.txt:53 + +if (NOT LLDB_DISABLE_PYTHON) + target_link_libraries(lldbIntelPT PRIVATE labath wrote: > All of this needs to go away. I thi

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

labath added a comment. In https://reviews.llvm.org/D33674#783861, @ravitheja wrote: > Although a bit confusing, there is more flexibility for the user.I must also > point out that the trace buffer available is not unlimited and there can be > situations where a user might simultaneously want t

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

ravitheja added inline comments. Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:277 + + llvm::DenseMap + m_processor_trace_monitor; labath wrote: > ravitheja wrote: > > labath wrote: > > > I'd like to downgrade these to unique pointers to Pro

[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

labath added inline comments. Comment at: tools/intel-features/CMakeLists.txt:50 +install(TARGETS lldbIntelFeatures + LIBRARY DESTINATION bin) "bin" sounds wrong here. Shouldn't this go ti lib${LLVM_LIBDIR_SUFFIX}? To properly handle DLL targets (i don't know wh

[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

labath added a comment. In https://reviews.llvm.org/D34274#782529, @zturner wrote: > The last time I tried to do this we couldn't because it didn't yet work on > iOS. I checked with some Apple people though and they said `thread_local` > support was released last year on all Apple platforms.

[Lldb-commits] [lldb] r305686 - Delete ProcessLauncherPosix

Author: labath Date: Mon Jun 19 07:26:22 2017 New Revision: 305686 URL: http://llvm.org/viewvc/llvm-project?rev=305686&view=rev Log: Delete ProcessLauncherPosix Summary: ProcessLauncherPosix was using posix_spawn for launching the process, but this function is not available on all platforms we su

[Lldb-commits] [PATCH] D34236: Delete ProcessLauncherPosix

This revision was automatically updated to reflect the committed changes. Closed by commit rL305686: Delete ProcessLauncherPosix (authored by labath). Changed prior to commit: https://reviews.llvm.org/D34236?vs=102667&id=103022#toc Repository: rL LLVM https://reviews.llvm.org/D34236 Files:

[Lldb-commits] [lldb] r305687 - Tweak SysV_arm64 function entry unwind plan

Author: labath Date: Mon Jun 19 07:39:34 2017 New Revision: 305687 URL: http://llvm.org/viewvc/llvm-project?rev=305687&view=rev Log: Tweak SysV_arm64 function entry unwind plan Summary: The motivation for this is to make sure the first row of the plan compares equal to the first row of a generic

[Lldb-commits] [PATCH] D34199: Tweak SysV_arm64 function entry unwind plan

This revision was automatically updated to reflect the committed changes. Closed by commit rL305687: Tweak SysV_arm64 function entry unwind plan (authored by labath). Changed prior to commit: https://reviews.llvm.org/D34199?vs=102514&id=103025#toc Repository: rL LLVM https://reviews.llvm.or

[Lldb-commits] [lldb] r305689 - Add pretty-printer for wait(2) statuses and modernize the code handling them

Author: labath Date: Mon Jun 19 07:47:50 2017 New Revision: 305689 URL: http://llvm.org/viewvc/llvm-project?rev=305689&view=rev Log: Add pretty-printer for wait(2) statuses and modernize the code handling them Summary: A number of places were trying to decode the result of wait(). Add a simple ut

[Lldb-commits] [PATCH] D33998: Add pretty-printer for wait(2) statuses and modernize the code handling them

This revision was automatically updated to reflect the committed changes. Closed by commit rL305689: Add pretty-printer for wait(2) statuses and modernize the code handling them (authored by labath). Changed prior to commit: https://reviews.llvm.org/D33998?vs=102309&id=103027#toc Repository:

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

ravitheja added a comment. In https://reviews.llvm.org/D33674#783893, @labath wrote: > In https://reviews.llvm.org/D33674#783861, @ravitheja wrote: > > > Although a bit confusing, there is more flexibility for the user.I must > > also point out that the trace buffer available is not unlimited an

[Lldb-commits] [PATCH] D34352: [linux] Change the way we load vdso pseudo-module

labath created this revision. Herald added a subscriber: emaste. This is basically a revert of https://reviews.llvm.org/D16107 and parts of https://reviews.llvm.org/D10800, which were trying to get vdso loading working. They did this by implementing a generic load-an-elf-file from memory approach

[Lldb-commits] [PATCH] D33674: Implementation of Intel(R) Processor Trace support for Linux

labath added a comment. > Well that's the whole thread group idea. Currently we have only one thread > group i.e the process group (all existing un traced threads + newly spawned > ones). > With separate "trace all threads" and "trace new threads", it will be > multiple thread groups. For e.g

[Lldb-commits] [PATCH] D34322: [lldb] Correctly escape newlines and backslashes in the JSON serializer

beanz added a comment. In https://reviews.llvm.org/D34322#783532, @joerg wrote: > My suggestion would be to just use the YAML writer for now and leave a > comment to make it clear that this is really JSON only. Our YAML parser can parse JSON because YAML is a superset of JSON, but I don't bel

[Lldb-commits] [PATCH] D34322: [lldb] Correctly escape newlines and backslashes in the JSON serializer

joerg added a comment. I don't disagree with you, but please see the referenced review for further details. I do not want the amount of adhoc JSON encoders to grow further. The YAML encoder works fine for most of the things, but it is easier to review calls to it than it is to find other insta

[Lldb-commits] [PATCH] D34322: [lldb] Correctly escape newlines and backslashes in the JSON serializer

beanz added a comment. I get your perspective, but holding up this relatively small patch that fixes a bug in existing code on an architectural disagreement seems like excessive bike shedding. If we assume that JSON is required for the use case would you have Kuba write a full JSON parser in LL

[Lldb-commits] [PATCH] D34322: [lldb] Correctly escape newlines and backslashes in the JSON serializer

joerg added a comment. Not parsers, encoders. Note that the escaping is not correct for control characters other than \n. https://reviews.llvm.org/D34322 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D34352: [linux] Change the way we load vdso pseudo-module

tberghammer accepted this revision. tberghammer added a comment. Looks good https://reviews.llvm.org/D34352 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

On May 30, 6:02pm, ulrich.weig...@de.ibm.com ("Ulrich Weigand") wrote: -- Subject: Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898 | Hmm, from looking at the version of libedit I'm using it would | appear that it should correctly handle either: | - a narrow char read function installed via el=

[Lldb-commits] [lldb] r304527 - Remove vestigial CLANG_USED_LIBS.

Author: aadg Date: Fri Jun 2 02:48:35 2017 New Revision: 304527 URL: http://llvm.org/viewvc/llvm-project?rev=304527&view=rev Log: Remove vestigial CLANG_USED_LIBS. The actual definition was removed 4 months ago with r294515. Modified: lldb/trunk/unittests/CMakeLists.txt Modified: lldb/trun

[Lldb-commits] [lldb] r304832 - Use exact equality for category language matching, for all languages, except those specifically mentioned.

Author: vadimcn Date: Tue Jun 6 15:40:24 2017 New Revision: 304832 URL: http://llvm.org/viewvc/llvm-project?rev=304832&view=rev Log: Use exact equality for category language matching, for all languages, except those specifically mentioned. Modified: lldb/trunk/source/DataFormatters/TypeCate

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

On May 29, 8:11pm, ulrich.weig...@de.ibm.com ("Ulrich Weigand") wrote: -- Subject: Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898 | Sorry, this is on an internal IBM machine ... I don't have a publically | accessible machine to reproduce this on at the moment. I am sorry to say that this is

[Lldb-commits] [lldb] r305727 - Updated NSNumber formatter for new internal representation.

Author: spyffe Date: Mon Jun 19 13:32:22 2017 New Revision: 305727 URL: http://llvm.org/viewvc/llvm-project?rev=305727&view=rev Log: Updated NSNumber formatter for new internal representation. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter

[Lldb-commits] [PATCH] D34322: [lldb] Correctly escape newlines and backslashes in the JSON serializer

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D34322 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. We have thread local storage support on all our current darwin platforms. https://reviews.llvm.org/D34274 ___ lldb-commits mailing li