labath added inline comments.
Comment at: source/Host/common/MainLoop.cpp:82
+ int queue_id;
+ std::vector events;
+ struct kevent event_list[4];
eugene wrote:
> here and below struct seems to be redundant
One of them holds the input events, and the other the
ravitheja added inline comments.
Comment at: docs/lldb-gdb-remote.txt:212
//--
+// QTrace:1:type:;
+//
clayborg wrote:
> Should we make all these new packets JSON based to start with? "jTrace"?
labath added a comment.
Cool, glad that's sorted. I've had some ideas about introducing limited amount
of paralellism to the server side, but that's probably is not interesting to
you if you're not doing remote debugging.
Repository:
rL LLVM
https://reviews.llvm.org/D32568
__
labath added a comment.
If you're going to be making drastic changes here, could you please look at the
possibility of making a more targeted test, rather than relying on the "run the
whole debugger and set a breakpoint" type of tests to verify the finer details
of the implementation. I was abl
labath updated this revision to Diff 97074.
labath added a comment.
Address review feedback.
https://reviews.llvm.org/D32600
Files:
include/lldb/Host/MainLoop.h
source/Host/common/MainLoop.cpp
Index: source/Host/common/MainLoop.cpp
==
labath added a comment.
I am going to check this in to unbork the android bots. I'm happy to address
any additional feedback in a followup.
I'm also planning to come some unit tests for this class next week.
https://reviews.llvm.org/D32600
___
lld
Author: labath
Date: Fri Apr 28 05:26:06 2017
New Revision: 301636
URL: http://llvm.org/viewvc/llvm-project?rev=301636&view=rev
Log:
Resurrect pselect MainLoop implementation
Summary:
It turns out that even though ppoll is available on all the android
devices we support, it does not seem to be wo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301636: Resurrect pselect MainLoop implementation (authored
by labath).
Changed prior to commit:
https://reviews.llvm.org/D32600?vs=97074&id=97075#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3
labath added a reviewer: zturner.
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I am adding Zachary, as he usually has good ideas about APIs.
All in all, it's not a very controversal change, but I have a bunch of inline
comments
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301642: Remove lock from ConstString::GetLength (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D32306?vs=96841&id=97083#toc
Repository:
rL LLVM
https://reviews.llvm.org/D323
Author: labath
Date: Fri Apr 28 07:08:28 2017
New Revision: 301642
URL: http://llvm.org/viewvc/llvm-project?rev=301642&view=rev
Log:
Remove lock from ConstString::GetLength
Summary: ConstStrings are immutable, so there is no need to grab even a reader
lock in order to read the length field.
Rev
labath added inline comments.
Comment at: source/Utility/ConstString.cpp:49
+ // pointer, we don't need the lock.
const StringPoolEntryType &entry = GetStringMapEntryFromKeyData(ccstr);
return entry.getKey().size();
scott.smith wrote:
> labath
clayborg added inline comments.
Comment at: docs/lldb-gdb-remote.txt:212
//--
+// QTrace:1:type:;
+//
labath wrote:
> ravitheja wrote:
> > clayborg wrote:
> > > Should we make all these new pack
zturner added inline comments.
Comment at: docs/lldb-gdb-remote.txt:214
+//
+// BRIEF
+// Packet for starting tracing of type lldb::TraceType. The following
I just noticed that none of our documentation uses doxygen? Weird.
Comment at: includ
Author: penryu
Date: Fri Apr 28 13:10:53 2017
New Revision: 301664
URL: http://llvm.org/viewvc/llvm-project?rev=301664&view=rev
Log:
Add remaining SBTrace headers to LLDB framework
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
h
fjricci added inline comments.
Comment at: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py:1418
"include")),
-'LD_EXTRAS': "-L%s -llldb" % lib_dir}
+'LD_EXTRAS': "-L%s/../lib -llldb -Wl,-r
krytarowski updated this revision to Diff 97149.
krytarowski added a comment.
Strip non-functional style improvements in unrelated code-parts.
Apply changes to address comments from Joerg.
Repository:
rL LLVM
https://reviews.llvm.org/D32149
Files:
source/Plugins/ObjectFile/ELF/ObjectFileE
krytarowski updated this revision to Diff 97150.
krytarowski added a comment.
Remove another unrelated style improvement.
Repository:
rL LLVM
https://reviews.llvm.org/D32149
Files:
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/Process/elf-core/ProcessElfCore.cpp
source
penryu abandoned this revision.
penryu added a comment.
Lang's change in https://reviews.llvm.org/D32554 makes these unnecessary.
Thanks, Lang!
https://reviews.llvm.org/D32548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
Author: penryu
Date: Fri Apr 28 16:03:18 2017
New Revision: 301686
URL: http://llvm.org/viewvc/llvm-project?rev=301686&view=rev
Log:
Public headers need to be public.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org
20 matches
Mail list logo
