ravitheja added inline comments.
================ Comment at: docs/lldb-gdb-remote.txt:212 //---------------------------------------------------------------------- +// QTrace:1:type:<type>; +// ---------------- clayborg wrote: > Should we make all these new packets JSON based to start with? "jTrace"? If > we have any need for JSON at all in this or the other new packets I would say > lets just go with JSON packets. They are currently prefixed with "j". If we > go this route we should specify the mandatory key/value pairs in the header > doc. We should also allow a JSON dictionary from the trace config up at the > SBTrace layer to make it into this packet? I am fine prefixing the packets with "j", I did not understand what you meant by the last sentence. At the moment I am waiting for Pavel or Tamas to reply or anyone else and based on the complete feedback, I will upload a new patch if needed. https://reviews.llvm.org/D32585 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
