vbalu updated this revision to Diff 96878.
vbalu added a comment.
Removed the changes from test frame work.
https://reviews.llvm.org/D32522
Files:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py
Index:
packages/Python/lldbsuite/test/functionalities/proce
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
This is not necessary. NativeProcess classes are only used in lldb-server,
which is completely single threaded. If you want to change that, then we should
start with a discussion of
labath accepted this revision.
labath added inline comments.
Comment at: source/Utility/ConstString.cpp:49
+ // pointer, we don't need the lock.
const StringPoolEntryType &entry = GetStringMapEntryFromKeyData(ccstr);
return entry.getKey().size();
--
Author: labath
Date: Thu Apr 27 03:49:19 2017
New Revision: 301524
URL: http://llvm.org/viewvc/llvm-project?rev=301524&view=rev
Log:
Fix build for clang r301507
LangStandard::lang_opencl -> LangStandard::lang_opencl10
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/tru
labath closed this revision.
labath added a comment.
I already submitted a fix of my own before seeing this. Thanks for the patch
though. :)
https://reviews.llvm.org/D32584
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Cool. Thank you.
https://reviews.llvm.org/D32522
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: nitesh.jain
Date: Thu Apr 27 05:21:46 2017
New Revision: 301530
URL: http://llvm.org/viewvc/llvm-project?rev=301530&view=rev
Log:
[LLDB][MIPS] Fix TestMiExec.py failure.
Reviewers: ki.stfu, labath
Subscribers: jaydeep, bhushan, lldb-commits, slthakur
Differential Revision: https://revie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301530: [LLDB][MIPS] Fix TestMiExec.py failure. (authored by
nitesh.jain).
Changed prior to commit:
https://reviews.llvm.org/D32340?vs=96368&id=96890#toc
Repository:
rL LLVM
https://reviews.llvm.org
nitesh.jain updated this revision to Diff 96891.
nitesh.jain added a comment.
Update Diff as per suggestion
https://reviews.llvm.org/D32168
Files:
include/lldb/API/SBAddress.h
include/lldb/API/SBInstruction.h
include/lldb/API/SBInstructionList.h
include/lldb/Core/Disassembler.h
packa
ki.stfu added inline comments.
Comment at:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:329
+# We need to get past these instructions with a step to reach call
to s_MyFunction.
+self.runCmd("-exec-step --thread 1")
Author: labath
Date: Thu Apr 27 06:32:25 2017
New Revision: 301534
URL: http://llvm.org/viewvc/llvm-project?rev=301534&view=rev
Log:
TCPSocket: add back support for "*" address
before r301492, we could specify "*:1234" as an address to lldb-server
and it would interpret that as "any". I am not su
nitesh.jain added inline comments.
Comment at:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:329
+# We need to get past these instructions with a step to reach call
to s_MyFunction.
+self.runCmd("-exec-step --thread 1")
Author: nitesh.jain
Date: Thu Apr 27 07:27:42 2017
New Revision: 301537
URL: http://llvm.org/viewvc/llvm-project?rev=301537&view=rev
Log:
[LLDB][MIPS] Forgot to add check in commit rl301530
Reviewers: ki.stfu, labath
Subscribers: jaydeep, bhushan, lldb-commits, slthakur
Modified:
lldb/trunk/
nitesh.jain added a comment.
Hi Ki,
The changes has been committed (https://reviews.llvm.org/rL301537).
Thanks
Repository:
rL LLVM
https://reviews.llvm.org/D32340
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
joerg added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:55
const char *const LLDB_NT_OWNER_NETBSD = "NetBSD";
+const char *const LLDB_NT_OWNER_NETBSDCORE = "NetBSD-CORE";
const char *const LLDB_NT_OWNER_OPENBSD = "OpenBSD";
Not
clayborg added a comment.
looks fine
https://reviews.llvm.org/D32584
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
This patch does nicely follow the way other GDB remote packets are implemented.
I wonder if we should just have a "jTrace" packet that is JSON from the start?
This is more of a question to anyone that cares about the direction of the GDB
remote protocol we are using. W
clayborg added inline comments.
Comment at: include/lldb/API/SBInstructionList.h:36-38
+ // Its return the number of instructions between start and end address
+ // if canSetBreakpoint is true then count will correspond to
+ // number of instructions on which breakpoint can b
krytarowski added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:302
+ // default 32 or 64 bit arch (without any architecture revision) based on
+ // object file's class.
if (header.e_type == ET_CORE) {
joerg wrote:
> Unrelated
There is a file in the repo called git-clang-format. Make sure that file
is on your PATH somewhere, then just run `git clang-format`. It will only
touch lines that are part of your diff, and leave surrounding lines alone.
When making a diff, we only want to clang-format the lines we touched, not
In case it's not obvious, note the space in the command I said to run.
`git-clang-format` has a dash, and when you run `git clang-format` (with a
space), it will run the file with the dash.
On Thu, Apr 27, 2017 at 8:58 AM Zachary Turner wrote:
> There is a file in the repo called git-clang-form
Thanks, I will give it a try!
On 27.04.2017 17:59, Zachary Turner wrote:
> In case it's not obvious, note the space in the command I said to run.
> `git-clang-format` has a dash, and when you run `git clang-format`
> (with a space), it will run the file with the dash.
>
> On Thu, Apr 27, 2017 at
Author: cbieneman
Date: Thu Apr 27 11:04:26 2017
New Revision: 301553
URL: http://llvm.org/viewvc/llvm-project?rev=301553&view=rev
Log:
[CMake] Abstract Config.h generation for Xcode
This patch abstracts the generation of Config.h and creates a dummy project
entry point to allow generation of LL
Author: cbieneman
Date: Thu Apr 27 11:13:58 2017
New Revision: 301559
URL: http://llvm.org/viewvc/llvm-project?rev=301559&view=rev
Log:
Update GDB remote command regex for IPv6
This updates the regular expression used to match host/port pairs for the
gdb-remote command to also match IPv6 address
scott.smith marked 3 inline comments as done.
scott.smith added inline comments.
Comment at: source/Utility/ConstString.cpp:49
+ // pointer, we don't need the lock.
const StringPoolEntryType &entry = GetStringMapEntryFromKeyData(ccstr);
return entry.getKey().si
scott.smith added a comment.
In https://reviews.llvm.org/D32568#739190, @labath wrote:
> This is not necessary. NativeProcess classes are only used in lldb-server,
> which is completely single threaded. If you want to change that, then we
> should start with a discussion of what you intend to a
scott.smith created this revision.
This change forks a thread for each shared library, so that as much work as
possible can be done in parallel.
Repository:
rL LLVM
https://reviews.llvm.org/D32597
Files:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
source/Plugins/D
scott.smith added a comment.
1. This change requires https://reviews.llvm.org/D32568 for correctness.
2. I think the use of std::thread should be replaced by a custom TaskPool, or
else executables with thousands of shared libraries may have a problem. A
separate TaskPool is necessary to prevent
scott.smith created this revision.
Loading a shared library can require a large amount of work; rather than do
that serially for each library, provide a mechanism to do some amount of
priming before hand.
Repository:
rL LLVM
https://reviews.llvm.org/D32598
Files:
include/lldb/Core/Module
scott.smith added a comment.
Here's the controversial patch. It has been brought up that the intent is to
not load symbols before they are needed, but at least in my experience this
patch has no effect on performance when running:
lldb -b -o run /path/to/myprogram
where myprogram has main(){ret
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
Couple tiny tweaks to the comment, and this is good to go.
Comment at: include/lldb/API/SBInstructionList.h:36-38
+ // Its return the number of instructions betw
scott.smith added a comment.
Can I get a re-review on this? Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D32316
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham added a reviewer: clayborg.
jingham added a comment.
Adding Greg as a Reviewer.
Repository:
rL LLVM
https://reviews.llvm.org/D32598
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
labath created this revision.
Herald added a subscriber: srhines.
It turns out that even though ppoll is available on all the android
devices we support, it does not seem to be working properly on all of
them -- MainLoop just does a busy loop with ppoll returning EINTR and
not making any progress.
labath added a comment.
In https://reviews.llvm.org/D32568#739607, @scott.smith wrote:
> In https://reviews.llvm.org/D32568#739190, @labath wrote:
>
> > This is not necessary. NativeProcess classes are only used in lldb-server,
> > which is completely single threaded. If you want to change that,
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
This looks like a nice improvement. There are some formatting inconsistencies,
can you run clang-format?
https://reviews.llvm.org/D32600
___
lldb-
labath added a comment.
In https://reviews.llvm.org/D32149#738250, @krytarowski wrote:
> ping?
Sorry, I wasn't responding partially because I was waiting to see how the
discussion on https://reviews.llvm.org/D32434 settles, as I think it may have
effect on the test strategy. I'll write more t
krytarowski added a comment.
In https://reviews.llvm.org/D32149#739727, @labath wrote:
> In https://reviews.llvm.org/D32149#738250, @krytarowski wrote:
>
> > ping?
>
>
> Sorry, I wasn't responding partially because I was waiting to see how the
> discussion on https://reviews.llvm.org/D32434 sett
clayborg added a comment.
Making an empty main program and saying I see no difference is not enough
testing to enable this. I also don't see the benefit of this path. When LLDB is
used for symbolication, it might never actually load any debug info or symbols
from modules that are added to a tar
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
Instead of having the cache priming be determined by platform or something like
that, it would be better to add a setting (on the target level seems right)
that controls this. I t
scott.smith added a comment.
In https://reviews.llvm.org/D32568#739723, @labath wrote:
> All your other changes are client-side, so still think this will not matter,
> but I'll take a look. :)
Interesting. Maybe this only matters in the context of unit tests? I was
still getting crashes wit
scott.smith added a comment.
In https://reviews.llvm.org/D32598#739779, @clayborg wrote:
> Making an empty main program and saying I see no difference is not enough
> testing to enable this.
It's not quite an empty main program; it links in 40+ shared libraries with 2M+
symbols. The point of
scott.smith added a comment.
In https://reviews.llvm.org/D32598#739804, @jingham wrote:
> Instead of having the cache priming be determined by platform or something
> like that, it would be better to add a setting (on the target level seems
> right) that controls this. I think you are right th
"(lldb) settings set target.cache-priming foo"
On Thu, Apr 27, 2017 at 11:53 AM Scott Smith via Phabricator via
lldb-commits wrote:
> scott.smith added a comment.
>
> In https://reviews.llvm.org/D32598#739804, @jingham wrote:
>
> > Instead of having the cache priming be determined by platform or
jingham added a comment.
Ah, sorry. I was talking about an lldb, which you access through the "setting
set/get" command. Those are actually implemented by adding a property on the
class in question. Look in Target.cpp for the TargetProperties class. You'll
just want to add another property
scott.smith updated this revision to Diff 96976.
scott.smith added a comment.
Added setting. Verified that:
settings set target.cache-priming off
works as expected.
Repository:
rL LLVM
https://reviews.llvm.org/D32598
Files:
include/lldb/Core/Module.h
include/lldb/Symbol/SymbolFile.h
i
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This is picky but can you call it "symbol-cache-priming". The help text
explains it, but this is a very specific cache so we should scope it in case we
have some other one later o
Author: cbieneman
Date: Thu Apr 27 14:45:13 2017
New Revision: 301579
URL: http://llvm.org/viewvc/llvm-project?rev=301579&view=rev
Log:
Fix GreenDragon bots
We don't actually need to include Compiler.h here because it is only used on
Windows and Windows/PosixAPI.h includes it.
Modified:
lld
Author: cbieneman
Date: Thu Apr 27 14:45:16 2017
New Revision: 301580
URL: http://llvm.org/viewvc/llvm-project?rev=301580&view=rev
Log:
NFC. Add comment about debugserver usage
This just adds a comment to SocketAddress about it being used by debugserver
and the implications of that.
If we need
clayborg added a comment.
Would "preload-symbols" be a bit more clear and concise?
Repository:
rL LLVM
https://reviews.llvm.org/D32598
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
Author: cbieneman
Date: Thu Apr 27 14:56:54 2017
New Revision: 301581
URL: http://llvm.org/viewvc/llvm-project?rev=301581&view=rev
Log:
Fixing Windows bot
URL:
http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc2015/builds/8700
Modified:
lldb/trunk/include/lldb/Host/PosixApi.h
Modified:
jingham added a comment.
Yes, I like that better too.
Repository:
rL LLVM
https://reviews.llvm.org/D32598
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
scott.smith updated this revision to Diff 96990.
scott.smith added a comment.
1. Rename to preload-symbols / PreloadSymbols()
2. Modify an existing test to run with and without symbol preloading.
Repository:
rL LLVM
https://reviews.llvm.org/D32598
Files:
include/lldb/Core/Module.h
includ
scott.smith updated this revision to Diff 96991.
scott.smith added a comment.
Fix default param to setup_common so that we actually test both paths.
Repository:
rL LLVM
https://reviews.llvm.org/D32598
Files:
include/lldb/Core/Module.h
include/lldb/Symbol/SymbolFile.h
include/lldb/Symbo
jingham added a comment.
That test is good. That tests the lazy lookup of the dwarf type indices. The
other thing this changes is symbol reading. Can you also add a similar test
that relies on finding a symbol in a shared library we might not have read in?
It probably fine to add it to this
scott.smith updated this revision to Diff 97002.
scott.smith added a comment.
Add test to print expression (calls func, hence resolves symbols). Also better
parameterize the common test to reduce code duplication.
Repository:
rL LLVM
https://reviews.llvm.org/D32598
Files:
include/lldb/Co
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks for working on this!
Repository:
rL LLVM
https://reviews.llvm.org/D32598
___
lldb-commits mailing list
lldb-commits@list
Some of builders lost connection with master recently due to network glitch.
Thank you for understanding.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
eugene added inline comments.
Comment at: source/Host/common/MainLoop.cpp:82
+ int queue_id;
+ std::vector events;
+ struct kevent event_list[4];
here and below struct seems to be redundant
https://reviews.llvm.org/D32600
_
zturner added inline comments.
Comment at: source/Host/common/MainLoop.cpp:135
+
+template void MainLoop::RunImpl::ForEachReadFD(F &&f) {
+ assert(num_events >= 0);
Why do we need this function? Just have a function that returns an
`ArrayRef` and let the call
clayborg accepted this revision.
clayborg added a comment.
Looks good.
Repository:
rL LLVM
https://reviews.llvm.org/D32598
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: penryu
Date: Thu Apr 27 18:09:08 2017
New Revision: 301600
URL: http://llvm.org/viewvc/llvm-project?rev=301600&view=rev
Log:
integrate SBTrace changes into Xcode project
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http
scott.smith added a comment.
Can someone commit this for me? Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D32598
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
scott.smith created this revision.
Currently, the loop will insert entries into the class_contexts set, and then
use the absence or presence to affect decisions made by later iterations of the
same loop.
In order to support parallelizing the loop, this change moves those decisions
to always oc
scott.smith added a comment.
I welcome any suggestions on how to update the comments near the code I
touched. I can make the code functionally the same, but it doesn't mean I know
why it's doing what it's doing :-)
Comment at: source/Symbol/Symtab.cpp:382
- entry.cs
jingham added a reviewer: clayborg.
jingham added a comment.
Adding Greg as a reviewer. You can generally see from the CODE_OWNERS.txt
file who has overall responsibility for areas in lldb, and you should at least
assign them as a reviewer. For Symbol parsing stuff that's definitely Greg.
R
scott.smith abandoned this revision.
scott.smith added a comment.
Further testing shows this is not necessary. I'll abandon it.
Repository:
rL LLVM
https://reviews.llvm.org/D32568
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://
Author: kamil
Date: Thu Apr 27 19:29:54 2017
New Revision: 301603
URL: http://llvm.org/viewvc/llvm-project?rev=301603&view=rev
Log:
Resurrect the standalone build of LLDB
Switch includes "llvm/Config/config.h" to "llvm/Config/llvm-config.h".
Tested on NetBSD 7.99.70 amd64
Modified:
lldb/tru
Author: jingham
Date: Thu Apr 27 19:44:07 2017
New Revision: 301608
URL: http://llvm.org/viewvc/llvm-project?rev=301608&view=rev
Log:
Add a newline to suppress compiler warnings.
Modified:
lldb/trunk/include/lldb/Core/TraceOptions.h
Modified: lldb/trunk/include/lldb/Core/TraceOptions.h
URL:
Author: jingham
Date: Thu Apr 27 19:51:06 2017
New Revision: 301609
URL: http://llvm.org/viewvc/llvm-project?rev=301609&view=rev
Log:
Provide a mechanism to do some pre-loading of symbols up front.
Loading a shared library can require a large amount of work; rather than do
that serially for each
jingham closed this revision.
jingham added a comment.
Sure. Closed with r301609.
Repository:
rL LLVM
https://reviews.llvm.org/D32598
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
scott.smith abandoned this revision.
scott.smith added a comment.
Turns out I'm planning on making more drastic changes to this loop, so there's
no point in reviewing this step.
Repository:
rL LLVM
https://reviews.llvm.org/D32626
___
lldb-commit
72 matches
Mail list logo
