[Lldb-commits] [PATCH] D30702: Fix remaining threading issues in Log.h

labath added a comment. Comment at: include/lldb/Utility/Log.h:152 - Flags &GetOptions(); + const Flags GetOptions() const; eugene wrote: > Seems like const on return value is not really needed. Well... otherwise people could write something like: `log.

Re: [Lldb-commits] [PATCH] D30698: Resubmit "Use LLVM for all stat related calls"

I've tried it out not and it works -- I think it's good to go then. The unit tests, was that a debug build by any chance? I think we are missing some dependency there which shows up only on debug builds, but I haven't dug into that yet. On 7 March 2017 at 22:28, Zachary Turner wrote: > I can run

[Lldb-commits] [PATCH] D30702: Fix remaining threading issues in Log.h

labath updated this revision to Diff 90994. labath added a comment. I've repurposed the stream mutex to protect the entirety of enable/disable operations. To make this flow better, I've also gotten rid of the LogAndChannel struct and make Channel a member of Log directly (which required moving som

Re: [Lldb-commits] [PATCH] D30698: Resubmit "Use LLVM for all stat related calls"

Yes it was a debug build On Wed, Mar 8, 2017 at 2:45 AM Pavel Labath wrote: > I've tried it out not and it works -- I think it's good to go then. > > The unit tests, was that a debug build by any chance? I think we are > missing some dependency there which shows up only on debug builds, but > I h

[Lldb-commits] [lldb] r297279 - Android.rules: fix computation of gcc toolchain directory on arm

Author: labath Date: Wed Mar 8 08:57:15 2017 New Revision: 297279 URL: http://llvm.org/viewvc/llvm-project?rev=297279&view=rev Log: Android.rules: fix computation of gcc toolchain directory on arm The toolchain directory for arm android targets was computed incorrectly. The architecture part sho

[Lldb-commits] [PATCH] D30737: Android.rules: Add libc++ support

labath created this revision. Herald added a subscriber: srhines. Herald added a reviewer: EricWF. This adds support for building libc++ tests when targetting android. The tests are still not passing due to several other problems, but this way we can at least build them. https://reviews.llvm.org

[Lldb-commits] [PATCH] D30698: Resubmit "Use LLVM for all stat related calls"

This revision was automatically updated to reflect the committed changes. Closed by commit rL297300: Resubmit FileSystem changes. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D30698?vs=90905&id=91044#toc Repository: rL LLVM https://reviews.llvm.org/D30698 Files:

[Lldb-commits] [lldb] r297300 - Resubmit FileSystem changes.

Author: zturner Date: Wed Mar 8 11:56:08 2017 New Revision: 297300 URL: http://llvm.org/viewvc/llvm-project?rev=297300&view=rev Log: Resubmit FileSystem changes. This was originall reverted due to some test failures in ModuleCache and TestCompDirSymlink. These issues have all been resolved and

[Lldb-commits] [PATCH] D30702: Fix remaining threading issues in Log.h

zturner accepted this revision. zturner added inline comments. Comment at: source/Utility/Log.cpp:82 + if (mask | flags) { +m_options.store(options, std::memory_order_release); +m_stream_sp = stream_sp; Might as well use `memory_order_relaxed` here. ==

[Lldb-commits] [lldb] r297360 - Remove LLDB's recursive directory deletion function.

Author: zturner Date: Wed Mar 8 23:12:36 2017 New Revision: 297360 URL: http://llvm.org/viewvc/llvm-project?rev=297360&view=rev Log: Remove LLDB's recursive directory deletion function. LLVM now has such a function, so we use that instead. Modified: lldb/trunk/include/lldb/Host/FileSystem.h