[Lldb-commits] [PATCH] D29669: Hardware breakpoints implementation for AArch64 targets

2017-02-15 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid updated this revision to Diff 88505. omjavaid added a comment. This patch has following updates: 1. Support for Arm hardware breakpoints 2. LLDBServer Test cases for testing Z1 z1 packets. 3. Test case to test hardware breakpoint command and multi-threaded hardware breakpoints. 4. Get r

[Lldb-commits] [lldb] r295168 - Bug 30863 - Step doesn't stop with conditional breakpoint on the next line

2017-02-15 Thread Boris Ulasevich via lldb-commits
Author: bulasevich Date: Wed Feb 15 05:42:47 2017 New Revision: 295168 URL: http://llvm.org/viewvc/llvm-project?rev=295168&view=rev Log: Bug 30863 - Step doesn't stop with conditional breakpoint on the next line Differential Revisions: https://reviews.llvm.org/D26497 (committed r290168, temporar

[Lldb-commits] [PATCH] D29932: Fix TestNameLookup for GCC

2017-02-15 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL295170: Fix TestNameLookup for GCC (authored by labath). Changed prior to commit: https://reviews.llvm.org/D29932?vs=88347&id=88509#toc Repository: rL LLVM https://reviews.llvm.org/D29932 Files:

[Lldb-commits] [lldb] r295171 - Fix unittests after r295088

2017-02-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 15 06:27:19 2017 New Revision: 295171 URL: http://llvm.org/viewvc/llvm-project?rev=295171&view=rev Log: Fix unittests after r295088 This resurrects TestModule.so which got lost during the move and is needed for the ModuleCache test. Added: lldb/trunk/unittests/Ta

[Lldb-commits] [lldb] r295170 - Fix TestNameLookup for GCC

2017-02-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 15 06:27:16 2017 New Revision: 295170 URL: http://llvm.org/viewvc/llvm-project?rev=295170&view=rev Log: Fix TestNameLookup for GCC Summary: GCC emits also symbols for the __PRETTY_FUNCTION__ virtual variable, which we accidentaly pick up when looking for functions for

[Lldb-commits] [PATCH] D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone

2017-02-15 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added a project: LLDB. Herald added a subscriber: aemerson. Use both LLDB- and LLVM-specific tool/library directories when LLDB is being built stand-alone. This ensures that the freshly-built tools (and libraries) are used correctly. Without this patch, the te

[Lldb-commits] [PATCH] D29964: Finish breaking the dependency from lldbUtility -> Host

2017-02-15 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Utility/VASprintf.cpp:18 + va_list args) { + llvm::SmallString<16> error(""); + It doesn't look like you should need to allocate a stack object with the string every time. Can't y

Re: [Lldb-commits] [PATCH] D29964: Finish breaking the dependency from lldbUtility -> Host

2017-02-15 Thread Zachary Turner via lldb-commits
On Wed, Feb 15, 2017 at 5:54 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added inline comments. > > > > Comment at: lldb/source/Utility/VASprintf.cpp:18 > + va_list args) { > + llvm::SmallString<16> error(""); > + >

[Lldb-commits] [lldb] r295189 - Fix debug build of unit tests

2017-02-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 15 10:11:51 2017 New Revision: 295189 URL: http://llvm.org/viewvc/llvm-project?rev=295189&view=rev Log: Fix debug build of unit tests Summary: It turns out listing each library twice is not enough to resolve all references in a debug build on linux - a number of execu

[Lldb-commits] [PATCH] D29888: Fix debug build of unit tests

2017-02-15 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL295189: Fix debug build of unit tests (authored by labath). Changed prior to commit: https://reviews.llvm.org/D29888?vs=88177&id=88544#toc Repository: rL LLVM https://reviews.llvm.org/D29888 Files:

[Lldb-commits] [lldb] r295190 - Refactor log channel registration mechanism

2017-02-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 15 10:11:59 2017 New Revision: 295190 URL: http://llvm.org/viewvc/llvm-project?rev=295190&view=rev Log: Refactor log channel registration mechanism Summary: We currently have two log channel registration mechanisms. One uses a set of function pointers and the other on

[Lldb-commits] [PATCH] D29895: Refactor log channel registration mechanism

2017-02-15 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL295190: Refactor log channel registration mechanism (authored by labath). Changed prior to commit: https://reviews.llvm.org/D29895?vs=88395&id=88545#toc Repository: rL LLVM https://reviews.llvm.org/

[Lldb-commits] [PATCH] D29144: LLDB: fix for TestCallThatThrows.py test fail

2017-02-15 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. The test added by this batch is failing on windows http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/2499, for a very prosaic reason - we cannot run a "make clean" as something is holding the executable file open. Based on my debugging, it is not a problem i

[Lldb-commits] [lldb] r295201 - Revert "Refactor log channel registration mechanism"

2017-02-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 15 11:13:19 2017 New Revision: 295201 URL: http://llvm.org/viewvc/llvm-project?rev=295201&view=rev Log: Revert "Refactor log channel registration mechanism" The change breaks on Windows and NetBSD bots. Revert while I investigate. Modified: lldb/trunk/include/lld

[Lldb-commits] [lldb] r295211 - Skip TestStepOverBreakpoint on windows

2017-02-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Feb 15 12:04:50 2017 New Revision: 295211 URL: http://llvm.org/viewvc/llvm-project?rev=295211&view=rev Log: Skip TestStepOverBreakpoint on windows Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/step_over_breakpoint/TestStepOverBreakpoi

[Lldb-commits] [lldb] r295212 - Fix Xcode project.

2017-02-15 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Wed Feb 15 12:24:44 2017 New Revision: 295212 URL: http://llvm.org/viewvc/llvm-project?rev=295212&view=rev Log: Fix Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://llvm.org/viewvc/llvm

[Lldb-commits] [PATCH] D30006: [lldb] Remove the "MemoryHistory" plugin type and merge it into InstrumentationRuntime

2017-02-15 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek created this revision. kubamracek added a project: Sanitizers. Herald added a subscriber: mgorny. There is currently a single MemoryHistory plugin, which is for AddressSanitizer. Let's merge the feature into InstrumentationRuntime plugins. I'm thinking of implementing another provid

[Lldb-commits] [PATCH] D30007: [lldb] Provide API to know which sanitizer generated an eStopReasonInstrumentation

2017-02-15 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek created this revision. kubamracek added a project: Sanitizers. We can provide this via StopReason->GetValue(). This is important so that users of SB API can treat various sanitizers differently (the extended stop reason data is also structured differently for different sanitizers).

[Lldb-commits] [PATCH] D30007: [lldb] Provide API to know which sanitizer generated an eStopReasonInstrumentation

2017-02-15 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. I am fine as long is Jim Ingham is fine. Jim, if you are good with this, just put it into Accept Revision. https://reviews.llvm.org/D30007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D29964: Finish breaking the dependency from lldbUtility -> Host

2017-02-15 Thread Zachary Turner via Phabricator via lldb-commits
zturner updated this revision to Diff 88626. https://reviews.llvm.org/D29964 Files: lldb/include/lldb/Host/PseudoTerminal.h lldb/include/lldb/Utility/PseudoTerminal.h lldb/include/lldb/Utility/VASPrintf.h lldb/source/Host/CMakeLists.txt lldb/source/Host/common/PseudoTerminal.cpp lldb/

[Lldb-commits] [lldb] r295271 - Fix a bug introduced in r235737 where code with important side

2017-02-15 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Feb 15 20:08:33 2017 New Revision: 295271 URL: http://llvm.org/viewvc/llvm-project?rev=295271&view=rev Log: Fix a bug introduced in r235737 where code with important side effects was passed as an expression to assert() calls. If lldb is built without asserts, the expres

[Lldb-commits] [PATCH] D30024: [lldb] Add support for "external" reports in ThreadSanitizer LLDB plugin

2017-02-15 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek created this revision. TSan now has the ability to report races on "external" object, i.e. any library class/object that has read-shared write-exclusive threading semantics. The detection and reporting work almost out of the box, but TSan can now provide the type of the object (as a