This revision was automatically updated to reflect the committed changes.
Closed by commit rL295170: Fix TestNameLookup for GCC (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D29932?vs=88347&id=88509#toc
Repository:
rL LLVM
https://reviews.llvm.org/D29932
Files:
lldb/trunk/packages/Python/lldbsuite/test/python_api/name_lookup/TestNameLookup.py
Index:
lldb/trunk/packages/Python/lldbsuite/test/python_api/name_lookup/TestNameLookup.py
===================================================================
---
lldb/trunk/packages/Python/lldbsuite/test/python_api/name_lookup/TestNameLookup.py
+++
lldb/trunk/packages/Python/lldbsuite/test/python_api/name_lookup/TestNameLookup.py
@@ -20,7 +20,6 @@
mydir = TestBase.compute_mydir(__file__)
@add_test_categories(['pyapi'])
- @expectedFailureAll(compiler="gcc")
def test_target(self):
"""Exercise SBTarget.FindFunctions() with various name masks.
@@ -44,7 +43,7 @@
for i in range(num_symbols):
symbol = exe_module.GetSymbolAtIndex(i);
name = symbol.GetName()
- if name and 'unique_function_name' in name:
+ if name and 'unique_function_name' in name and
'__PRETTY_FUNCTION__' not in name:
mangled = symbol.GetMangledName()
if mangled:
mangled_to_symbol[mangled] = symbol
@@ -56,6 +55,7 @@
# Make sure each mangled name turns up exactly one match when looking
up
# functions by full name and using the mangled name as the name in the
# lookup
+ self.assertGreaterEqual(len(mangled_to_symbol), 6)
for mangled in mangled_to_symbol.keys():
symbol_contexts = target.FindFunctions(mangled,
lldb.eFunctionNameTypeFull)
self.assertTrue(symbol_contexts.GetSize() == 1)
Index: lldb/trunk/packages/Python/lldbsuite/test/python_api/name_lookup/TestNameLookup.py
===================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/python_api/name_lookup/TestNameLookup.py
+++ lldb/trunk/packages/Python/lldbsuite/test/python_api/name_lookup/TestNameLookup.py
@@ -20,7 +20,6 @@
mydir = TestBase.compute_mydir(__file__)
@add_test_categories(['pyapi'])
- @expectedFailureAll(compiler="gcc")
def test_target(self):
"""Exercise SBTarget.FindFunctions() with various name masks.
@@ -44,7 +43,7 @@
for i in range(num_symbols):
symbol = exe_module.GetSymbolAtIndex(i);
name = symbol.GetName()
- if name and 'unique_function_name' in name:
+ if name and 'unique_function_name' in name and '__PRETTY_FUNCTION__' not in name:
mangled = symbol.GetMangledName()
if mangled:
mangled_to_symbol[mangled] = symbol
@@ -56,6 +55,7 @@
# Make sure each mangled name turns up exactly one match when looking up
# functions by full name and using the mangled name as the name in the
# lookup
+ self.assertGreaterEqual(len(mangled_to_symbol), 6)
for mangled in mangled_to_symbol.keys():
symbol_contexts = target.FindFunctions(mangled, lldb.eFunctionNameTypeFull)
self.assertTrue(symbol_contexts.GetSize() == 1)
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
