Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

2016-09-03 Thread Vyacheslav Karpukhin via lldb-commits
stigger added a comment. Ping. https://reviews.llvm.org/D20041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

2016-09-03 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner added a comment. I like the approach taken here in general. One thing that I wonder about, if we have the Triple, why do we even need the PathSyntax at all? In light of the fact that not all Posix filesystems are case sensitive, this calls into ques

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

2016-09-03 Thread Vyacheslav Karpukhin via lldb-commits
stigger added a comment. In https://reviews.llvm.org/D20041#533725, @zturner wrote: > How difficult would be it be to eliminate the `PathSyntax` enumeration > entirely and update every user of `PathSyntax` to use a triple instead? I've attempted to do it and hit two issues which I'm not sure h

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

2016-09-03 Thread Zachary Turner via lldb-commits
For #2 you can use llvm::GetProcessTriple(), i will think about #1 when I have a chance to look at the code On Sat, Sep 3, 2016 at 2:38 PM Vyacheslav Karpukhin < vyaches...@karpukhin.com> wrote: > stigger added a comment. > > In https://reviews.llvm.org/D20041#533725, @zturner wrote: > > > How dif

[Lldb-commits] [lldb] r280606 - XFAIL TestGdbRemoteExitCode failing tests

2016-09-03 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Sat Sep 3 19:43:10 2016 New Revision: 280606 URL: http://llvm.org/viewvc/llvm-project?rev=280606&view=rev Log: XFAIL TestGdbRemoteExitCode failing tests Tracked by: llvm.org/pr30271 Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/exit-code/TestGdb