zturner added a subscriber: zturner.
zturner added a comment.

I like the approach taken here in general.

One thing that I wonder about, if we have the Triple, why do we even need the 
PathSyntax at all?  In light of the fact that not all Posix filesystems are 
case sensitive, this calls into question the usefulness of the Path Syntax 
since it is both unnecessary and insufficient.

I do think that `FileSpec` should be completely independent of `Host`.  Any 
host detection code should be in `FileSystem.h` and any remote detection code 
should be in `Platform` somewhere.  Both of those are independent of this patch 
though.

How difficult would be it be to eliminate the `PathSyntax` enumeration entirely 
and update every user of `PathSyntax` to use a triple instead?


https://reviews.llvm.org/D20041



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to