Author: aidandodds
Date: Thu Feb 18 04:59:46 2016
New Revision: 261202
URL: http://llvm.org/viewvc/llvm-project?rev=261202&view=rev
Log:
[Renderscript] Refactor .rs.info parser.
This patch refactors the .rs.info table parser so that its more in line with
the current language runtime code.
Modif
Author: tberghammer
Date: Thu Feb 18 05:12:18 2016
New Revision: 261205
URL: http://llvm.org/viewvc/llvm-project?rev=261205&view=rev
Log:
Improve the handling of missing elf symtab and missing symbol sizes
* Generate artificial symbol names from eh_fame during symbol parsing
so these symbols ar
Author: bhushan.attarde
Date: Thu Feb 18 05:53:28 2016
New Revision: 261206
URL: http://llvm.org/viewvc/llvm-project?rev=261206&view=rev
Log:
[LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for
MIPS
SUMMARY:
This patch implements ArchSpec::GetClangTargetCP
EwanCrawford created this revision.
EwanCrawford added reviewers: sivachandra, zturner, labath.
EwanCrawford added a subscriber: lldb-commits.
EwanCrawford set the repository for this revision to rL LLVM.
Commit r260721(http://reviews.llvm.org/D17182) introduced the following error
when building
Ahh, I guess that's why that star was there before, maybe it makes the
entire symbol optional? Anyway lgtm
On Thu, Feb 18, 2016 at 8:36 AM Ewan Crawford wrote:
> EwanCrawford created this revision.
> EwanCrawford added reviewers: sivachandra, zturner, labath.
> EwanCrawford added a subscriber:
Author: ewancrawford
Date: Thu Feb 18 11:01:40 2016
New Revision: 261227
URL: http://llvm.org/viewvc/llvm-project?rev=261227&view=rev
Log:
Fix OSX cmake build
Commit r260721(http://reviews.llvm.org/D17182) introduced the following error
when building for OSX using cmake:
Undefined symbols for a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261227: Fix OSX cmake build (authored by EwanCrawford).
Changed prior to commit:
http://reviews.llvm.org/D17384?vs=48325&id=48336#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17384
Files:
lldb
ldrumm added a comment.
Hi @spyffe @jingham
If you have the time, I'd appreciate your comments.
Thanks
Luke
http://reviews.llvm.org/D17027
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ADodds created this revision.
ADodds added reviewers: clayborg, emaste, ted, zturner, jasonmolenda.
ADodds added a subscriber: lldb-commits.
ADodds set the repository for this revision to rL LLVM.
Herald added a subscriber: emaste.
This patch aims to reduce the code duplication among all of the pl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261240: Fix SocketTest on Windows. (authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D17106?vs=47537&id=48360#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17106
Files:
ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261241: Add target and host platform enumerations so we're
not using strings. (authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D17088?vs=47684&id=48361#toc
Repository:
rL LLVM
Author: zturner
Date: Thu Feb 18 12:49:56 2016
New Revision: 261240
URL: http://llvm.org/viewvc/llvm-project?rev=261240&view=rev
Log:
Fix SocketTest on Windows.
Differential Revision: http://reviews.llvm.org/D17106
Modified:
lldb/trunk/unittests/Host/SocketAddressTest.cpp
Modified: lldb/tru
Author: zturner
Date: Thu Feb 18 12:50:02 2016
New Revision: 261241
URL: http://llvm.org/viewvc/llvm-project?rev=261241&view=rev
Log:
Add target and host platform enumerations so we're not using strings.
Differential Revision: http://reviews.llvm.org/D17088
Added:
lldb/trunk/packages/Python/
Author: eugenezelenko
Date: Thu Feb 18 12:52:47 2016
New Revision: 261242
URL: http://llvm.org/viewvc/llvm-project?rev=261242&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Target;
other minor fixes.
Modified:
lldb/trunk/source/Target/ProcessInfo.cpp
emaste created this revision.
emaste added a subscriber: lldb-commits.
Herald added a subscriber: emaste.
On FreeBSD _LIBCPP_EXTERN_TEMPLATE is being defined from something included by
lldb/lldb-private.h. Undefine it later to avoid the redefinition warning.
http://reviews.llvm.org/D17402
Files
Author: enrico
Date: Thu Feb 18 13:23:52 2016
New Revision: 261246
URL: http://llvm.org/viewvc/llvm-project?rev=261246&view=rev
Log:
Fix a typo in FormatCache.cpp such that the cache would potentially return an
invalid format in some cases
Modified:
lldb/trunk/source/DataFormatters/FormatCa
Author: emaste
Date: Thu Feb 18 15:38:24 2016
New Revision: 261266
URL: http://llvm.org/viewvc/llvm-project?rev=261266&view=rev
Log:
Remove expectedFlakeyFreeBSD decorator for prompt setting
The race condition/use after free involved in setting long prompts
appears to be fixed now (although I do
Author: eugenezelenko
Date: Thu Feb 18 16:39:14 2016
New Revision: 261272
URL: http://llvm.org/viewvc/llvm-project?rev=261272&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in
source/Commands/CommandObjectBreakpoint.cpp; other minor fixes.
Modified:
ll
zturner created this revision.
zturner added reviewers: clayborg, labath, amccarth.
zturner added a subscriber: lldb-commits.
For seemingly no reason today, I started getting crashes on exit in
`CleanupProcessSpecificTempDirectory` when I ran certain tests. I determined
this wasn't related to a
amccarth added inline comments.
Comment at: source/Host/common/HostInfoBase.cpp:88
@@ +87,3 @@
+{
+CleanupProcessSpecificLLDBTempDir();
+delete g_fields;
There's a difference in behavior in that this now happens even if we haven't
(yet) created a temp dir
zturner updated this revision to Diff 48414.
zturner added a comment.
This should make sure it happens if and only if the directory was successfully
created earlier during program execution.
http://reviews.llvm.org/D17420
Files:
include/lldb/Host/HostInfoBase.h
source/Host/common/HostInfoB
zturner marked an inline comment as done.
zturner added a comment.
http://reviews.llvm.org/D17420
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jingham
Date: Thu Feb 18 17:58:45 2016
New Revision: 261279
URL: http://llvm.org/viewvc/llvm-project?rev=261279&view=rev
Log:
Make sure code that is in the middle of figuring out the correct architecture
on attach uses the architecture it has figured out, rather than the Target's
architect
Author: jmolenda
Date: Thu Feb 18 18:05:17 2016
New Revision: 261280
URL: http://llvm.org/viewvc/llvm-project?rev=261280&view=rev
Log:
This patch stops lldb from loading a .lldbinit file from the current
working directory by default -- a typical security problem that we
need to be more conservativ
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will let Sean Callanan OK this one.
http://reviews.llvm.org/D17273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.o
sas created this revision.
sas added a reviewer: tfiala.
sas added a subscriber: lldb-commits.
This makes cloning (and therefore the whole build) faster.
The checkout step goes from ~4m to ~30s on my host.
http://reviews.llvm.org/D17425
Files:
scripts/Xcode/lldbbuild.py
Index: scripts/Xcode/l
clayborg accepted this revision.
clayborg added a comment.
Looks good to me.
http://reviews.llvm.org/D17295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will defer to Sean Callanan.
Repository:
rL LLVM
http://reviews.llvm.org/D17167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Aside from a minor nit, this looks like good cleanup. If it passes the
testsuite, feel free to commit after addressing the inline comment.
Comment at: source/Plugins/Express
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
Looks fine to me, but let's put in an assertion to make sure our assumptions in
making this change are not violated.
Comment at: source/Expression/Materializer.cpp:
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So the main issue is to fix the:
uint32_t
SymbolFilePDB::ResolveSymbolContext(const lldb_private::FileSpec &file_spec,
uint32_t line, bool check_inlines,
clayborg accepted this revision.
clayborg added a comment.
The HostInfoBase::Initialize() and HostInfoBase::Terminate() might be good
places for your PDB calls like ::CoUninitialize(); to be placed...
http://reviews.llvm.org/D17420
___
lldb-commits
emaste added a comment.
Nice work, happy to see this deduplication.
Repository:
rL LLVM
http://reviews.llvm.org/D17395
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:98-100
@@ +97,5 @@
+{
+auto global = m_session->getGlobalScope();
+auto compilands = global->findAllChildren();
+return compilands->getChildCount();
+}
clayborg
clayborg added a comment.
There are problems with the source file IDs you are using as they currently
must be indexes into the compile unit's support files. See inline comments for
more details.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:146
@@ +145,3 @@
+
+
zturner added a comment.
I didn't respond to all your comments because I don't have the code in front of
me. I'll take a look at the rest of the comments tomorrow.
Comment at: source/Initialization/SystemInitializerCommon.cpp:202-204
@@ -198,1 +201,5 @@
+
+#if defined(_MSC_VER
36 matches
Mail list logo
