[Lldb-commits] [PATCH] D17266: delete unused function in ClangExpressionParser`

2016-02-15 Thread Luke Drummond via lldb-commits
ldrumm created this revision. ldrumm added reviewers: clayborg, spyffe, jingham. ldrumm added a subscriber: lldb-commits. [git 65dafa83] introduced the `GetBuiltinIncludePath` function copied from [cfe/lib/Driver/CC1Options.cpp](http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/CC1Options.

[Lldb-commits] [PATCH] D17273: refactor/cleanup ClangExpressionParser::Parse

2016-02-15 Thread Luke Drummond via lldb-commits
ldrumm created this revision. ldrumm added reviewers: clayborg, zturner, spyffe. ldrumm added a subscriber: lldb-commits. - fix return type: `ClangExpressionParser::Parse` returns unsigned, but was actually returning a signed value, `num_errors`. - use helper `clang::TextDiagnosticBuffer::get

Re: [Lldb-commits] [PATCH] D17088: Add target and host platform enums so we're not using strings everywhere

2016-02-15 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. LGTM. Having the single list to cover host and target is a good way to go here, too. http://reviews.llvm.org/D17088 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

[Lldb-commits] [lldb] r260909 - Refinement of r260624. It is possible somebody might try to add to the map

2016-02-15 Thread Jim Ingham via lldb-commits
Author: jingham Date: Mon Feb 15 14:04:15 2016 New Revision: 260909 URL: http://llvm.org/viewvc/llvm-project?rev=260909&view=rev Log: Refinement of r260624. It is possible somebody might try to add to the map while we are finalizing its elements. Prevent that. Modified: lldb/trunk/include

[Lldb-commits] [PATCH] D17274: improve readability and performance of ClangExpressionParser::FindFunctionInModule

2016-02-15 Thread Luke Drummond via lldb-commits
ldrumm created this revision. ldrumm added reviewers: spyffe, dawn. ldrumm added a subscriber: lldb-commits. - Prefer `llvm::StringRef::find` over allocating a `std::string` and then discarding it after calling the equivalent `find` method. - improve readability of function iterator, and make the

Re: [Lldb-commits] [PATCH] D17274: improve readability and performance of ClangExpressionParser::FindFunctionInModule

2016-02-15 Thread Jim Ingham via lldb-commits
jingham added a subscriber: jingham. jingham added a comment. Other than that is looks fine. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:559-560 @@ -558,5 +558,4 @@ -static bool FindFunctionInModule (ConstString &mangled_name, -

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

2016-02-15 Thread Luke Drummond via lldb-commits
Hi Jim On 10/02/16 17:02, Jim Ingham wrote: On Feb 10, 2016, at 3:45 AM, Luke Drummond wrote: ldrumm added a comment. In http://reviews.llvm.org/D17027#347487, @jingham wrote: This seems fine as a generic instrumentation point. Obviously, the onus in on the passes, since they could to

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

2016-02-15 Thread Luke Drummond via lldb-commits
ldrumm added a subscriber: ldrumm. ldrumm added a comment. Hi Jim http://reviews.llvm.org/D17027 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16412: remove unused local string in IRForTarget.cpp

2016-02-15 Thread Luke Drummond via lldb-commits
ldrumm updated this revision to Diff 48006. ldrumm added a comment. rebased on current HEAD http://reviews.llvm.org/D16412 Files: source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Index: source/Plugins/ExpressionParser/Clang/IRForTarget.cpp ===

[Lldb-commits] [lldb] r260914 - Silence some clang warnings

2016-02-15 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Mon Feb 15 15:50:28 2016 New Revision: 260914 URL: http://llvm.org/viewvc/llvm-project?rev=260914&view=rev Log: Silence some clang warnings Silences -Wmissing-brace and -Wformat-pedantic warnings from clang on Linux. NFC. Modified: lldb/trunk/source/Plugins/Language

[Lldb-commits] [lldb] r260930 - Add -Wimplicit-fallthrough command line option to clang in

2016-02-15 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Feb 15 22:14:33 2016 New Revision: 260930 URL: http://llvm.org/viewvc/llvm-project?rev=260930&view=rev Log: Add -Wimplicit-fallthrough command line option to clang in the xcode project file to catch switch statements that have a case that falls through unintentionally.

[Lldb-commits] [lldb] r260932 - Fix buildbot failure because I got an include path wrong.

2016-02-15 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Feb 15 22:20:56 2016 New Revision: 260932 URL: http://llvm.org/viewvc/llvm-project?rev=260932&view=rev Log: Fix buildbot failure because I got an include path wrong. Modified: lldb/trunk/source/Commands/CommandObjectMemory.cpp Modified: lldb/trunk/source/Commands/C