jingham added a subscriber: jingham.
jingham added a comment.
Other than that is looks fine.
================
Comment at:
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:559-560
@@ -558,5 +558,4 @@
-static bool FindFunctionInModule (ConstString &mangled_name,
- llvm::Module *module,
- const char *orig_name)
+static bool
+FindFunctionInModule(ConstString &mangled_name, llvm::Module *module, const
char *orig_name)
{
----------------
Don't make this kind of change, please. As long as the arguments fit in 120
characters we don't have a rule one way or the other about how to write
argument lists like this. But changing them just because they look better to
you results in unnecessary churn. Moreover, this is changing it away from the
way all the other functions in this source file are written, so it ends up
looking odd.
http://reviews.llvm.org/D17274
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
